Project

General

Profile

Feature #1524

Feature #1522: Jetty Upgrade

merge existing patches if necessary

Added by Greg Shah over 11 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius Gligor
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
10/24/2013
Due date:
10/25/2013
% Done:

100%

Estimated time:
8.00 h
billable:
No
vendor_id:
GCD

jetty-9.1-howtobuild.txt Magnifier - Steps to build jetty 9.1 project (7.74 KB) Marius Gligor, 10/30/2013 03:37 AM

Related issues

Blocks User Interface - Feature #1525: submit patches upstream (if the patches are still needed) Closed 10/31/2013 11/08/2013

History

#1 Updated by Greg Shah over 11 years ago

  • Assignee set to Stanislav Lomany

Review and merge our patches as needed. If there is a way to implement Jetty in our server without our patches, please switch to that. Otherwise, update our patches to work with the target Jetty version.

Then review the process for submitting our patches to the upstream Jetty project itself. Inform me of the process. I am pretty sure that Eric or myself will have to submit some contract or paperwork before we can send our patches. We will also probably have to meet their coding standards and possibly change our patch to fit their conventions.

#2 Updated by Greg Shah over 11 years ago

  • Target version set to Milestone 12

#3 Updated by Greg Shah over 10 years ago

  • Start date changed from 09/10/2012 to 10/24/2013
  • Estimated time set to 8.00
  • Due date set to 10/25/2013
  • Assignee changed from Stanislav Lomany to Marius Gligor

As noted in #1523, we will use Jetty 9.1 as the target version.

The previous patch can be found in p2j at lib/jetty_6.1.14_SslSocketConnector.java.20090111_patch. It was used to patch Jetty 6.1.14, which is the version integrated into P2J at this time.

#4 Updated by Marius Gligor over 10 years ago

  • Status changed from New to WIP

#5 Updated by Marius Gligor over 10 years ago

  • Status changed from WIP to Review

#6 Updated by Marius Gligor over 10 years ago

  • % Done changed from 0 to 100

#7 Updated by Marius Gligor over 10 years ago

Building jetty 9.1

1. Install git and maven.

2. Checkout the jetty project from github branch release-9.1

3. Build jetty project. The first build take a long time (25 minutes)
as Maven downloads all the dependencies and because.
For more details see the README.TXT file located in the root of the project ($JETTY_HOME).

4. After the build is completed with success the result is a lot of
jar files (sources, javadoc and binaries) for each module that can be used with jetty.
However in the folder $JETTY_HOME/aggregates/jetty-all is a pom.xml file that can be used
to build the jetty-all artifact, a single jar file jetty-all-9.1.0-SNAPSHOT.jar

For more details please read the attached file.

#8 Updated by Marius Gligor over 10 years ago

The SslSocketConnector.java file is no longer part of the project.
I searched the project for snippets of code like on the old SslSocketConnector class but I didn't find any relevant text.
A new class ServerConnector is used on jetty 9.1 instead SslSocketConnector.
In conclusion the patch file jetty_6.1.14_SslSocketConnector.java.20090111_patch cannot be applied on jetty 9.1 project.

#9 Updated by Greg Shah over 10 years ago

If I recall correctly, the patch was to provide accessors so that we could set some of the SSL configuration via program. Without those changes it would have required a configuration file to be maintained for every installation and we wanted to just reuse configuration that we already had in the directory.

It is important that we can do the equivalent thing in the new version.

#10 Updated by Greg Shah over 10 years ago

  • Status changed from Review to Closed

HTTPS testing shows that we no longer need the patches after the upgrade.

#11 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF