Feature #1885: fix and add necessary format string support - Base Language - Golden Code Redmine

Feature #1885

fix and add necessary format string support

Added by Greg Shah over 11 years ago. Updated over 7 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Target version:

FWD - Cleanup and Stablization for Server Features

Start date:

03/05/2013

Due date:

09/04/2013

% Done:

100%

Estimated time:

(Total: 40.00 h)

billable:

vendor_id:

GCD

ca_upd20130305g.zip (267 KB) Constantin Asofiei, 03/05/2013 05:04 PM

ca_upd20130306a.zip (281 KB) Constantin Asofiei, 03/06/2013 02:32 AM

Subtasks

History

#1 Updated by Constantin Asofiei about 11 years ago

There is at least one format string problem in the server. Looks like PUT fields can have a dynamic format, and any expression can be used:

def stream rpt.
def var ch as char.

find first book.
output stream rpt to put_test.txt.
PUT STREAM rpt book.book-title FORMAT "x(15)" + " ". /* this is a complex expression which gets evaluated at runtime */

ch = "x(10)".
PUT STREAM rpt book.book-title FORMAT ch. /* this must be the ch var not the "ch" string. ch is evaluated at runtime and if is not a valid format, some message is shown */

output stream rpt close.

I guess I'm taking this at least to fix the put field's format. I'll add another task to track the conversion support for this.

#2 Updated by Constantin Asofiei about 11 years ago

File ca_upd20130305g.zip added

This fixes the conversion problem, still need to expand PutField c'tors to accept character for the format... or, can we just call "toStringMessage()" for the expression, so we will not duplicate all the c'tors which accept String format ?

#3 Updated by Greg Shah about 11 years ago

Yes, using toStringMessage() is a great idea.

#4 Updated by Constantin Asofiei about 11 years ago

File ca_upd20130306a.zip added

This version emits the toStringMessage in case the format is a complex expression, for PUT field. Also, adds a TODO in PutField class, to validate the format.