Project

General

Profile

Bug #2061

unreachable code is too aggressive when shared vars are used

Added by Constantin Asofiei about 11 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Constantin Asofiei
Target version:
FWD - Conversion Support for Server Features
Start date:
02/26/2013
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

ca_upd20130226f.zip (8.63 KB) Constantin Asofiei, 02/26/2013 07:02 PM

ca_upd20130227a.zip (8.63 KB) Constantin Asofiei, 02/27/2013 06:28 AM

History

#1 Updated by Constantin Asofiei about 11 years ago

unreachable code is removed and with it defined vars. following conversion fails:

return.
define variable l1 as logical.

procedure proc0:
   if l1 then run bar.p.
end.

#2 Updated by Constantin Asofiei about 11 years ago

I think the solution is to not remove vars/buffers/etc marked as unreachable if there are reachable nodes with a refid annotation for them. I'll take a look at it and let you know what I find.

#3 Updated by Constantin Asofiei about 11 years ago

  • File ca_upd20130226e.zip added

This code fixes this testcase, I will test the server file and regression conversion testing.

#4 Updated by Constantin Asofiei about 11 years ago

  • File deleted (ca_upd20130226e.zip)

#5 Updated by Constantin Asofiei about 11 years ago

renamed to not conflict...

#6 Updated by Constantin Asofiei about 11 years ago

I've checked converted sources, there is some resurrected dead-code in MAJIC that should not affect runtime; MAJIC did compile. I'll check tomorrow how I can fix this.

#7 Updated by Constantin Asofiei about 11 years ago

  • File ca_upd20130227a.zip added

My reachable processing was too aggressive, I'm putting this into conversion regression testing.

#8 Updated by Constantin Asofiei about 11 years ago

I'm reposting cause I had a left behind printfln.

#9 Updated by Constantin Asofiei about 11 years ago

  • File deleted (ca_upd20130227a.zip)

#10 Updated by Constantin Asofiei about 11 years ago

  • Status changed from WIP to Review
  • % Done changed from 0 to 100

This has passed conversion regression testing on MAJIC, no resurfaced dead-code.

Committed to bzr revision 10218.

#11 Updated by Greg Shah about 11 years ago

  • Status changed from Review to Closed

Everything looks good here, except the copyright dates in the new ruleset. You can check in a fix without any further testing since it is just a comment change.

#12 Updated by Constantin Asofiei about 11 years ago

Greg Shah wrote:

Everything looks good here, except the copyright dates in the new ruleset. You can check in a fix without any further testing since it is just a comment change.

The copyright date is fixed in revision 10219.

#13 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 4 to Conversion Support for Server Features

Also available in: Atom PDF