Project

General

Profile

Bug #2202

« Previous | 326 of 342 | Next »

ContextLocal should disallow calls which operate on its data during cleanup()

Added by Eric Faulhaber over 10 years ago. Updated over 10 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version:

History

#1 Updated by Eric Faulhaber over 10 years ago

At least in server mode, ContextLocal should not allow calls to its get() and set(T) methods during cleanup. This is because the associated security context already has been popped before this method is invoked. At that point, calls to get() will return null (regardless of whether there was valid data immediately prior) and calls to set(T) are meaningless.

This can be implemented by setting a cleaning flag (defaults to false) at the top of ContextLocal$Wrapper.cleanup(), and checking that flag in calls to get() and set(T). If true, a runtime exception (say, ContextLocalCleanupException) is thrown.

This approach will detect programming errors which allow these methods to be called during cleanup, which otherwise potentially would introduce subtle defects. This is similar to the "fast-fail" collections which throw ConcurrentModificationException when modified while being iterated.

TODO: determine whether other ContextLocal modes (beside server mode) require similar protection.

Also available in: Atom PDF