FWD » Core Development » User Interface

def button b0.
def frame f b0.
ENABLE ALL WITH FRAME f.
b0:label = "resize".

The above code sample causes error "**Unable to set SCREEN-VALUE. LITERAL widget does not fit in FRAME. (4054)" in P2J, but in 4GL works fine.

Hynek, I need your comments.

...
+----+
|<re>|
+----+
...
** New width for BUTTON b0 is too large to fit in frame. (4475)

Procedure complete. Press space bar to continue.
...

Indeed, the original description doesn't seem to be correct. Still there are differences between 4GL and P2J - 4GL gives the message "** New width for BUTTON b0 is too large to fit in frame. (4475)" vs. P2J resizes the frame to fit the new label.

Eugenie, I suggest you wait with this until I finish my in-progress changes. I am modifying some of the related widget fields and logic and we would likely get conflicts.

Hynek Cihlar wrote:

Indeed, the original description doesn't seem to be correct. Still there are differences between 4GL and P2J - 4GL gives the message "** New width for BUTTON b0 is too large to fit in frame. (4475)" vs. P2J resizes the frame to fit the new label.

Yes, it is exactly what I see in my tests too.

Eugenie, I suggest you wait with this until I finish my in-progress changes. I am modifying some of the related widget fields and logic and we would likely get conflicts.

OK. How much time do you expect it can take?

Eugenie Lyzenko wrote:

Eugenie, I suggest you wait with this until I finish my in-progress changes. I am modifying some of the related widget fields and logic and we would likely get conflicts.

OK. How much time do you expect it can take?

I expect to have it released Monday or Tuesday.

Eugenie, I'm bit delayed. I am expecting the work to be finished sometime at the end of the week.

This task can be worked on now.

Greg Shah wrote:

This task can be worked on now.

OK. Soon I will have the fix. Can I include it into update pending to be tested and related to prepackaged button images?

Yes, it is a good idea to include it in the #2545 update.

Code Review evl_upd20150429b.zip

Does the 4GL remove the & characters from the label before it calculates that the label is too big to fit? See GenericWidget.setLabel(String) which does the removal. That code is called after the ButtonWidget.setLabel(String) has already generated an error. I just want to make sure we are compatible.

Hynek: are you OK with the ButtonWidget.setLabel(String) code?

Code Review evl_upd20150429c.zip

I like your original idea of avoiding more type checking in GenericWidget.setLabel(), but we already have other references to ButtonWidget and ToggleBoxWidget there.

I guess your solution is OK for now. Eventually we should provide protected methods in GenericWidget that would allow sub-classes to override the default behavior and thus move the button/toggle-box specific logic into those classes.

Please add a TODO in that method to explain this so that we can "remember" it easily.

Code Review evl_upd20150429d.zip

It is good.

Hynek: any concerns?

GenericWidget.setLabel() is becoming a little overblown. It should be split into several parts - label validation, label value transformation (removal of '&' for example) and calculation. These parts could be abstracted and so the casting in the parent class avoided.

Greg Shah wrote:

Code Review evl_upd20150429d.zip

It is good.

Hynek: any concerns?

I think it is good, I didn't spot any issues in the drawing code. I would maybe inline LogicalTerminal.isButtonOrImage and LogicalTerminal.isButton - matter of personal taste.

OK, let's go with this as is for now.

Pause testing on this until Constantin's changes are checked in. Then merge and regression test.

Code Review evl_upd20150429e.zip

I like it!

The fix for this issue is included into update for task #2545 for commit and distribute, evl_upd20150503a.zip. Passed the runtime regression testing.