Project

General

Profile

Support #2453

remove unnecessary scope promotion

Added by Greg Shah over 9 years ago. Updated over 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
-
Start date:
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
case_num:
version:

History

#1 Updated by Greg Shah over 9 years ago

annotations/scope_promotion.rules promotes all variable references that are contained in a query substitution or which appear in a BY clause.

I believe that neither of these are necessary now that we have moved to compact mode. All vars are now emitted as either a containing class member (these are "promoted") or as a member of the containing inner class that represents a containing block for the code using the vars. By design, all vars are meant to be usable from more nested inner classes, so it seems that the verbose mode reasons for promotion in these two cases are no longer in force.

Getting rid of this will make the code cleaner, easier to read (the defs are closer to the references) and will eliminate some of the naming conflicts that cause us to disambiguate the promoted var names that conflict.

#2 Updated by Greg Shah over 7 years ago

  • Target version deleted (Code Improvements)

Also available in: Atom PDF