Project

General

Profile

Feature #2603

add screen template file name to check-screen-buffer failure message

Added by Greg Shah almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Igor Skornyakov
Start date:
07/03/2015
Due date:
% Done:

0%

billable:
No
vendor_id:
GCD
version:

ias_upd20150703-harness.zip (15.1 KB) Greg Shah, 07/03/2015 08:14 AM

Related issues

Related to User Interface - Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX Closed 03/06/2015

History

#1 Updated by Greg Shah almost 9 years ago

From Igor (note 176 in #2534):

I found useful to include the template name into the report in the case of mismatch. It helps a lot in the test results' analysis (at least for me). Do you think that it makes sense to include it in the main version of the harness?

#2 Updated by Greg Shah almost 9 years ago

Code Review ias_upd20150703-harness.zip

Yes, I think this is a useful feature. Please create a task branch (in the harness_repo/harness project). Unzip this update and commit it to the task branch.

Then make the following changes (and commit them to the task branch):

1. All files need history entries and copyright dates that are ranges with -2015.

2. ScreenRegion needs the fname member to have javadoc and the fname parameter for the constructor needs to be javadoc'd.

#3 Updated by Igor Skornyakov almost 9 years ago

Greg Shah wrote:> Yes, I think this is a useful feature. Please create a task branch (in the harness_repo/harness project). Unzip this update and commit it to the task branch.

Then make the following changes (and commit them to the task branch):

1. All files need history entries and copyright dates that are ranges with -2015.

2. ScreenRegion needs the fname member to have javadoc and the fname parameter for the constructor needs to be javadoc'd.

OK, thank you, I'm working in this now. I need to read the documentation about branches anyway.

#4 Updated by Igor Skornyakov almost 9 years ago

Created branch 2603a. Committed changes with comments.

#5 Updated by Greg Shah almost 9 years ago

Code Review Task Branch 2603a, Revision 7

I'm good with the changes. Have these latest changes been tested in a full regression testing run of MAJIC?

#6 Updated by Igor Skornyakov almost 9 years ago

Greg Shah wrote:

I'm good with the changes. Have these latest changes been tested in a full regression testing run of MAJIC?

Yes, they had. Actually a number of times.

#7 Updated by Greg Shah almost 9 years ago

OK, then go ahead with the merge/commit to trunk.

When you send out the notification email, make sure you explain to people that they should use cd ~/testing/ && run_regression.sh configure to obtain the latest harness code.

#8 Updated by Igor Skornyakov almost 9 years ago

Greg Shah wrote:

OK, then go ahead with the merge/commit to trunk.

When you send out the notification email, make sure you explain to people that they should use cd ~/testing/ && run_regression.sh configure to obtain the latest harness code.

I will do the branch merge for the first time and I prefer to do it with a "fresh head" tomorrow. Is it OK?

#9 Updated by Greg Shah almost 9 years ago

I prefer to do it with a "fresh head" tomorrow. Is it OK?

Sure.

#10 Updated by Igor Skornyakov almost 9 years ago

The task branch passed regression testing and was merged with the harness trunk and checked in as revision 7.

#11 Updated by Greg Shah almost 9 years ago

  • Status changed from WIP to Closed

Also available in: Atom PDF