Project

General

Profile

Bug #2726

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

frame title color is wrong

Added by Greg Shah over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

window_frame_title_colors.png (3.5 KB) Hynek Cihlar, 10/07/2015 01:59 PM

frame_title_text_color_20151009.jpg - Fix already in? (21.3 KB) Eugenie Lyzenko, 10/08/2015 05:24 PM

demo_widgets_frame_title_color_20151009.png (8.92 KB) Greg Shah, 10/09/2015 08:00 AM

demo_widgets.p_at_initial_startup_in_p2j_swing_20151009.png (7.42 KB) Greg Shah, 10/09/2015 11:30 AM

demo_widgets.p_at_initial_startup_in_progress_20151009.png (13.2 KB) Greg Shah, 10/09/2015 11:30 AM

demo_widgets.p_after_click_on_2nd_frame_in_p2j_swing_20151009.png (7.36 KB) Greg Shah, 10/09/2015 11:35 AM

demo_widgets.p_after_click_on_2nd_frame_in_progress_20151009.png (12.7 KB) Greg Shah, 10/09/2015 11:35 AM

demo_widgets.p_at_initial_startup_p2j_fixed_20151009.jpg - The fix result (62.9 KB) Eugenie Lyzenko, 10/09/2015 01:24 PM

History

#1 Updated by Greg Shah over 8 years ago

Any GUI testcase with a titled frame should exhibit this. For some screen captures that show the difference, see task 2715 note 7

#2 Updated by Greg Shah over 8 years ago

  • Assignee set to Eugenie Lyzenko

Please put your changes into task branch 1811r.

#3 Updated by Greg Shah over 8 years ago

Hynek did make some changes related to this in 1811r already, but they don't always resolve the issue.

#4 Updated by Hynek Cihlar over 8 years ago

Eugenie, frame title shares the colors with main window. So whatever you set in the Windows theme settings will end up in the frame as well. See the screenshot. It should be enough to make sure both titles share the same system colors.

#5 Updated by Eugenie Lyzenko over 8 years ago

Looks like now the frame title color is fixed(without any my changes). See the screen attached. May be we can close this issue?

#6 Updated by Greg Shah over 8 years ago

No, it is only fixed for some cases as I mentioned in note 3.

Try demo/demo_widgets.p:

#7 Updated by Greg Shah over 8 years ago

Consider these images:

These both show demo/demo_widgets.p at initial startup. In Progress the unfocused 2nd frame is drawn in the "inactive" background color but with white text.

#8 Updated by Greg Shah over 8 years ago

Now consider what happens when we single click on the 2nd frame:

The 2nd frame becomes focused in both cases and our drawing matches.

One problem is that the chcb combo-box still draws as if it is focused in the P2J case. We will work that in a separate task.

#9 Updated by Greg Shah over 8 years ago

The core issue here is to draw the frame background and frame title color properly when a frame is not focused.

#10 Updated by Eugenie Lyzenko over 8 years ago

The solution will be committed soon. The screenshot is attached. To be included in 1811r.

#11 Updated by Greg Shah over 8 years ago

  • Status changed from New to Closed

#12 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100

#13 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF