Project

General

Profile

Bug #2750

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

status area height should not be added to the overall window height

Added by Greg Shah over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

message_area_height_diff.jpg - Message area GUI issue (84.3 KB) Eugenie Lyzenko, 10/13/2015 11:14 AM

message_area_selection_4gl.jpg - Selected message area 4GL (71.4 KB) Eugenie Lyzenko, 10/13/2015 12:17 PM

message_area_selection_p2j_20151013.jpg - Selected message area P2J (64.4 KB) Eugenie Lyzenko, 10/13/2015 12:17 PM

message_area_selection_fix_p2j_20151013.jpg - P2J fix for message area (66.5 KB) Eugenie Lyzenko, 10/13/2015 01:30 PM

message_area_selection_p2j_20151014.jpg - P2J fix for message area scrollbar buttons (56 KB) Eugenie Lyzenko, 10/14/2015 11:20 AM

History

#1 Updated by Greg Shah over 8 years ago

See #2748-1

Use demo/demo_widgets.p to recreate. The main content pane in Progress is shorter by the size of the status area.

#2 Updated by Greg Shah over 8 years ago

  • Assignee set to Eugenie Lyzenko

#3 Updated by Eugenie Lyzenko over 8 years ago

In the recent 1811s code the issue looks differently. The only remaining problem is the message area height in P2J 2 pixels smaller than in 4GL as you can see in the attached picture. Can easily be fixed in MessageAreaGuiImpl.

#4 Updated by Greg Shah over 8 years ago

Constantin: could this 2 pixel difference be due to a font sizing issue?

#5 Updated by Constantin Asofiei over 8 years ago

Greg Shah wrote:

Constantin: could this 2 pixel difference be due to a font sizing issue?

Yes, I think this should use FontManager.getFontHeight, and not gf.font().fontHeight in MessageAreaGuiImpl.doLayout

Also, Eugenie, please check if the selected row in the MESSAGE-AREA looks the same in P2J as in 4GL.

#6 Updated by Eugenie Lyzenko over 8 years ago

Yes, I think this should use FontManager.getFontHeight, and not gf.font().fontHeight in MessageAreaGuiImpl.doLayout

The both cases produce same wrong results. Need to just increase extra pixels value(as on the attached pictures).

Also, Eugenie, please check if the selected row in the MESSAGE-AREA looks the same in P2J as in 4GL.

No, the selected row looks differently. The pictures show the 4GL use the same color for background as for active window/frame title. In P2J the color is lighter. Also in P2J there is a vertical line on the left that is not covered by selection background.

#7 Updated by Eugenie Lyzenko over 8 years ago

The fix 1811s rev 10957 for message area includes:
1. Selected item background color and fill area location/size.
2. Item text X position.

For comparison the 4GL and P2J pictures attached.

#8 Updated by Greg Shah over 8 years ago

These changes look good. Before we close this task, please look into the differences in how we draw the scrollbar buttons for the message area, versus the 4GL.

#9 Updated by Eugenie Lyzenko over 8 years ago

Greg Shah wrote:

These changes look good. Before we close this task, please look into the differences in how we draw the scrollbar buttons for the message area, versus the 4GL.

Do you mean the scaled images from SVG sources size/position?

#10 Updated by Greg Shah over 8 years ago

Do you mean the scaled images from SVG sources size/position?

Yes.

#11 Updated by Eugenie Lyzenko over 8 years ago

Fix for message are buttons has been committed. The final screen sample is attached.

#12 Updated by Greg Shah over 8 years ago

  • Status changed from New to Closed

Task branch 1811s revision 10963 fixes the last part of this issue.

#13 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100

#14 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF