Project

General

Profile

Bug #2831

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

Pressing ENTER key on the combo box breaks the window layout.

Added by Sergey Ivanovskiy over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

SelectWinPrintArrowsEnterKeys.png (32.8 KB) Sergey Ivanovskiy, 11/06/2015 09:50 AM

evl_upd20151118c.zip - Fix for 2831 and 2834 (27.9 KB) Eugenie Lyzenko, 11/18/2015 04:25 PM

History

#1 Updated by Sergey Ivanovskiy over 8 years ago

To reproduce this bug it needs to run the following test case ./demo/demo_widgets.p (com.goldencode.testcases.demo.DemoWidgets.execute) and connect to the server by the web client.
1) Log into the web client.
2) Select the demo window and press ENTER key.
It breaks the demo window layout.

#2 Updated by Greg Shah over 8 years ago

  • Assignee set to Eugenie Lyzenko
  • Target version set to Milestone 12
  • Start date deleted (11/06/2015)

#3 Updated by Eugenie Lyzenko over 8 years ago

Confirmed as issue for Swing client too.

#4 Updated by Eugenie Lyzenko over 8 years ago

The root cause is the improper handling for ENTER key in GUI mode for combo-box. Even if the SESSION:DATA-ENTRY-RETURN is TRUE it must be ignored. So the combo-box just do nothing in GUI for ENTER key. The solution is to override the getDataEntryReturn() for GUI mode returning always false. The cumulative fix(with 2834 issue resolution include) has been attached for review.

Only GUI code is involved in both fixes.

#5 Updated by Greg Shah over 8 years ago

Code Review evl_upd20151118c.zip

I am fine with the change to ComboBoxGuiImpl.

#6 Updated by Greg Shah over 8 years ago

Please check in the ComboBoxGuiImpl change from evl_upd20151118c.zip. We will wait on the ScrollableSelectionListGuiImpl.java change until we hear from Constantin.

#7 Updated by Eugenie Lyzenko over 8 years ago

Greg Shah wrote:

Please check in the ComboBoxGuiImpl change from evl_upd20151118c.zip. We will wait on the ScrollableSelectionListGuiImpl.java change until we hear from Constantin.

Committed to 2677a as revision 11067. The file ui/client/ComboBox.java committed to as requirement for this fix. ScrollableSelectionListGuiImpl.java is untouched.

#8 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

#9 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF