Project

General

Profile

Bug #2836

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

wrong number of inner lines in COMBO-BOX

Added by Hynek Cihlar over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Eugenie Lyzenko
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

evl_upd20151124a.zip - Fix for inner lines wrong calculation (5.43 KB) Eugenie Lyzenko, 11/24/2015 01:30 PM

History

#1 Updated by Hynek Cihlar over 8 years ago

The following program doesn't show the correct number of entries in combo-box drop-down.

DEF VAR cb AS CHAR VIEW-AS COMBO-BOX INNER-LINES 3 LIST-ITEMS 
   "item1", "item2", "item3", "item4".

FORM cb WITH FRAME f SIDE-LABELS.
ENABLE ALL with frame f.

/* trigger push to the client, this is the key part */
cb:LABEL = "xxx".

WAIT-FOR GO OF FRAME f.

#2 Updated by Greg Shah over 8 years ago

Is this in GUI, ChUI or both?

This issue is in the trunk?

#3 Updated by Hynek Cihlar over 8 years ago

Greg Shah wrote:

Is this in GUI, ChUI or both?

Both.

This issue is in the trunk?

Yes.

#4 Updated by Greg Shah over 8 years ago

  • Target version set to Milestone 12
  • Start date deleted (11/09/2015)
  • Subject changed from Wrong number of inner lines in COMBO-BOX to wrong number of inner lines in COMBO-BOX
  • Assignee set to Eugenie Lyzenko

#5 Updated by Eugenie Lyzenko over 8 years ago

This is the fix for issue. ComboBoxWidget.finishSetup() recalculates the INNER-LINES value after explicitly set. And this adjustment looks strange at least. Moreover there is a minimum of 3 lines for combo-box. Tested in both GUI and ChUI.

Can I commit this update to 2677b?

#6 Updated by Greg Shah over 8 years ago

Code Review evl_upd20151124a.zip

I'm fine with the change. You can check it into branch 2677b.

#7 Updated by Eugenie Lyzenko over 8 years ago

Greg Shah wrote:

Code Review evl_upd20151124a.zip

I'm fine with the change. You can check it into branch 2677b.

The fix committed in 2677b as revision 10957.

#8 Updated by Greg Shah over 8 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

#9 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF