FWD » Core Development » User Interface

This only happens in the web client?

Yes, this only happens in Web GUI.

Hynek, please log here what is a target program to reproduce this bug. For the JS client we can't distinguish modal windows from any other child window. A task icon is created for a window and is displayed if its window becomes visible.

Sergey Ivanovskiy wrote:

Hynek, please log here what is a target program to reproduce this bug. For the JS client we can't distinguish modal windows from any other child window. A task icon is created for a window and is displayed if its window becomes visible.

Try simpler_alert_box.p for example. I guess we will have to extend the window info passed to JS client so it can identify modal windows.

Try simpler_alert_box.p for example. I guess we will have to extend the window info passed to JS client so it can identify modal windows.

I will try it but it needs global changes for GuiOutputManager to add void realizeModalWindow(int ownerId, int windowId, String windowTitle) and for GuiDriver to add void registerModalWindow(ownerId, windowId, windowTitle) because of this code from ModalWindow.realize()

      screen().realizeChildWindow(ownerId, id.asInt(), title()); // we can't identify that this window is modal.

      realized = true;

      WindowManager.addWindow(this); // only after this code we can identify modal windows inside the web driver

No, there is the other way to use GuiDriver.setWindowVisible(true), because at that point we can identify the window is a modal one using WindowManager.findWindow(int windowId).

Sergey Ivanovskiy wrote:

Try simpler_alert_box.p for example. I guess we will have to extend the window info passed to JS client so it can identify modal windows.

I will try it but it needs global changes for GuiOutputManager to add void realizeModalWindow(int ownerId, int windowId, String windowTitle) and for GuiDriver to add void registerModalWindow(ownerId, windowId, windowTitle) because of this code from ModalWindow.realize()
[...]

realizeChildWindow() returns a child top-level window. Although there isn't a formal javadoc that would define what is a child-window (I will add it), you can assume that a child window is never shown on the "task bar". So the real key is not modality but the fact whether a window is a main or child window. Note that currently any modal window is also a child window, but not in reverse - child window doesn't have to be necessary modal.

Hynek Cihlar wrote:

realizeChildWindow() returns a child top-level window. Although there isn't a formal javadoc that would define what is a child-window (I will add it), you can assume that a child window is never shown on the "task bar". So the real key is not modality but the fact whether a window is a main or child window. Note that currently any modal window is also a child window, but not in reverse - child window doesn't have to be necessary modal.

You are right, it is a more simple solution and it doesn't require to change the web data protocol, since GuiDriver.registerChildWindow(int ownerId, int windowId, String windowTitle) is used only by ModalWindow.

Code Review Task Branch 1811t Revision 10961

I'm fine with the changes.

Constantin: please review.

Greg Shah wrote:

Code Review Task Branch 1811t Revision 10961

I'm fine with the changes.

Constantin: please review.

The changes look OK.