Project

General

Profile

Bug #2953

Bug #2677: fix drawing and functional differences between P2J GUI and 4GL GUI

WinKeyboardReader should clear the key modifiers when P2J window deactivated by keyboard (Alt+Tab)

Added by Hynek Cihlar over 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Sergey Ivanovskiy
Target version:
FWD - GUI Support for a Complex ADM2 App
Start date:
01/12/2016
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

10984.txt Magnifier (1.71 KB) Sergey Ivanovskiy, 01/14/2016 01:39 PM

History

#1 Updated by Hynek Cihlar over 8 years ago

This issue was identified in #2875 note 31. I am copying the notes content here.

I am having a bit of a problem with WinKeyboardReader and the way it processes modifier keys. The case is as follows.

P2J top-level window is activated, Alt+Tab is pressed to activate a non-P2J window, a P2J window is activated again and a key is pressed. The pressed key event is merged with an Alt modifier by WinKeyboardReader. When Alt+Tab was pressed to deactivate the P2J window, Alt modifier was stored by WinKeyboardReader and (since there was no key-released event) appplied to the subsequently pressed key.

#2 Updated by Greg Shah over 8 years ago

  • Project changed from Liberty to User Interface
  • Parent task deleted (#2811)

#3 Updated by Greg Shah over 8 years ago

  • Parent task set to #2677

#4 Updated by Greg Shah over 8 years ago

  • Target version set to Milestone 12
  • Assignee set to Sergey Ivanovskiy

#5 Updated by Sergey Ivanovskiy over 8 years ago

Committed revision 10984 clears the keyboard internal state if a deactivation event happens.

#6 Updated by Greg Shah over 8 years ago

Code Review Task Branch 1811t Revision 10984

I'm fine with the change.

Am I correct to assume that we don't need the same feature for the web client?

#7 Updated by Sergey Ivanovskiy over 8 years ago

Code Review Task Branch 1811t Revision 10984

I'm fine with the change.

Am I correct to assume that we don't need the same feature for the web client?

Correct. The last event is merged with new event but in the case Alt + TAB, the OS default action is invoked.

#8 Updated by Greg Shah over 8 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

#9 Updated by Greg Shah over 8 years ago

From Sergey:

Committed revision 10984 is fixed the issue, for the web Alt + Tab can be handled properly because the browser doesn't generate the Tab "keydown" event.

#10 Updated by Greg Shah over 7 years ago

  • Target version changed from Milestone 12 to GUI Support for a Complex ADM2 App

Also available in: Atom PDF