Support #3005
OO processing cleanup items
100%
History
#1 Updated by Greg Shah over 8 years ago
Some customer code was found that passed temp-tables as a parameter to OO methods. This is a problem during the first pass parsing of OO classes since that pass is just trying to identify some OO elements and is not maintaining the schema namespaces. progress.g
was changed to bypass parameter processing in method_stmt
when executing as a first pass.
Another issue was found were a widget was found instead of a variable that was of a CLASS type. progress.g
was changed to avoid adding a widget for variables that are objects, otherwise the object invocation parsing can fail (because it thinks it is seeing a widget instead of an object instance).
SymbolResolver
was modified to lookup oo-skeleton-path
when it is being initialized for normal parsing. This allows users to override the path for the skeleton classes. This should not get invoked when used at runtime for dynamic database.
The ConversionDriver
was modified to handle file lists better. We now trim leading/trailing whitespace and ignore blank lines. Previously, an unintentional space would drop the file on that line from conversion processing.
#2 Updated by Greg Shah over 8 years ago
Created task branch 3005a from trunk revision 10973.
Hand testing shows the changes work. Checked in to 3005a as revision 10974.
#3 Updated by Greg Shah over 8 years ago
Conversion regression testing has passed, it causes no changes to the converted output.
Eric: the only possible runtime impact is to dynamic queries, which use the SymbolResolver
. My changes are designed to not be present in that case since they are only triggered via the AstGenerator
static initializer. Nevertheless, if it is easy for you to confirm my belief, I will wait to check in the code. Otherwise I think this is safe to check in.
#4 Updated by Greg Shah over 8 years ago
Merged to trunk as revision 10975. Task branch 3005a was archived.
#5 Updated by Greg Shah over 8 years ago
- Status changed from WIP to Closed
- % Done changed from 0 to 100