FWD » Core Development » User Interface

Implement runtime support for the browse attributes COLUMN-MOVABLE, COLUMN-RESIZABLE, CREATE-ON-ADD, MIN-HEIGHT-CHARS and the browse MOVE-COLUMN method.

These were supposed to have been implemented in 2564, but they were missed.

NO-SCROLLBAR-VERTICAL must also be implemented in this task.

CREATE-ON-ADD was moved to #2630

1. Bottom scrollbar not drawn and invalid highlighting of current row - fixed ScrollPaneGuiImpl.calcInitialViewportSize.
2. Graphical artefacts on label and missing separator of the last locked column - IIRC earlier effective clipping rectangle actually was clipping width + 1, clipping height + 1, now it is clipping width, clipping height, updated clipping rectangles.
3. Missing background after the the last scrollable column - seems that earlier ScrollPane was increasing scrollable widget size if it was scrolled beyond the right/bottom edge. Now it's not, so I made custom ScrollPane.

All regressions are fixed, if you need the update, let me know.

Rebased task branch 3038a from P2J trunk revision 11005.

Code Review Task Branch 3038a Revision 110011

This is really good. I see that ClientBrowseModel needs a copyright date update, but otherwise it is ready for testing (go ahead with MAJIC regression testing).

Have you run the standalone GUI testing?

For the GUI testing, only test code with browse and some common widgets that are affected by the scroll changes.

Browse testcases are ok, and I didn't find any scrolling issues with other testcases.
I found one thing that is missing for browse resizing - FIT-LAST-COLUMN support. When it is ON, and a column is resized, 4GL shrinks the last column for the same distance to keep it fit. I'll fix it.

I'd like 3038a to be next to merge to trunk. It should be rebased to trunk 11007 as well. When do you expect that the FIT-LAST-COLUMN change will be done so this can go into testing?

I've found few more issues related to resizing columns in a browse which has total columns width smaller that the viewport width, so it will not be earlier than this evening.

Rebased task branch 3038a from P2J trunk revision 11010.

Please review task branch 3038a revision 11019. Previous revision you've reviewed was 11016.
The last changes fix edge cases for resize and FIT-LAST-COLUMN for the case if total columns width is larger than viewport width (4GL forces last column to fit viewport width even in this case).

Code Review Task Branch 3038a Revision 11019

The changes are good. I especially like that you have factored the code for better reuse.

Has this revision already passed GUI testing?

Please put this into ChUI regression testing.

Rebased task branch 3038a from P2J trunk revision 11012.

Has this revision already passed GUI testing?

Standalone testcases? Yes.

Great! How is ChUI testing coming along?

1811u is close to passing testing and will probably be checked in first. If there are no real conflicts, then I will not expect you to retest.

One test and ctrl-c failed. I don't think that is an actual problem, the next round is running.

Regression testing passed.

Great! 1811u has also passed testing. It is being merged to trunk right now. Please rebase when you see the notification. Please just do a simple manual test to confirm that the merge worked properly. Then you can merge to trunk without re-running regression testing. There are some changes in common files, but I don't think there are any real conflicts.

Please rebase, check the result and merge to trunk.

3038a was merged into the trunk as bzr revision 11015.