FWD » Core Development » User Interface

In ask-gui.p, when run in the current trunk, one can see a problem where the ENTER key does not generate a GO event. F2 can be used to generate the GO but the ENTER is always ignored.

Similarly ENTER does not confirm selected value in COMBO-BOX drop-down.

It took me a while to figure out the following problem.

When an overlay window was closed (hidden and destroyed), Swing would not send focus-lost for the overlay window and focus-gained for the owner. This didn't put input focus into the main window and so the app seemed to freeze (until mouse clicked into the main window).

It turned out to be caused by the order of window-hide and window-activate requests. The window-activate for the owner must be issued before the overlay window is made hidden, the vice versa doesn't work. I made a comment in the code for future reference.

Please review task branch 3061a revision 11008, rebased against trunk 11001.

The revision resolves both issues mentioned in note 1. It also adds some related fixes. GUI regression tests passed, ChUI in progress.

The last ChUI regression test run for 3061a finished with 10 suspected false negatives. I am restarting the tests.

Code Review Task Branch 3061a Revision 11008

I'm fine with the changes. If correct, they simplify our approach which is great.

Constantin/Sergey: please review.

Igor: please review the FillIn change.

Task branch 3061a revision 11008 passed GUI and ChUI regression tests.

Please rebase and then let's discuss if any further testing is needed.

Greg Shah wrote:

Igor: please review the FillIn change.

The change looks OK. In fact it is a fix of my bug.

While rebasing against trunk 11003 there are nontrivial conflicts, regression retest will be needed.

Greg Shah wrote:

Code Review Task Branch 3061a Revision 11008
...
Constantin...: please review.

I'm OK with the changes.

Rebased 3061a against trunk 11003, the branch is now at revision 11011. The revision has passef GUI regression tests, ChUI regression in progress.

3061a revision 11011 passed regression testing and is ready to be merged to trunk.

Sergey: please review.

Hynek: If Sergey is OK, please merge to trunk.

Hynek, I tested ./ask-gui.p with the Swing client for 3061a branch 11011. Rebuild the project several times and checked the configuration. It seems that ENTER doesn't work only if F2 is pressed. May be you don't commit something? And for my environment the client window appears inactive and continues to be inactive after minimizing and restoring and pressing keys in the program input field.

It was my mistake forgot the p2j link.

Sergey Ivanovskiy wrote:

And for my environment the client window appears inactive and continues to be inactive after minimizing and restoring and pressing keys in the program input field.

As for the window activation issues, these are about to be resolved by #2823.

Fixed configuration and tested ask-gui.p. The code changes is ok for me.

3061a merged to trunk revision 11004 and archived.