FWD » Core Development » Conversion Tools

It seems like we could change SharedVariableManager to call TransactionManager.register[Global]() when a new [global] shared variable is created and drop those register calls from the business logic.

Eric has found a case where we are registering duplicate references in the global undoables list. If you RUN an external procedure that has a def new global shared var and you do that RUN in a loop, then the same global shared variable will be added to the global scope of the undoables list multiple times (once for every loop iteration). He is putting some protection logic into the TM to not add the reference if it already exists. But it seems like the SVM could hide the registration completely AND it always knows if something is created (then we register) versus imported (no registration).

The only issue I see is that it will be called during the constructor for an external procedure, before the external proc scope opens. So we would have to implement a deferred registration. Other than that, I don't see much of a problem.

Constantin: Am I missing anything here?

Greg, you are correct that SVM should do the register, and not emit explicit TM.register calls. And yes, we need to do this in a deferred registration; also, the GLOBAL vars need to be added in a deferred way, too, otherwise we will leak global vars, if the instantiation of the external procedure fails for some other reason (i.e. another shared var error after a global was already registered).

Otherwise, I don't see anything else of concern.