FWD » Core Development » User Interface

If you manually put focus into a selection list, does it accept keyboard input?

If focus manually is pointed into the selection list, keyboard input is possible.

Please work on the initial focus issue. The dialog is implemented in com/goldencode/p2j/ui/client/gui/FontChooserGuiImpl.java and it is created in ThinClient.chooseFont().

The font chooser is implemented in the class FontChooserGuiImpl, field ComboBoxGuiImpl fontFaceCbx. But ComboBoxGuiImpl is not a Swing class, and we cannot force it to grab the focus. It is unclear where to find creation of the corresponding Swing component, and how to make it to request the focus.

Alexei Kaigorodov wrote:

The font chooser is implemented in the class FontChooserGuiImpl, field ComboBoxGuiImpl fontFaceCbx. But ComboBoxGuiImpl is not a Swing class, and we cannot force it to grab the focus. It is unclear where to find creation of the corresponding Swing component, and how to make it to request the focus.

As you already figured out, the legacy widgets (i.e. subclasses of AbstractWidget) don't have direct mapping to the Swing components. We handle all the drawing and UI flow ourselves. What Swing (or Web browser in case of Web client) provides to us is only a window component and its graphic context.

For focus handling see AbstractContainer.setFocus and how the method is used. Also see UiUtils.getCurrentFocus() (and its overloads), this method is often used during dispatching of input events.

Alexei Kaigorodov wrote:

Fixed in branch secure/code/p2j_repo/p2j/active/3631a, revision 11312.
Diff file attached.
Please review.

Code review 3631a 11312.

The change is good. Only a small modification. Instead of requestFocus() on the combo box widget, call setFocus() on the FontChooserGuiImpl class and pass in the combo box widget. We want to avoid requestFocus() in this case as it triggers legacy focus events.

setFocus(fontFaceCbx); has no visible effect - focus is not set to the combobox.

Alexei Kaigorodov wrote:

setFocus(fontFaceCbx); has no visible effect - focus is not set to the combobox.

I didn't give you a complete answer, sorry. You have to call setFocus() on the container to which the combo box belongs. So not directly to the frame, but to its "content" container. getContentPane().setFocus(fontFaceCbx); will resolve the issue.

Hynek Cihlar wrote:

I didn't give you a complete answer, sorry. You have to call setFocus() on the container to which the combo box belongs. So not directly to the frame, but to its "content" container. getContentPane().setFocus(fontFaceCbx); will resolve the issue.

Done. Tested. Commited to secure/code/p2j_repo/p2j/active/3631a.

Please review.

Code review 3631a revision 11311.

The code changes are OK. The changed file is missing history entry.

Description added. Commited to secure/code/p2j_repo/p2j/active/3631a rev 11314

Alexei Kaigorodov wrote:

Description added. Commited to secure/code/p2j_repo/p2j/active/3631a rev 11314

Also please update the Copyright year.

Updated.

Code review 3631a. The changes are good, no regression testing is required.

I made a small edit to remove the reference to OE (it is a trademark) and instead I used the more generic "4GL".

Please go ahead and merge 3631a revision 11316 (this is with my changes) into the trunk. Follow the instructions (in our Source Management document) exactly. If you have any questions, do not move ahead until we've discussed them. If you understand the instructions, then you can go ahead.

I made a local branch which has revision 11311 (the same as trunk) and 5 small commits after that.
then I made bzr merge to get the changes from my branch back into the source repo (as it is said in the Source_Code_Management document, chapter "How Branching Works", point 10). But instead of expected effect "11. the resulting change will go back into the trunk as a single revision, even if you had 50 branch-specific commits", the reply was:
"Nothing to do."
what am I doing wrong?

Alexei Kaigorodov wrote:

I made a local branch which has revision 11311 (the same as trunk) and 5 small commits after that.
then I made bzr merge to get the changes from my branch back into the source repo (as it is said in the Source_Code_Management document, chapter "How Branching Works", point 10). But instead of expected effect "11. the resulting change will go back into the trunk as a single revision, even if you had 50 branch-specific commits", the reply was:
"Nothing to do."
what am I doing wrong?

Are you trying to merge the task branch in trunk? If so, follow Merge Back and Commit to the Trunk.

3631a was merged to trunk rev 11312 and was archived.