Project

General

Profile

Bug #4437

copy, paste and cut functionality don't work as expected

Added by Sergey Ivanovskiy over 4 years ago. Updated over 4 years ago.

Status:
Test
Priority:
Normal
Assignee:
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:

copy_put_editors.p Magnifier (539 Bytes) Sergey Ivanovskiy, 12/05/2019 06:40 AM


Related issues

Related to User Interface - Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG GET-FILE Closed

History

#1 Updated by Sergey Ivanovskiy over 4 years ago

This simple test case worked properly when this functionality was implemented but not now. It is a regression!

#2 Updated by Sergey Ivanovskiy over 4 years ago

The implemented logic was quit delicate so the web client thread, the server thread and the java script client were not blocked.

#3 Updated by Greg Shah over 4 years ago

  • Subject changed from Copy, paste and cut functionality don't work as expected to copy, paste and cut functionality don't work as expected

Is this a regression in 3809e or can this be seen in trunk?

#4 Updated by Sergey Ivanovskiy over 4 years ago

It is a regression in 3809e. This simple test case works with the trunc version.

#5 Updated by Greg Shah over 4 years ago

Please check if the regression is present in 3809e rev 11390. I wonder if the regression is related to rev 11391 (SYSTEM-DIALOG GET-FILE with AT-WEB-BROWSER option).

#6 Updated by Sergey Ivanovskiy over 4 years ago

It seems that rev 11390 (3809e) with rev 11400, web server patch, works with this test, but the rev 11400 and higher don't work. It looks strange because rev. 11391 shouldn't affect this functionality.

#7 Updated by Greg Shah over 4 years ago

I don't see how rev 11400 causes this issue. Did you test rev 11391?

#8 Updated by Sergey Ivanovskiy over 4 years ago

Greg Shah wrote:

I don't see how rev 11400 causes this issue. Did you test rev 11391?

The rev 11400 fixed the web server, without this patch it needs to set up the port number manually in the directory.xml. I will test it later from rev 11392 up to 11399. The first stable rev after 11391 is 11392.

#9 Updated by Sergey Ivanovskiy over 4 years ago

Sergey Ivanovskiy wrote:

I checked that rev 11400 (3809e) added this issue. With rev 11399 (3809e) this issue is not reproduced.

Sorry don't mind I missed the version number when it was checked.

#10 Updated by Sergey Ivanovskiy over 4 years ago

The results of my check:
0) with rev 11390 copy, paste and cut works properly
1) rev 11391 can't be compiled
2) rev 11392 - 11397 the web client rejects the jscript web connection
3) rev 11398 the web client can be connected and copy, paste and cut is broken.

#11 Updated by Sergey Ivanovskiy over 4 years ago

  • Related to Feature #4113: enable upload of files from the browser (in the web clients) using SYSTEM-DIALOG GET-FILE added

#12 Updated by Hynek Cihlar over 4 years ago

Sergey, since it seems to be linked to my changes, do you want me to look at it?

#13 Updated by Sergey Ivanovskiy over 4 years ago

Hynek Cihlar wrote:

Sergey, since it seems to be linked to my changes, do you want me to look at it?

I am not sure that its root cause is from your changes. There are another changes between 11390 and 11398 (3809e). There exists a simple sequence diagram for copy/paste/cut somewhere in Redmine that can help to check what changes cause this issue. I commented some jscript code and checked manually that the last jscript client changes shouldn't cause this issue. May be my check was incorrect.

#14 Updated by Sergey Ivanovskiy over 4 years ago

#3080 issue has this attached file CopyUseCase.pdf that explains the correct workflow for COPY/CUT.

#15 Updated by Sergey Ivanovskiy over 4 years ago

Now the web client is locked if we are using editor popup menu for COPY and PASTE. If we use keyboard, then nothing happens but the text can be moved to the system clipboard and can be sent to the web client side.

Greg, should I work on this task or delegate it to Hynek?

#16 Updated by Greg Shah over 4 years ago

Hynek, please do take a look.

#17 Updated by Hynek Cihlar over 4 years ago

  • Status changed from New to WIP
  • Assignee set to Hynek Cihlar

#18 Updated by Greg Shah over 4 years ago

  • Status changed from WIP to Test
  • % Done changed from 0 to 100

Resolved in 3809e rev 11444.

Also available in: Atom PDF