FWD » Core Development » Base Language

To follow-up, the conversion issue is fixed indeed but now we have an issue with assignMulti when indeterminate array variables are used. This fails mainly because the indeterminate array is not seen as 'dynamic' and then FWD is throwing an error stating the size of the two arrays doesn't match.

I've tried to fix that by adding an ArrayAssigner.registerDynamicArray on TypeFactory.objectExtent which does fix that error but then if the variable is defined in procedure's main block doing that registration fails with NPE because these seems to be no scope active just yet.

Tried to make a few samples in oo/quirks/indeterminate_extent, only tried a couple of cases for now and the conversion seems to be different for 'global' variable compared to a local one in test_object_extent_method.p. Without registration of dynamic array both assignMulti fails, adding registration when the object extent is instantiated in TypeFactory the test will crash with NPE when global variable is initialized. This is only when we ran that code as a startup procedure, if we use a wrapper that in turns call RUN on it the the NPE is gone - there is already a valid `work area` scope.

The code generated for static property defined as object extent seems to be wrong as well - ObjectExtentGlobal.cls is not compiling in Java:

@LegacySignature(type = Type.VARIABLE, name = "goExt")
   private static ContextLocal<object<? extends com.goldencode.p2j.oo.lang._BaseObject_>[]> goExt = new ContextLocal<object<? extends com.goldencode.p2j.oo.lang._BaseObject_>[]>()
   {
      protected object<? extends com.goldencode.p2j.oo.lang._BaseObject_>[] initialValue()
      {
         return UndoableFactory.objectExtent(com.goldencode.p2j.oo.lang._BaseObject_.class);
      }
   };

...

goExt = ArrayAssigner.resize(goExt.get(), new integer());
goExt = ArrayAssigner.resize(goExt.get(), num);

The conversion issue for ObjectExtentGlobal is already fixed.

As for the dynamic array issues - the root cause was the fact that the Java reference for the parameter is changed by resize, and this reference must be updated in the OutputExtentParameter instance (as this needs to be set as an argument at the setVariable call, to replace the caller's reference).

Greg Shah wrote:

Please add javadoc to ArrayAssigner.register(BaseDataType[] array) and ArrayAssigner.registerDynamicArray(BaseDataType[] array) to make it clear the default value for pending. This is especially important since the default is different between these.

Done in 3821c rev 12087.

Code Review Task Branch 3821c Revision 12087

The changes are good.