Bug #4827
OO Conversion issue with method resolve (erasure)
100%
Related issues
History
#1 Updated by Marian Edu over 3 years ago
- Related to Feature #4384: Builtin OO Implementation added
#2 Updated by Greg Shah over 3 years ago
- Description updated (diff)
- Start date deleted (
07/30/2020)
#3 Updated by Greg Shah over 3 years ago
From Marian:
We have quite a number of errors in conversion of our 'discovery' stubs that have to do with how the naming is resolved for methods overrides. I was able to isolate that in a simple test, it looks like the order of methods is important and it looks like this happens when the class that implements an interface does not have the same order like the one in the interface. Test cases in
oo/quirks/erasure
folder.
#4 Updated by Greg Shah over 3 years ago
I think this is part of my work on #4350.
#5 Updated by Greg Shah over 3 years ago
- Assignee set to Greg Shah
#6 Updated by Marian Edu over 3 years ago
Some more tests that fails to convert correctly:
oo/openedge/net/http/cookie_collection/test_method_contains_object.p
oo/openedge/net/http/cookie_collection/test_method_to_cookie_array.p
While on the second one picking the right method to call (add
instead of add_1
) could be more difficult since no intermediate variable is used for input parameter but directly instantiate the String
on the first test the variable used as input is a P.L.O but still the conversion is picking the contains_1
method (with Cookie
) over the right one contains
(with P.L.O as input).
For now we're just fixing those tests by hand to check functionality but just thought to mention it.
#7 Updated by Marian Edu about 3 years ago
Greg, just tried that on 4384h and the conversion on those erasure quirks tests seems to work now, if I find anything new will report back.
Thanks
#8 Updated by Greg Shah about 3 years ago
- % Done changed from 0 to 100
- Status changed from New to Closed