Bug #4842
com-handle of CONTROL-FRAME validity
Start date:
Due date:
% Done:
100%
billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
History
#1 Updated by Vladimir Tsichevski almost 4 years ago
In OE the com-handle
of CONTROL-FRAME
is valid just after the CONTROL-FRAME
is created. In FWD, this com-handle
is valid only after the LoadControls
was successfully called for it, which is obviously wrong: you cannot successfully call anything for an invalid handle.
Example:
DEFINE VARIABLE CtrlFrame AS WIDGET-HANDLE NO-UNDO. DEFINE VARIABLE chCtrlFrame AS COMPONENT-HANDLE NO-UNDO. DEF FRAME default-frame. CREATE CONTROL-FRAME CtrlFrame ASSIGN FRAME = FRAME DEFAULT-FRAME:HANDLE. chCtrlFrame = CtrlFrame:COM-HANDLE. MESSAGE chCtrlFrame valid-handle(chCtrlFrame).
OE prints "yes", while FWD prints "no".
So, probably, the solution is: the call to ControlFrameComObjectImpl.valid()
should always return true
.
#3 Updated by Vladimir Tsichevski almost 4 years ago
- Status changed from New to WIP
#4 Updated by Vladimir Tsichevski almost 4 years ago
- Status changed from WIP to Review
Fixed in 3821c, rev. 11487.
#5 Updated by Greg Shah almost 4 years ago
Vladimir Tsichevski wrote:
Fixed in 3821c, rev. 11487.
The change seems OK.
Hynek: Please review.
#6 Updated by Hynek Cihlar almost 4 years ago
Code review 3821c revision 11487. The changes seem fine.
#7 Updated by Greg Shah almost 4 years ago
- % Done changed from 0 to 100
- Status changed from Review to Closed
- Start date deleted (
08/05/2020)