FWD » Core Development » Base Language

• We should be able to record (in an annotation) whether the converted class was a CLASS, INTERFACE or ENUM in the 4GL. I'm not sure if LegacyResource is the right place, but that should be recorded somewhere. It can be inferred by Java refection but that is messy.
• The LegacySignature annotation is missing the method's return type. Recall that type is actually an InternalEntry.Type instance which defines what kind of internal entry is being implemented by this Java method (procedure, OO 4GL method, property getter...). Although we can record the extent and the OO qualified name, we can't actually record the original return type. Again, we can "reverse" the Java return type via reflection and make some assumptions, but this is messy.

Both cases seem like information we should record at conversion time. I'm writing code to dump all this right now, so it is top of mind for me. It is not urgent since I have written the messy reflection approach to figuring out each of the above items. But I don't want that to be our long term approach.

Regarding the return type for function and OO methods - my only problem is that there are ~3000 hand-written classes in p2j.oo package which would need to be updated. There may be a way to automate this.

3821c rev 12042 to 12044 fixes the 'extent', 'qualified' and adds 'returns' annotation to all legacy p2j.oo methods. Also, fixes conversion rules to emit these for all Java methods. What I did not address are legacy variable and property signature.

Also, there is a tool to sanitize automatically the method signature for p2j.oo classes - see #4965-13 for more details.