Project

General

Profile

Bug #6413

batch copy can be nested if there is a before-table record which needs to be populated in RecordBuffer$Handler.invoke

Added by Constantin Asofiei about 2 years ago. Updated about 2 years ago.

Status:
Test
Priority:
Normal
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:

History

#2 Updated by Constantin Asofiei about 2 years ago

Ovidiu, nested batch can happen in 'internal mode', if there is a before-table record which needs to be created when a field is assigned in a ASSIGN batch; without this patch, FWD abends.

### Eclipse Workspace Patch 1.0
#P p2j6129a
Index: src/com/goldencode/p2j/persist/BufferManager.java
===================================================================
--- src/com/goldencode/p2j/persist/BufferManager.java    (revision 3621)
+++ src/com/goldencode/p2j/persist/BufferManager.java    (working copy)
@@ -2058,7 +2058,8 @@
       {
          if (bmd != null && bmd.batchDepth == BatchModeData.INTERNAL)
          {
-            throw new IllegalStateException("Cannot nest internal batch assign modes!");
+            // batch copy can be nested if there is a before-table record which needs to be populated in RecordBuffer$Handler.invoke
+            // throw new IllegalStateException("Cannot nest internal batch assign modes!");
          }

          bmd = new BatchModeData();

I'm inclined to commit it as is.

#3 Updated by Constantin Asofiei about 2 years ago

Ovidiu, any thoughts on this? I can commit the patch as-is.

#4 Updated by Ovidiu Maxiniuc about 2 years ago

  • Status changed from New to WIP
  • % Done changed from 0 to 100

Yes, commit the change.
The exception was added for detecting internal logic errors. It actually works fine, I do not recall this exception to be thrown. At least not until now.

#5 Updated by Constantin Asofiei about 2 years ago

  • Assignee set to Constantin Asofiei
  • Status changed from WIP to Test

Committed to 6129a/13904.

Also available in: Atom PDF