Project

General

Profile

Bug #6591

DMO collisions with converted program/legacy class name or FWD classes

Added by Constantin Asofiei almost 2 years ago. Updated almost 2 years ago.

Status:
WIP
Priority:
Normal
Assignee:
Constantin Asofiei
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:

History

#2 Updated by Constantin Asofiei almost 2 years ago

In 3821c, there was a change which solved a camel-case issue - legacy tables names like SomeTableName were converted like Sametablename. A side effect of this is that it results in collisions with converted program/legacy class names or FWD class names.

A FWD class name which collides is TransactionType.

The other case is a DMO named SomeEventName - as we emit import com.goldencode.testacses.dmo.<schemaname>.*; for all converted classes, we end up with collisions when there is an explicit import for i.e. a SomeEventName converted legacy class name or even if there is a SomeEventName converted class in the same package, and the program wants to use the DMO - the SomeEventName converted class from the same package will 'hide' the DMO with the same name.

For the TransactionType issue, I think we need to rename the DMO to something else.

For the other case, I would be inclined to just explicitly import the DMO. But, this does not solve the case if there is an explicit import for a converted class with the same name. So again, we will need to rename any DMO which collides with a converted class name.

Any other ideas to solve this?

#3 Updated by Constantin Asofiei almost 2 years ago

  • % Done changed from 0 to 100
  • Assignee set to Constantin Asofiei
  • Status changed from New to WIP

The the DMO collisions with converted Java class name is already solved by appending the Program suffix (although this is kind of confusing for legacy classes). The compile failed because I forgot to do a 'clean' before the compile - so there was a previous SomeEventName Java class in build/classes, alongside SomeEventNameProgram.

The other issue with TransactionType will be solved by renaming the DMO.

#4 Updated by Ovidiu Maxiniuc almost 2 years ago

If not too late, I think we can slightly adjust the DMO name using hints.

Also available in: Atom PDF