Project

General

Profile

Bug #7204

method overload with dataset/temp-table parameters uses the index at the parameter signature

Added by Constantin Asofiei over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Constantin Asofiei
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:

History

#2 Updated by Constantin Asofiei over 3 years ago

This class defines two m1 methods, and a single dataset parameter. The temp-tables are the same, except tt1 has an index.

class oo.Foo:

   def temp-table tt1 field f1 as int index ix1 is unique f1.
   def temp-table tt2 field f1 as int.
   def dataset ds1 for tt1.
   def dataset ds2 for tt2.

  method protected void m1(input dataset ds1):
   end method.

   method protected void m1(input dataset ds2):
   end method.
end.

This shows that the parameter signature in case of dataset/temp-table needs to include the indexes, too, beside the fields.

#3 Updated by Constantin Asofiei over 3 years ago

  • Status changed from New to WIP
  • Assignee set to Constantin Asofiei

#4 Updated by Constantin Asofiei over 3 years ago

Another issue is that the index name must be part of the signature.

#5 Updated by Constantin Asofiei over 3 years ago

  • Status changed from WIP to Review
  • % Done changed from 0 to 100

This is fixed in 7199a rev 14509.

#6 Updated by Greg Shah over 3 years ago

Code Review Task Branch 7199a Revision 14509

In schema.g line 1073, please change the name of if to something that doesn't conflict with the Java keyword. It is too confusing.

Otherwise the changes are fine.

#7 Updated by Constantin Asofiei over 3 years ago

Greg Shah wrote:

Code Review Task Branch 7199a Revision 14509

In schema.g line 1073, please change the name of if to something that doesn't conflict with the Java keyword. It is too confusing.

Fixed in 7199a/14514.

#8 Updated by Greg Shah over 3 years ago

  • Status changed from Review to Test

#9 Updated by Constantin Asofiei over 3 years ago

7199a was merged to trunk rev 14514 and archived.

#10 Updated by Greg Shah over 3 years ago

  • Status changed from Test to Closed

Also available in: Atom PDF