Project

General

Profile

Bug #7284

undefined map var for standalone proxy generation

Added by Constantin Asofiei over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Constantin Asofiei
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:
version_reported:
version_resolved:
reviewer:
production:
No
env_name:
topics:

History

#1 Updated by Constantin Asofiei over 3 years ago

  • Assignee set to Constantin Asofiei
  • % Done changed from 0 to 100

The GenerateLegacyProxyOpenClient tool uses annotations/legacy_services.xml to perform a minimal annotation of the ASTs, for proxy generation. This in turn uses annotations/functions.rules, which relies on ftypesByName map defined in annotations.xml. This ftypesByName needs to be defined in legacy_services.xml, and is OK for it to be empty, as its usage is for DYNAMIC-FUNCTION calls, which do not matter for proxy generation.

Task branch 7284a was created from trunk rev 14538.

The fix is in 7284a/14539.

#2 Updated by Constantin Asofiei over 3 years ago

  • Status changed from New to Review

#3 Updated by Greg Shah over 3 years ago

Code Review Task Branch 7284a Revision 14539

No objections. Please add a comment to explain that these maps are there to hide the ones in annotations.xml and that they should remain even though they are unreferenced.

#4 Updated by Constantin Asofiei over 3 years ago

Greg Shah wrote:

No objections. Please add a comment to explain that these maps are there to hide the ones in annotations.xml and that they should remain even though they are unreferenced.

Added in 7284a rev 14540.

#5 Updated by Greg Shah over 3 years ago

You can merge to trunk.

#6 Updated by Constantin Asofiei over 3 years ago

7284a was merged to trunk 14539 and archived.

#7 Updated by Greg Shah over 3 years ago

  • Status changed from Review to Closed

Also available in: Atom PDF