FWD » Core Development » Runtime Infrastructure

Check #5703#note-610.

As discussed in #5703-608 and previous notes, the ServerDriver.connect() will call bc.setSever(true) and try to load the directory when no keystore is provided. The problem here is that in any mode other than MODE_START this is unsafe since the directory is potentially already open and being edited in a running server. We must not try to read or process that XML from a separate JVM. I guess this was added as an alternate approach so that the server's keystore does not need to be in the file system. I don't think it is a safe approach.

Here is the code at issue:

         if (bc.getString("security", "keystore", "filename", null) == null)
         {
            // if no keystore is specified, then we need to initialize as "server" and load it
            // from the directory.
            bc.setServer(true);
            bc.setConfigItem("directory", "xml", "must_exist", "true");
            DirectoryService ds = DirectoryService.createInstance(bc);
            if (!ds.bind())
            {
               LOG.warning("Could not bind directory!");
            }

            SecurityManager sm = SecurityManager.createInstance(bc);

            if (bc.getString("security", "truststore", "alias", null) == null)
            {
               // explictly set the trust alias as the server's alias
               String alias = sm.getServerAlias();
               bc.setConfigItem("security", "truststore", "alias", alias);
            }
            // force loading of the transport security
            sm.getSecureSocketContext();
            // go back in non-server mode
            bc.setServer(false);
         }