FWD » Core Development » Runtime Infrastructure

There are two places in ScanDriver where a Failure in file parsing problem may be encountered - both these need to log with SEVERE instead of FINE, to dump the stacktrace to the log.

With standalone tools I was cautious to convert all System.out prints to logs, because when these run in standalone mode (especially interactively, expecting input) it will produce rather weird output with some messages being formatted as logs and some as plain text. If important msgs are missing from the log files, maybe we can introduce a new mode for CentralLogger and mark the entry points to run it. It will take effect if no mode is already selected for the JVM. The point of the mode will be to simply reroute the msgs to System.out without formatting in the case of no server / client.

I guess ScanDriver can be running outside of client / server, so it may be a good candidate. What do you think?

An important side note: Failure in file at the moment is not logged in any way way, it's simple System.out.println. Also if you find any logs that need a different level, then feel free to change it.

In this case (ScanDriver is used by conversion) FWD uses CentralLoggerFallback, which has a default logging level of INFO.

LOG.log(Level.FINE, "", exc); will not emit the stacktrace. I'll change this to SEVERE.

On trunk Failure in file is:

            if (!silent)
            {
               System.out.println("Failure in file '" + result.fileName + "':");
            }

But maybe you've already reworked it on another branch.

Galya B wrote:

On trunk Failure in file is:

[...]

But maybe you've already reworked it on another branch.

Look bellow that for the stacktrace:

                     if (!silent)
                     {
                        System.out.println("Failure in file '" + fileName + "':");
                     }

                     LOG.log(Level.FINE, "", exc);

It will take effect if no mode is already selected for the JVM. The point of the mode will be to simply reroute the msgs to System.out without formatting in the case of no server / client.

I'd like to avoid this for now. Long term, we are moving away from direct usage of stdio.

I guess ScanDriver can be running outside of client / server, so it may be a good candidate. What do you think?

It definitely does run in a non-runtime environment but in the future it will be a highly managed environment which tracks state and definitely is not dependent upon stdio or any interactive UI.

Code Review Task Branch 7649a Revision 14680

No objection.

Can we merge this to trunk?

Yes

Branch 7649a was merged to trunk rev 14703.