Project

General

Profile

Bug #8446

REGRESSION: incorrect return value in ThinClient.waitForEvent

Added by Vladimir Tsichevski about 2 months ago. Updated about 2 months ago.

Status:
Test
Priority:
Normal
Assignee:
Vladimir Tsichevski
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

History

#1 Updated by Vladimir Tsichevski about 2 months ago

  • Status changed from New to WIP

This issue was the result of change in 8068a (trunk rev. 15032) and incomplete regression fix in 8419a (trunk rev. 15051).

This was reported in #6667-884 by Tomasz, who also provided the fix.

The value returned from ThinClient.waitForEvent must be the KeyInput object created in this method instead of the original event.

#4 Updated by Greg Shah about 2 months ago

Do you have the fix in a branch?

Hynek: Any objections to the fix?

Vladimir: This seems pretty safe. I think some stesting in <large_gui_app> is enough. Let's get this into trunk tonight.

#5 Updated by Vladimir Tsichevski about 2 months ago

  • % Done changed from 0 to 100
  • Status changed from WIP to Review

Fixed in 8446a rev. 15055. Please, review.

#6 Updated by Vladimir Tsichevski about 2 months ago

Greg Shah wrote:

Do you have the fix in a branch?

Hynek: Any objections to the fix?

Vladimir: This seems pretty safe. I think some stesting in <large_gui_app> is enough. Let's get this into trunk tonight.

I've done cursory testing, and noticed no anomalies.

#7 Updated by Hynek Cihlar about 2 months ago

  • Status changed from Review to Merge Pending

Code review 8446a revision 15055. The change looks good.

#8 Updated by Greg Shah about 2 months ago

Vladimir: You can merge to trunk now.

#9 Updated by Vladimir Tsichevski about 2 months ago

Greg Shah wrote:

Vladimir: You can merge to trunk now.

Done. Trunk rev. 15055.

#10 Updated by Greg Shah about 2 months ago

  • Status changed from Merge Pending to Test

Also available in: Atom PDF