Project

General

Profile

Bug #8579

Unit and OEUnit conversion: ignore annotations from other framework

Added by Vladimir Tsichevski 26 days ago. Updated 25 days ago.

Status:
Test
Priority:
Normal
Assignee:
Vladimir Tsichevski
Target version:
-
Start date:
Due date:
% Done:

100%

billable:
No
vendor_id:
GCD
case_num:

History

#1 Updated by Vladimir Tsichevski 26 days ago

Currently, if a test 4gl source includes both ABLUnit annotations and OEUnit annotations, all these annotations are converted regardless of the unit testing flavor configured for this source.

Annotations specific for other flavor must be (silently or not) ignored by conversion rules.

#2 Updated by Vladimir Tsichevski 26 days ago

  • Status changed from New to WIP

#3 Updated by Vladimir Tsichevski 26 days ago

  • Status changed from WIP to Review
  • % Done changed from 0 to 100

Fixed in 8579a rev. 15120. Please, review.

#4 Updated by Greg Shah 26 days ago

  • Assignee set to Vladimir Tsichevski
  • Status changed from Review to Internal Test

Code Review Task Branch 8579a Revision 15120

I think the code would be simpler and easier to read if you create a variable named ablunit that is reset for every file, and initialize it using execLib("is_abl_unit"). Then use that instead of execLib("is_abl_unit"). You can also use !ablunit for the OEUnit cases.

#5 Updated by Vladimir Tsichevski 26 days ago

  • Assignee deleted (Vladimir Tsichevski)

Greg Shah wrote:

Code Review Task Branch 8579a Revision 15120

I think the code would be simpler and easier to read if you create a variable named ablunit that is reset for every file, and initialize it using execLib("is_abl_unit"). Then use that instead of execLib("is_abl_unit"). You can also use !ablunit for the OEUnit cases.

Done. Rev. 15121.

#6 Updated by Greg Shah 26 days ago

Code Review Task Branch 8579a Revision 15121

The change is good.

What additional testing is needed?

#7 Updated by Vladimir Tsichevski 26 days ago

Greg Shah wrote:

Code Review Task Branch 8579a Revision 15121

The change is good.

What additional testing is needed?

I re-converted the ABLUnit TestOO.cls from #8574, and now it has no unit test Java annotation converted from the OEUnit annotation.
I think, no other testing is needed.

#8 Updated by Greg Shah 25 days ago

  • Status changed from Internal Test to Merge Pending
  • Assignee set to Vladimir Tsichevski

You can merge 8579a to trunk now.

#9 Updated by Vladimir Tsichevski 25 days ago

Greg Shah wrote:

You can merge 8579a to trunk now.

Done. Rev. 15123.

#10 Updated by Greg Shah 25 days ago

  • Status changed from Merge Pending to Test

Also available in: Atom PDF