FWD » Core Development » Base Language

Some procedures and functions can be defined in classes.

• PROCEDURE EXTERNAL
• PROCEDURE/FUNCTION ... IN handle where the handle is a class var/prop (static or not, or from super-class?)

• oo/FProc.cls
  

  class oo.FProc.
     def private static property p1 as handle get. set.
  
     function func0 returns int in p1.
  
     constructor static FProc().
        run fproc.p persistent set p1.
     end.
  
     method public static int test1().
        return func0().
     end.
  end.
  

• fproc.p
  

  function func0 returns int.
    return 1234.
  end.
  
  message "here".
  

• fprocrun.p
  

  message oo.Fproc:test1().
  

• in ProcedureManager.getAbsoluteName we need to check for Object.class referent (this is the pseudo-instance for the 'static instance' of the legacy class)
  

     static String getAbsoluteName(Object referent)
     {
        String jname = null;
  
        if (referent.getClass() == Object.class)
        {
           jname = ObjectOps.getStaticClass(referent).getName();
        }
        else
        {
           jname = referent.getClass().getName();
        }
  
        String pname = SourceNameMapper.getLegacySourceName(jname);
        return pname;
     }
  

• in conversion:
  • the handle expression needs to be static (and context-local), the same the class:
    

       private static ContextLocal<HandleExpr0> handleExpr0 = new ContextLocal<HandleExpr0>()
       {
          protected HandleExpr0 initialValue()
          {
             return new HandleExpr0();
          }
       };   ...
       static class HandleExpr0
       extends GenericExpression
       {
          public BaseDataType resolve()
          {
             return getP1();
          }
       }
    

  • registerFunctionHandle needs to be in the static constructor (now is in the 'execute' method for the actual instances of this class)
    

       public static void __oo_Fproc_constructor__static__()
       {
          externalProcedure(Fproc.class, "FProc", new Block((Body) () -> 
          {
             ProcedureManager.registerFunctionHandle("func0", handleExpr0.get());
          }));
       }
    
    

So this is also conversion issue.

The changes will reach trunk via 9457a - see rev 15802. 9435a was archived as dead.