FWD » Core Development » Runtime Infrastructure

Constantin has a set of tests for Appserver (as noted in #8661-543):

I've uploaded a new devsrv01:/tmp/open_client_example_20250124.zip project. For this, I had to use this patch, on top of trunk rev 15657 - there are some regressions in trunk:

patch...patch...

=== modified file 'src/com/goldencode/p2j/main/RemoteInvocationResult.java'
--- old/src/com/goldencode/p2j/main/RemoteInvocationResult.java 2022-02-09 14:18:48 +0000
+++ new/src/com/goldencode/p2j/main/RemoteInvocationResult.java 2025-01-24 12:26:09 +0000
@@ -106,6 +106,28 @@
     */
    public void setResult(Object result)
    {
+      if (result != null && result instanceof BaseDataType)
+      {
+         Class<?> cls = result.getClass();
+         while (cls != null && cls.isAnonymousClass())
+         {
+            cls = cls.getSuperclass();
+         }
+         if (cls != result.getClass())
+         {
+            try
+            {
+               BaseDataType bdt = (BaseDataType) cls.newInstance();
+               bdt.assign(result);
+               result = bdt;
+            }
+            catch (InstantiationException | 
+                   IllegalAccessException e)
+            {
+               // TODO: what to do here?
+            }
+         }
+      }
       this.result = result;
    }

=== modified file 'src/com/goldencode/p2j/util/Agent.java'
--- old/src/com/goldencode/p2j/util/Agent.java  2025-01-17 13:03:13 +0000
+++ new/src/com/goldencode/p2j/util/Agent.java  2025-01-24 12:10:31 +0000
@@ -2410,10 +2410,6 @@
             if (returnValue)
             {
                result = ObjectOps.invoke(ref, name, modes, args);
-            }
-            else
-            {
-               ObjectOps.invokeStandalone(ref, name, modes, args);;

                if (result instanceof handle)
                {
@@ -2423,6 +2419,10 @@
                }
                invocationResult.setResult(result);
             }
+            else
+            {
+               ObjectOps.invokeStandalone(ref, name, modes, args);
+            }
          }
          catch (StopConditionException e)
          {

The project has these folders:

• src with the converted results
• src.legacy with tests written for OpenEdge
• src.proxy with the FWD generated OpenClient proxy Java code
• src.fwd with the FWD tests for OpenClient
  • SimpleFWDTest can be used to test 'high-level' OpenClient calls
  • TestDirectOpenClient can be used to test 'low-level' AppServerHelper APIs.

In this task we will:

• Merge the project content (configuration, data and test code...) into the Testcases.
• Rework the src.legacy tests into JUnit tests.
• Rework the src.fwd tests into JUnit tests.

Whoever does this work should determine the degree to which these test sets cover the requirements from Appserver Tests. That wiki page should be updated with the details of the tests including how to run them.

Greg, the file needs to be moved from /tmp/ to be preserved - it will get deleted on next restart of devsrv01. What folder should I use?

I copied open_client_example_20250124.zip to xfer at /opt/gcd/.