FWD » Testing

If the launch configuration classpath includes a FWD project (namely the p2j.jar) explicitly or implicitly (through the Java extension mechanism),
then it is impossible to run any plain JUnit5 tests.

The problem origin:

1. JUnit5 unconditionally discovers all test engines in the classpath using the "services" mechanism, so it always discovers the FWD test engine.
2. JUnit5 fails to initialize the FWD test engine (it requires proper FWD client-server environment)
3. JUnit5 aborts the process, so the ordinary JUnit5 tests (run by the JUnit5 Jupiter engine) are never executed.

Unfortunately, this may happen for any Java project. The most surprising situation is if the project is not related to FWD, but uses a JRE with p2j.jar installed into the JRE lib/ext directory :-(

Workarounds:

1. Junit5 console launcher allows to explicitly exclude test engines, so the problem can be workarounded
2. Eclipse test runner does not allow this, so for Eclipse there is no workarounds.

The proposed cure:

Currently the exceptions generated by FWD test engine generation, are not caught, and propagate to the JUnit5 launcher, causing it to abort:

      switch (state)
      {
         case INITIALIZED:
            break;

         case NONE:
            final ConfigurationParameters configurationParameters = discoveryRequest
                     .getConfigurationParameters();
            if (initialize(
                     configurationParameters.get(CFG_FWD_CONFIG_FILE).orElse(DEFAULT_FWD_CONFIG_FILE)))
            {
               state = State.INITIALIZED;
               break;
            }
            //$FALL-THROUGH$

         case INOPERABLE:
            return new NoopDescriptor(UniqueId.forEngine(getId()), "No-op");

      }

the fix: intercept exceptions and switch the engine to inoperable state:

      switch (state)
      {
         case INITIALIZED:
            break;

         case NONE:
            final ConfigurationParameters configurationParameters = discoveryRequest
                     .getConfigurationParameters();
            try
            {
               if (initialize(configurationParameters.get(CFG_FWD_CONFIG_FILE)
                        .orElse(DEFAULT_FWD_CONFIG_FILE)))
               {
                  state = State.INITIALIZED;
                  break;
               }
            }
            catch (@SuppressWarnings("unused") final Throwable t)
            {
               // no-op, continue as inoperable
            }

            state = State.INOPERABLE;            
            //$FALL-THROUGH$

         case INOPERABLE:
            return new NoopDescriptor(UniqueId.forEngine(getId()), "No-op");

      }

this also cures another bug: currently the INOPERABLE state is never assigned.

After this done, the FWD test engine results still look like one failed test, but other test engines execute normally:

The proposed change seems to be a resasonable improvement. Go ahead and put it in a branch and get it tested.

Greg Shah wrote:

The proposed change seems to be a resasonable improvement. Go ahead and put it in a branch and get it tested.

Branch 9649a, rev. 15703 has the fix.

Merge to trunk after 9498a.