Feature #9787: Missing NUM-ITERATIONS frame widget attribute full support - User Interface - Golden Code Redmine

Feature #9787

Missing NUM-ITERATIONS frame widget attribute full support

Added by Eugenie Lyzenko over 1 year ago. Updated over 1 year ago.

Status:

Test

Priority:

Normal

Assignee:

Eugenie Lyzenko

Target version:

-

Start date:

Due date:

% Done:

100%

billable:

No

vendor_id:

GCD

case_num:

version_reported:

version_resolved:

trunk revision 15808

reviewer:

production:

No

env_name:

topics:

History

#1 Updated by Eugenie Lyzenko over 1 year ago

The original source can be simple:

...
iter_count = frame frame1:NUM-ITERATIONS.
...

properly converted to:

...
         iterCount.assign(frame1Frame.asWidget().numIterations());
...

But compilation fails because FrameWidget has no implemented method numIterations().

Eric, Greg,

Do we need to fix it now?

#2 Updated by Eugenie Lyzenko over 1 year ago

Subject changed from Missing NIM-ITERATIONS frame widget attribute full support to Missing NUM-ITERATIONS frame widget attribute full support

#4 Updated by Greg Shah over 1 year ago

Yes, fix it now.

#5 Updated by Eugenie Lyzenko over 1 year ago

Greg Shah wrote:

Yes, fix it now.

Created task branch 9787a from trunk revision 15779.

#6 Updated by Eugenie Lyzenko over 1 year ago

Status changed from New to WIP

#7 Updated by Eugenie Lyzenko over 1 year ago

% Done changed from 0 to 100
Status changed from WIP to Review

The 9787a updated for review to revision 15780.

Complete runtime support for NUM-ITERATIONS attribute with frame widget.

The test can be used:

ef var i as int.
def var iter_count as int.
def var fld1 as character.
def var handle_frame as handle.
def var str_tab_order as character.
def var handle_w as handle.
def var name_fg as character label "".
def var b1 as handle.
def var cur_handle as handle.

def button exit_btn label "exit".

def frame frame1 with side-labels centered. 

repeat i = 1 to 4:
 name_fg = "fg" + string(i).

 put screen row (3 * i - 1) col 30 (name_fg + "_"). 
 display fld1 skip(2) with frame frame1 4 down.

 handle_w = fld1:handle .

 handle_w:name = name_fg + "_" + handle_w:name.

 enable fld1 with frame frame1.
end.

iter_count = frame frame1:NUM-ITERATIONS.

message "Number of iterations for a frame:" + string(iter_count).
handle_frame = frame frame1:handle.

enable exit_btn.

wait-for choose of exit_btn.

#8 Updated by Greg Shah over 1 year ago

reviewer Hynek Cihlar added

#9 Updated by Eugenie Lyzenko over 1 year ago

The 9787a updated for review to revision 15781. Rebased with recent trunk 15789. New revision is 15791.

Integrated fix for #9792 issue. If no objections we can merge this into trunk.

#10 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15790, new revision is 15792.

Just rebase.

#11 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15798, new revision is 15800.

#12 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15799, new revision is 15801.

#13 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15800, new revision is 15802.

#14 Updated by Hynek Cihlar over 1 year ago

Status changed from Review to Internal Test

Code review 9787a. The changes look good. Please include ChUI also run regression tests.

#15 Updated by Eugenie Lyzenko over 1 year ago

Hynek Cihlar wrote:

Code review 9787a. The changes look good. Please include ChUI also run regression tests.

Yes, we can do this but it is pretty useless because the ChUI regression tests do not use the features implemented with this branch.

#16 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15803, new revision is 15805.

The ChUI regression testing is in progress now.

#17 Updated by Eugenie Lyzenko over 1 year ago

The 9787a updated for review to revision 15806.

The change fixes the typo in history entry number for file CommonFrame.java.

And ChUI regression testing passed without regressions. So I think we are ready to merge this into trunk.

Hynek, do you have anymore objections/notes.

#18 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15806, new revision is 15809.

Hynek,

Do you have another objection for merging this into trunk?

#19 Updated by Hynek Cihlar over 1 year ago

Status changed from Internal Test to Merge Pending

Please merge 9787a to trunk after 9491b.

#20 Updated by Eugenie Lyzenko over 1 year ago

Hynek Cihlar wrote:

Please merge 9787a to trunk after 9491b.

OK.

#21 Updated by Eugenie Lyzenko over 1 year ago

The 9787a rebased with trunk revision 15807, new revision is 15810.

Starting merge in trunk.

#22 Updated by Eugenie Lyzenko over 1 year ago

version_resolved set to trunk revision 15808

Branch 9787a was merged to trunk as revno 15808 then it was archived.

#23 Updated by Greg Shah over 1 year ago

Status changed from Merge Pending to Test

Also available in: Atom PDF