Project

General

Profile

Activity

From 11/13/2012 to 12/12/2012

12/12/2012

06:22 PM Feature #1611: implement QUOTER utility
Assuming you have handled all the known issues, you can prepare/upload the update. Make sure the documentation you h... Greg Shah
06:21 PM Feature #1611: implement QUOTER utility
The documentation is pretty good. Some comments:... Greg Shah
02:56 PM Feature #1611: implement QUOTER utility
*QUOTER UTILITY DESCRIPTION*
The quoter utility will put the elements identified and extracted from the
input...
Costin Savin
02:55 PM Feature #1611: implement QUOTER utility
1. If a quoter command will be split in this way in p2j it will also not work in Progress. Checked.
2. This doesn'...
Costin Savin
02:33 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Your latest approach is all good except that we don't need a new p2j.cfg.xml parameter. We already have one that is ... Greg Shah
01:37 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Do not use the current conversion platform to determine how we convert strings. We can't go this route.
OK. I se...
Eugenie Lyzenko

12/11/2012

05:27 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Do not use the current conversion platform to determine how we convert strings. We can't go this route. The problem... Greg Shah
03:32 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Fix for backslash processing for conversion on Windows.
The suggested solution will be activated only when running...
Eugenie Lyzenko
09:22 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
This is all a single update. Greg Shah
09:08 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The Windows tests is OK too. I would like to make more tests with simulated two chars path separator to be sure this ... Eugenie Lyzenko
08:22 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Looks good. Greg Shah
02:49 PM Feature #1611: implement QUOTER utility
... Greg Shah
02:41 PM Feature #1611: implement QUOTER utility
Please show an example here that reproduces the problem. And show the error output from the 4GL. Greg Shah
02:39 PM Feature #1611: implement QUOTER utility
There is one case of error message which might not be able to be reproduced exactly as in Progress. When we pass the ... Costin Savin
03:33 AM Feature #1611: implement QUOTER utility
That would be much easier since I already have these checks in place before doing the pattern check which is supposed... Costin Savin
12:44 PM Support #1928: update documentation to explain how to convert, develop and run P2J on Windows
Update all P2J books to describe how to:
- run conversion on Windows
- run P2J (client and server) on Windows
- se...
Greg Shah
12:42 PM Support #1928 (Closed): update documentation to explain how to convert, develop and run P2J on Wi...
Greg Shah
11:04 AM Feature #1921: implement super-procedures
I'm OK with your approach. Greg Shah
10:48 AM Feature #1921: implement super-procedures
After looking at progress.g, SymbolResolver.addFunction and Function.annotateOptions, the simplest way I see to solve... Constantin Asofiei
10:12 AM Feature #1921: implement super-procedures
If there are frame definition inside a "to-be-hidden" local function or procedure, then the frame definition "leaks" ... Constantin Asofiei
09:29 AM Feature #1921: implement super-procedures
My first approach is to just drop the sub-trees.
Thanks for the frame definition tip, I'll check also how these case...
Constantin Asofiei
09:21 AM Feature #1921: implement super-procedures
What is your approach to handling this behavior? Do you just hide or drop the sub-trees?
One thing to consider: a...
Greg Shah
09:02 AM Feature #1921: implement super-procedures
Greg, the order of the procedure/function is not important. No matter how you mix the procedures/functions in the abo... Constantin Asofiei
08:28 AM Feature #1921: implement super-procedures
Good findings. I find it hard to understand the value of this complexity. Much of the behavior seems arbitrary.
...
Greg Shah
07:51 AM Feature #1921: implement super-procedures
4GL allows procedure (and function) definitions with the same name, under some circumstances.
If two or more procedu...
Constantin Asofiei

12/10/2012

05:39 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The new version of the fixupPropath() method.
1. Handles the arbitrary length of the path separator
2. Optimizing f...
Eugenie Lyzenko
09:58 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
09:16 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> The fixupPropath() should be a little different. I don't want getPathSeparator() called more than once, because it ... Eugenie Lyzenko
08:24 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
I am OK with the changes to setSearchPath(), getPathSeparator(), getLegacyPathSeparator() and getLegacyFileSeparator(... Greg Shah
03:07 PM Feature #1611: implement QUOTER utility
Is there anything wrong with my assumption that the path and the executable name will be in the same string AND that ... Greg Shah
03:01 PM Feature #1611: implement QUOTER utility
I've tried to cover that, here is an example for the latest pattern I've gotten today:... Costin Savin
02:55 PM Feature #1611: implement QUOTER utility
Costin: yes, we should handle paths on network shares.
Are we making this too difficult? The basic matching seem...
Greg Shah
01:48 PM Feature #1611: implement QUOTER utility
> Should also windows network paths be detected as paths for quoter?
> I'm having a little trouble with the regular ...
Eugenie Lyzenko
01:40 PM Feature #1611: implement QUOTER utility
Should also windows network paths be detected as paths for quoter?
I'm having a little trouble with the regular expr...
Costin Savin

12/07/2012

05:59 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The fix for path separator in PROPATH handling issue.
The idea is to have the helper method fixupPropath(String pr...
Eugenie Lyzenko
02:53 PM Feature #1611: implement QUOTER utility
... Greg Shah
02:45 PM Feature #1611: implement QUOTER utility
1.Already tested by copying the quoter executable in a path containing spaces and it works.
2. Working on it, my q...
Costin Savin
02:37 PM Feature #1611: implement QUOTER utility
Yes, Eugenie found this as well. He is working on it.
In the meantime, you should do 2 things:
1. Make sure th...
Greg Shah
02:16 PM Feature #1611: implement QUOTER utility
Coming back to the case of converting:... Costin Savin
11:53 AM Feature #1611: implement QUOTER utility
... Greg Shah
11:41 AM Feature #1611: implement QUOTER utility
Is it safe to consider that if the code is converted with a certain OS specific it will also only be run in that OS?
...
Costin Savin
05:36 AM Feature #1921: implement super-procedures
Entry 43 for #1920 was added a test update which covers the conversion rules for both persistent and super-procedures... Constantin Asofiei
05:33 AM Feature #1920: implement persistent procedures
Attached there is a test update which contains:
1. rules/ - all rules files which affect the conversion of persisten...
Constantin Asofiei

12/06/2012

03:37 PM Feature #1884: add some of the v10 data types and core built-ins
_*TextOps class*_
I'm attaching an update containing:
- the TextOps class including fields and (static and some uti...
Adrian Lungu
03:22 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
02:54 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
You mean the current conversion "C:\Windows\system;C:\Users\Eugenie\bin;" to "C:Windowssystem;C:Users\033ugenie\bin;"... Eugenie Lyzenko
02:32 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
3. Yes, what I see in 4GL is predefined Progress-specific path. The code to display PROPATH:... Eugenie Lyzenko
02:23 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
1. The conversion of string literals when the target is Windows, should already double up the \ characters, but in th... Greg Shah
02:09 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Make sure your p2j.cfg.xml is properly setup for Windows conversions. This should not be happening.
The p2j.cfg....
Eugenie Lyzenko
10:53 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
02:52 PM Feature #1611: implement QUOTER utility
Tested for
to see the values from readFile.read() when the logic gets to them...
Costin Savin
12:35 PM Feature #1611: implement QUOTER utility
available() just tells you if you are going to block or not on a read. If it returns > 0 then you will not block if ... Greg Shah
11:58 AM Feature #1611: implement QUOTER utility
The case I'm refferring to is when readFile is a BufferedReader pointing to System.in, in case readFile points to a f... Costin Savin
11:29 AM Feature #1611: implement QUOTER utility
I don't understand how the readFile.read() can help in this case. If readLine() returns null but you are not at EOF,... Greg Shah
11:09 AM Feature #1611: implement QUOTER utility
Actually this is the problem
readFile.readLine()) can return null if the stream hasn't put anything on yet and in th...
Costin Savin
11:02 AM Feature #1611: implement QUOTER utility
... Greg Shah
10:30 AM Feature #1611: implement QUOTER utility
The readFile is a BufferedReader obtained in this way:... Costin Savin
10:10 AM Feature #1611: implement QUOTER utility
Looking closer at the FileStream sub-class (which is the closest match) I don't think there is an easy way to turn a ... Greg Shah
10:01 AM Feature #1611: implement QUOTER utility
Which Stream can I use?
Looking at the com.goldencode.p2j.util.Stream implementations:
*FileStream* constructor...
Costin Savin
09:19 AM Feature #1611: implement QUOTER utility
How about using one of the com.goldencode.p2j.util.Stream sub-classes to read the input? We have already written thi... Greg Shah
09:10 AM Feature #1611: implement QUOTER utility
1. You are right about the conversion settings I had them for Unix, will add the logic to handle this case.
2. Nor...
Costin Savin
08:19 AM Feature #1611: implement QUOTER utility
... Greg Shah
08:41 AM Feature #1920: implement persistent procedures
We have task #1634 which is where we will work on the rest of the native procedure support. I agree with your plan f... Greg Shah
02:39 AM Feature #1920: implement persistent procedures
My conclusions about native-procedure (PROCEDURE ... EXTERNAL cases) are:
* when a 4GL external procedure has a head...
Constantin Asofiei
08:38 AM Feature #1634: implement full native library (.so or DLL) support
Please look at #1920-41 and the related prior notes for some very useful information regarding native procedures. Greg Shah

12/05/2012

05:38 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The following features were confirmed as working in native 4GL in Windows:
FILE-INFO:FILE-CREATE-DATE file_system_tr...
Eugenie Lyzenko
05:35 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Several notes for PROPATH get/set functionality
1. The P2J converts, compile and run the PROPATH statement.
2. The ...
Eugenie Lyzenko
03:03 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Yes, we should implement a Windows-specific default (what is it?) in EnvironmentOps. I don't want to have to put so... Eugenie Lyzenko
02:45 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
... Greg Shah
07:03 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The following calls has testcases to verify conversion result in Windows:... Eugenie Lyzenko
03:05 PM Feature #1611: implement QUOTER utility

@OS-COMMAND "c:\my stupid space \laden path\quoter.exe" -C 45-50 whatever > output.txt@
this kind of call might be...
Costin Savin
01:32 PM Feature #1611: implement QUOTER utility
... Greg Shah
02:32 PM Feature #1920: implement persistent procedures
... Greg Shah
01:49 PM Feature #1920: implement persistent procedures
1 - yes, I refer to PROCEDURE ... EXTERNAL case
2 - I don't have a fully working example (i.e. I don't have a dll ...
Constantin Asofiei
01:23 PM Feature #1920: implement persistent procedures
Some questions/comments:
1. What do you mean by "native-proc"? Do you mean the invocation of something defined as...
Greg Shah
12:47 PM Feature #1920: implement persistent procedures
Greg, should I add support for the "h:<read-only-attribute> = value" cases too ? Because 4GL does allow them (shows a... Constantin Asofiei
11:35 AM Feature #1920: implement persistent procedures
All RUN cases are handled by these rules:
- ControlFlowOps.invoke(String name, Object ... param) will be emitted for...
Constantin Asofiei

12/04/2012

06:43 PM Feature #1611: implement QUOTER utility
Greg: yes, the calls input through, output through and input-output through has the problem in Windows running after ... Eugenie Lyzenko
12:22 PM Feature #1611: implement QUOTER utility
Are there more possible extensions quoter can have besides .exe, on unix maybe? Using Quoter with a path containing s... Costin Savin
08:48 AM Feature #1611: implement QUOTER utility
In regards to note 36 (https://projsrv01/redmine/issues/1611#note-36):
Eugenie: please read that note carefully. Y...
Greg Shah
04:27 AM Feature #1611: implement QUOTER utility
Greg, what Costin saw I think is a difference between how 4GL behaves on Windows and Linux environments. Assuming we ... Constantin Asofiei
09:06 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Hold it until we have all the changes ready for the task. Greg Shah
08:49 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...
See https://projsrv01/redmine/issues/1611#note-36 for some useful notes. Greg Shah

12/03/2012

04:29 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Do we need this change to be integrated into current P2J build? I mean regression testing and checking in to bzr? Or ... Eugenie Lyzenko
02:50 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
It looks good. Remove the MacOS support from indexOfNewLine() and go with it. Greg Shah
10:38 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK. The suggested helper is the method in Stream class:... Eugenie Lyzenko
09:43 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Although the Stream use of searching for NEWLINE isn't causing a problem right now, I still want it to be fixed. Try... Greg Shah
02:47 PM Feature #1611: implement QUOTER utility
I don't understand. My recent suggestion to modify ProcessDaemon to transform "quoter" into "java ... com.goldencode... Greg Shah
02:13 PM Feature #1611: implement QUOTER utility
Would launching the Quoter as a separate process be a solution for this? Costin Savin
10:40 AM Feature #1611: implement QUOTER utility
Compared p2j implementation results to progress,however there seems to be one problem :
When we use it in p2j the co...
Costin Savin

11/30/2012

06:12 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
All the following calls from the file_system.odt have testcases, converts and run in Windows environment:... Eugenie Lyzenko
06:01 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
I just retested and have the correction. The case 1 can be left untouched. And moreover case 2 can be unchanged too. ... Eugenie Lyzenko
05:10 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Is case 1 really a problem? That is about writing a newline, not searching for one. I think it should write the loc... Greg Shah

11/29/2012

03:42 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The investigation results:
Affected code is located in com.goldencode.p2j.util package, classes Stream and FileStrea...
Eugenie Lyzenko
09:29 AM Feature #1611: implement QUOTER utility
... Greg Shah
09:27 AM Feature #1611: implement QUOTER utility
Constantin, you raise some good points.
Here are the differences as I know them:
- On Windows, the executable...
Greg Shah
09:19 AM Feature #1611: implement QUOTER utility
Related to this
Quoter syntax is:
@quoter [options] [input_file] >[output_file]@
In the quoter implementation I...
Costin Savin
03:13 AM Feature #1611: implement QUOTER utility
I don't think it is that easy to replace "quoter" references from the process-launching command with the "java ..." c... Constantin Asofiei

11/28/2012

01:27 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK. Please propose a fix as part of this task. Greg Shah
12:51 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The testing respective 4GL program in Windows OpenEdge10 discovers the 4GL accepts both Linux and Windows style line ... Eugenie Lyzenko
08:18 AM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Yes and yes. Correct. Greg Shah
07:17 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
> Please test the same case in 4GL on Windows. In other words: does the 4GL properly honor the Linux line end the sam... Eugenie Lyzenko
09:39 AM Feature #1590 (Closed): implement PROPATH assignment
Greg Shah
09:00 AM Feature #1590 (Review): implement PROPATH assignment
Costin Savin
08:45 AM Feature #1611: implement QUOTER utility
Constantin: you make very good points here. Yes, these other cases are problems. And the client-side invocation is ... Greg Shah
08:28 AM Feature #1611: implement QUOTER utility
Tested @INPUT THROUGH@ and @OUTPUT THROUGH@ stream case and they are viable.
The @INPUT-OUTPUT THROUGH@ stream case ...
Costin Savin
07:10 AM Feature #1611: implement QUOTER utility
Greg, some thoughts about the QUOTER utility: as this is an external program invoked via the OS-COMMAND and other pro... Constantin Asofiei

11/27/2012

06:58 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
It is an interesting finding (about the Linux line ending not being honored in P2J on Windows). Please test the same... Greg Shah
06:06 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
The second part of the stream chapter:... Eugenie Lyzenko
04:29 PM Feature #1611: implement QUOTER utility
... Greg Shah
01:20 PM Feature #1611: implement QUOTER utility
... Costin Savin
12:33 PM Feature #1611: implement QUOTER utility
Made the changes according to feedback, there's some issue though:... Costin Savin
07:39 PM Feature #1611 (WIP): implement QUOTER utility
This is much better.
Feedback:
1. What are the results of your testing with these options? I see that you have ...
Greg Shah
09:59 AM Feature #1591: implement QUOTER built-in function
This javadoc:... Greg Shah
08:56 AM Feature #1591: implement QUOTER built-in function
Attached proposed update Costin Savin

11/26/2012

04:50 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Correct. Greg Shah
04:13 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
Need to clarify in requirements for the following resources:... Eugenie Lyzenko
01:24 PM Feature #1611: implement QUOTER utility
Added proposed update, commityed testcases to bazaar, run regression tests (to see if they don't fail because of the ... Costin Savin
12:41 PM Feature #1920: implement persistent procedures
... Greg Shah
12:02 PM Feature #1920: implement persistent procedures
A "message h:next-sibling:prev-sibling:next-sibling:name." statement gets parsed this way (from .parser file):... Constantin Asofiei
11:15 AM Feature #1920: implement persistent procedures
I wonder if treating COLON as a binary operator will help with the conversion.
I also wonder if we are parsing cha...
Greg Shah
09:14 AM Feature #1920: implement persistent procedures
Understood and agreed. Greg Shah
09:12 AM Feature #1920: implement persistent procedures
One thing about handle.unwrap. 4GL allows these kind of calls:... Constantin Asofiei
09:11 AM Feature #1920: implement persistent procedures
> In regards to the RUN <proc> PERSISTENT, is that a case where we know that <proc> is an external procedure (or shou... Constantin Asofiei
09:03 AM Feature #1920: implement persistent procedures
Sorry, I wish I was wrong on this point.
In regards to the RUN <proc> PERSISTENT, is that a case where we know tha...
Greg Shah
03:33 AM Feature #1920: implement persistent procedures
Greg, you are correct, 4GL allows '.', '\' and '/' characters as part of an internal procedure's name; so, we can't d... Constantin Asofiei

11/23/2012

04:42 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
For now the following features described in streams.odt chapter have testcases to demonstrate conversion in Windows. ... Eugenie Lyzenko
11:23 AM Feature #1920: implement persistent procedures
About the static calculation of called code in a RUN statement, I am concerned with this information you posted in #1... Greg Shah
10:37 AM Feature #1920: implement persistent procedures
Actually, the only case when conversion knows for sure what to emit is the RUN filename statement, when the filename ... Constantin Asofiei
08:56 AM Feature #1920: implement persistent procedures
... Greg Shah
08:36 AM Feature #1591: implement QUOTER built-in function
... Greg Shah

11/22/2012

11:17 AM Feature #1920: implement persistent procedures
1 - This would be my choice too.
2 - Yes
3 - If there is only one handle.unwrap method to access the attributes...
Constantin Asofiei
10:29 AM Feature #1920: implement persistent procedures
In regard to the handle issue:... Greg Shah
06:36 AM Feature #1920: implement persistent procedures
Another thing about RUN filename PERSIST [SET handle] statement. We can either emit this something like (for a RUN te... Constantin Asofiei
04:57 AM Feature #1920: implement persistent procedures
Greg, something about the handle attributes in general. In 4GL, a code like this:... Constantin Asofiei
11:13 AM Feature #1591: implement QUOTER built-in function
1. This issue seems to appear when I recheck the files from the zip before submitting, I'm aware of it now.
3....
Costin Savin
09:44 AM Feature #1591: implement QUOTER built-in function
Feedback:
1. The file rules/convert/builtin_functions.rules~ should not be in the update zip.
2. There are stil...
Greg Shah
02:58 AM Feature #1591 (Review): implement QUOTER built-in function
Costin Savin

11/21/2012

02:12 PM Feature #1591: implement QUOTER built-in function
Added revised update but for
14:
Couldn't find the wrong alignment...
Costin Savin
12:13 PM Feature #1591: implement QUOTER built-in function
Feedback:
1. Rename workQuoter() to quoterWorker().
2. workQuoter() is private static. Per the coding standard...
Greg Shah
07:52 AM Feature #1591: implement QUOTER built-in function
Added propposed update. Submited testcase quoter-builtin-function.p to bazaar testcases repository. Costin Savin
01:55 PM Feature #1920: implement persistent procedures
Sorry, I've changed it now, it was a typo mistake. Constantin Asofiei
01:53 PM Feature #1920: implement persistent procedures
Is the sample missing the empty ()?... Greg Shah
12:32 PM Feature #1920: implement persistent procedures
New important findings: the "handle" for the "RUN ... IN handle", "DYNAMIC-FUNCTION(... IN handle)" and "FUNCTION ...... Constantin Asofiei
11:16 AM Feature #1626: implement OS-DIR support as an INPUT stream
Please review the features of the OS-DIR input stream type in the INPUT FROM language statement. You should implemen... Greg Shah

11/20/2012

02:26 PM Feature #1648: review all filesystem support (runtime) on Windows and fix/resolve any issues
OK. Eugenie Lyzenko
02:24 PM Feature #1648 (WIP): review all filesystem support (runtime) on Windows and fix/resolve any issues
Please review the streams.odt and file_system.odt chapters of the Conversion Reference. Both chapters have summary t... Greg Shah
02:17 PM Support #1700 (Closed): test the startup, basic processing and shutdown of the P2J server and P2J...
Greg Shah
07:53 AM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
I rebuilt staging. Please distribute the update via email. Greg Shah
07:32 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Checked in p2j bzr and applied to staging.
Need to run ant jar in staging p2j to take effect.
Eugenie Lyzenko
02:03 PM Feature #1591: implement QUOTER built-in function
After retest on Progress found that custom null can only be provided with 3 argument call, if a 2 argument it's tried... Costin Savin
12:13 PM Feature #1591: implement QUOTER built-in function
I understand. Don't worry about the fact that the result will not work in PostgreSQL. We know this. But any such d... Greg Shah
11:05 AM Feature #1591: implement QUOTER built-in function
Is the main purpose of quoter to be used with database query instructions like where clauses?
If so, there might be s...
Costin Savin
09:20 AM Feature #1921: implement super-procedures
> This is ridiculous.
I agree, it took me a while to figure it out that the search mode is not for the caller, but ...
Constantin Asofiei
08:43 AM Feature #1921: implement super-procedures
This is ridiculous. Some thoughts in general:
1. The complexity of this behavior is high.
2. There is a mismatch...
Greg Shah
07:23 AM Feature #1921: implement super-procedures
To demonstrate how SEARCH-SELF and SEARCH-TARGET behave, let's assume we have this super-procedure hierarchy:... Constantin Asofiei

11/19/2012

05:16 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
You can check in the change to bzr and apply it to staging. Greg Shah
03:27 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The modified versions of the ChuiSimulator.java and SwingHelper.java have been uploaded for review. Eugenie Lyzenko
11:46 AM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Prepare the update zip file and attach it to this issue's history. I will then do a final code review and let you know. Greg Shah
11:22 AM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
OK. What about changes testing and uploading?
The code involved in the change does not affect the usual client beh...
Eugenie Lyzenko
07:42 AM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Go with your 2nd approach:... Greg Shah
05:05 PM Feature #1884: add some of the v10 data types and core built-ins
This is a list of static fields/methods that should be moved from the character class to the new TextOps class.
*_...
Adrian Lungu
11:36 AM Feature #1921: implement super-procedures
Would you please show an example of both SEARCH-SELF and SEARCH-TARGET? Greg Shah
10:01 AM Feature #1921: implement super-procedures
SUPER-PROCEDURES attribute:
- contains the string representation of the super procedure stack
- the top of the stac...
Constantin Asofiei
05:30 AM Feature #1921: implement super-procedures
Just a note, I think we do probably have dynamic calls, even though the SUPER-PROCEDURE stack is effectively static. ... Guy M
10:27 AM Feature #1920: implement persistent procedures
Agreed. Greg Shah
10:26 AM Feature #1920: implement persistent procedures
The next steps for this task (and super-procedures) are:
1a. provide conversion support for all related 4GL features...
Constantin Asofiei

11/16/2012

06:25 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Your change is not enough to get the ChUI client working. Consider the constructor of the ChuiSimulator class. The ge... Eugenie Lyzenko
05:21 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
OK, this is close. But it seems that the real problem is just with our isMonospaced() implementation. In other word... Greg Shah
04:31 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
More investigation.
Looks like the reason for screen corruption in Windows monospaced has been found. The CHUI out...
Eugenie Lyzenko
07:35 AM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The debugging results:
1. The SwingHelper.getMonoFontList() and SwingHelper.isMonospaced() are seems to work fine....
Eugenie Lyzenko
02:38 PM Feature #1884: add some of the v10 data types and core built-ins
I recreated the longchar class as a subclass of character and added only the constructors.
I created the new class ...
Adrian Lungu
07:50 AM Feature #1591: implement QUOTER built-in function
After more tests it seems that in fact quoter uses a fixed format for date not the format it is defined with:... Costin Savin
07:09 AM Feature #1590: implement PROPATH assignment
Runtime regression testing has passed. The update was applied to staging (without the testcase), staging P2J was rebu... Constantin Asofiei

11/15/2012

04:58 PM Feature #1884: add some of the v10 data types and core built-ins
Go forward with this approach:
1. Make longchar a subclass of character. Override only as minimally necessary. I...
Greg Shah
02:11 PM Feature #1884: add some of the v10 data types and core built-ins
I admit that a new longchar class with a lot of duplicated methods is not a solution but I went on this route to have... Adrian Lungu
02:03 PM Feature #1591: implement QUOTER built-in function
Make sure you test each data type with explicit format strings that are different from the default.
Example, try "...
Greg Shah
01:29 PM Feature #1591: implement QUOTER built-in function
Good point. In this case, it is probably best to call a variant of quoter(). Perhaps it should be named quoterForma... Greg Shah
01:23 PM Feature #1591: implement QUOTER built-in function
That may pose some problems since quoter can also be called with 2 or 3 parameters (custom unknown replacement and cu... Costin Savin
01:02 PM Feature #1591: implement QUOTER built-in function
This means that during conversion, you must emit any non-default format string for the variable into the quoter() cal... Greg Shah
11:49 AM Feature #1591: implement QUOTER built-in function
This seems to be only reproducible for quoter... Costin Savin
11:11 AM Feature #1591: implement QUOTER built-in function
Please provide a small sample here that shows the problem. Please note that when you say "string equivalent of the d... Greg Shah
10:11 AM Feature #1591: implement QUOTER built-in function
There seems to be a problem for date variables
Assuming we have the following variable:...
Costin Savin
01:04 PM Feature #1920: implement persistent procedures
OK, that all makes sense. Greg Shah
12:49 PM Feature #1920: implement persistent procedures
> IF this behavior was associated with widgets/frames, we would want to replace the referent with a dynamic proxy (in... Constantin Asofiei
08:52 AM Feature #1920: implement persistent procedures
... Greg Shah
08:27 AM Feature #1920: implement persistent procedures
For #1920-11 - I've added the comment to #1921, please update there all info about super procedures. Constantin Asofiei
07:11 AM Feature #1920: implement persistent procedures
Hi Greg,
Thanks for adding me in- that is interesting, but what a nightmare!
Why did Progress have to come up w...
Guy M
03:53 AM Feature #1920: implement persistent procedures
Answers for entry #1920-8
> Yes. The behavior also suggests that there may be an additional state of "deleted". Un...
Constantin Asofiei
02:43 AM Feature #1920: implement persistent procedures
Answers for #1920-7
> If I understand correctly, calls to these entry points are all done indirectly (e.g. RUN x IN ...
Constantin Asofiei
12:37 PM Feature #1590: implement PROPATH assignment
Regression testing is running in a staging copy. If it passes, I'll apply the update to staging. Constantin Asofiei
11:09 AM Feature #1590: implement PROPATH assignment
The proposed update looks good. Please work with Constantin to get runtime regression testing done on lightning stag... Greg Shah
05:17 AM Feature #1590: implement PROPATH assignment
Added proposed update. Done regression tests - resulting sources are identical. Costin Savin
08:59 AM Feature #1921: implement super-procedures
Agreed. See #1922. Greg Shah
08:36 AM Feature #1921: implement super-procedures
If we can somehow use hints to hard code the super procedure hierarchy and, during conversion, extract the entire hie... Constantin Asofiei
08:26 AM Feature #1921: implement super-procedures
Hi Greg,
Thanks for adding me in- that is interesting, but what a nightmare!
Why did Progress have to come up w...
Constantin Asofiei

11/14/2012

03:38 PM Feature #1920: implement persistent procedures
Some thoughts on the implementation:... Greg Shah
02:52 PM Feature #1920: implement persistent procedures
Some thoughts on the 4GL behavior:... Greg Shah
09:40 AM Feature #1920: implement persistent procedures
A. Implementation problems:
1. still need to find out how the exposed TRIGGERs work in 4GL, but I'll leave this last...
Constantin Asofiei
09:40 AM Feature #1920: implement persistent procedures
0. a procedure handle will expose public internal procedures, functions and also triggers.
1. the standard procedu...
Constantin Asofiei
02:29 PM Feature #1590: implement PROPATH assignment
Only the build has failed. Check the build.xml to see the amount of memory needed for the compile target. Change th... Greg Shah
02:15 PM Feature #1590: implement PROPATH assignment
I made the changes and ran the regression tests however I got a message at the end that Error occurred during initia... Costin Savin
09:09 AM Feature #1590: implement PROPATH assignment
This sounds like a good approach.
Costin: please make the changes to EnvironmentOps and to Preprocessor.evaluate()...
Greg Shah
04:59 AM Feature #1590: implement PROPATH assignment
MAJIC conversion fails because cases like this:... Constantin Asofiei
01:38 PM Feature #1884: add some of the v10 data types and core built-ins
1. We don't want to duplicate code. BUT
2. We need to limit the operators, built-in functions and so forth as neede...
Greg Shah
12:42 PM Feature #1884: add some of the v10 data types and core built-ins
In order to go further with implementing the LONGCHAR data type I created the longchar class as a copy of the charact... Adrian Lungu

11/13/2012

06:34 PM Feature #1884: add some of the v10 data types and core built-ins
I reviewed the 4gl operator functions and procedures implemented by the character class and also the ones taking LONC... Adrian Lungu
01:55 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
Applied to staging and checked in Bazaar. Eugenie Lyzenko
01:29 PM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The update has been repackaged. Also it includes the directory.xml.win and directory.xml.linux files for both systems... Eugenie Lyzenko
11:56 AM Support #1700: test the startup, basic processing and shutdown of the P2J server and P2J client o...
The only change needed is to re-zip the update without the p2j/ prefix. Zip everything from inside the p2j/ director... Greg Shah
11:27 AM Feature #1590: implement PROPATH assignment
Looks good.
The next step is to get it fully regression tested. This change affects both conversion and runtime, ...
Greg Shah
10:52 AM Feature #1590: implement PROPATH assignment
Added revised update,
1. Corrected the Javadoc , hopefully I done most of the code formatting mistakes to remember t...
Costin Savin
09:48 AM Feature #1590: implement PROPATH assignment
Feedback:
1. Please see the JavaDoc section of the doc.html section of the coding standards. Your EnvironmentOps....
Greg Shah
09:27 AM Feature #1920: implement persistent procedures
Agreed. You mean that the handle.isValid() should be overridden in phandle? Greg Shah
08:11 AM Feature #1920: implement persistent procedures
I think the VALID-HANDLE function should be implemented too (it checks if a handle is valid), because after a DELETE ... Constantin Asofiei
 

Also available in: Atom