FWD » Core Development » Base Language

11/15/2013

01:53 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > When a resource is deleted (by all means) is its instance metho... Hynek Cihlar

01:45 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Hynek Cihlar wrote:
> When a resource is deleted (by all means) is its instance method Deletable.delete always calle... Constantin Asofiei

01:37 PM Bug #2183: fix resource save/restoration when used with string/handle functions

> > What is the boundary for the resource lifetime in this case? In other words, when should the fromString() return ... Hynek Cihlar

01:09 PM Bug #2183: fix resource save/restoration when used with string/handle functions

> What is the boundary for the resource lifetime in this case? In other words, when should the fromString() return an... Constantin Asofiei

12:48 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Greg Shah wrote:
> Code Review 1115a
>
> 1. The explicit classes imported in handle.java should be imported with ... Hynek Cihlar

12:47 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Constantin Asofiei wrote:
> Are you sure that @WeakReference@ is the way to go? What about this scenario:
> # user ... Hynek Cihlar

12:26 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Code Review 1115a
1. The explicit classes imported in handle.java should be imported with the wildcard.
2. hand... Greg Shah

11:31 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Are you sure that @WeakReference@ is the way to go? What about this scenario:
# user creates a resource and saves it... Constantin Asofiei

11:22 AM Bug #2183: fix resource save/restoration when used with string/handle functions

See the attached hc_upd20131115a.zip with the latest code version. It contains changes and fixes from the previous co... Hynek Cihlar

08:37 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Please document the current status and upload the latest version for code review. Greg Shah

01:35 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Added tests related to implicit resource deletion and @INSTANTIATING-PROCEDURE@ attribute. Constantin Asofiei

01:21 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

This update contains the following:
# more changes related to DYNAMIC attribute (to mark the resource as dynamic or ... Constantin Asofiei

12:20 PM Feature #1641: implement SAX XML support

> I don't see any validation of the source parameter in the set-input-source or additional validation of the input so... Evgeny Kiselev

11/14/2013

12:55 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

OK, I'll try this too, as it will save lots of round-trips to the client. At this time, it works using a @FrameConfig... Constantin Asofiei

12:11 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Perhaps we should just sync the flag. I assume that would fix the case 1 issue? It would also solve some number of ... Greg Shah

11:50 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> If you can fix the pause-before-end issue quickly, include it with this task.
I think I have a f... Constantin Asofiei

10:33 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

If you can fix the pause-before-end issue quickly, include it with this task.
I am OK for you to open a new Bug fo... Greg Shah

10:24 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

My changes in static frame deletion somehow ended up digging some other problems:
# the pause-before-end behaviour: ... Constantin Asofiei

07:30 AM Feature #1634: implement full native library (.so or DLL) support

Some Calling Convention Findings
STDCALL is really the default calling convention on 32-bit Windows (whether run in ... Greg Shah

06:28 AM Feature #1634: implement full native library (.so or DLL) support

Polymorphic Types
> And another one: I wonder how _POLY cases behave in this case... will a _POLY still get automa... Greg Shah

06:06 AM Feature #1634: implement full native library (.so or DLL) support

Inbound Checking Findings
The use of "inbound" means on the inbound "side" of the API call. In other words these ar... Greg Shah

11/13/2013

03:09 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> 1. Missing history entry in RecordBuffer and TemporaryBuffer.
> 2. Some methods are missing java... Constantin Asofiei

01:38 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Code Review 1113c
I like the results very much. Some minor issues:
1. Missing history entry in RecordBuffer an... Greg Shah

10:31 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

It took a while, but I have a good version. In the end, I had these two notifications and @INSTANTIATING-PROCEDURE@ s... Constantin Asofiei

11/08/2013

12:58 PM Feature #1634: implement full native library (.so or DLL) support

The 64-bit Windows Openedge 11.3.1 installation has now been tested and it basically works as expected. The 64-bit c... Greg Shah

11:21 AM Feature #1634: implement full native library (.so or DLL) support

Function Pointer Lookup
Once the library is successfully loaded, a pointer to the function that is to be called must... Greg Shah

11/07/2013

04:30 PM Feature #1634: implement full native library (.so or DLL) support

Loading/Unloading Additional Findings
# On Windows, you can load using no path, relative path or an absolute path (s... Greg Shah

11:08 AM Feature #1634: implement full native library (.so or DLL) support

I have now added many more tests. In addition, I have gotten all tests running in 32-bit OE 10.2B06 in both Windows ... Greg Shah

11/06/2013

03:46 AM Feature #1641: implement SAX XML support

> 2. Added special wrapper for File/Stream/memptr/longchar. In 4gl method @set-input-source@ is not important, first ... Constantin Asofiei

09:15 PM Feature #1641: implement SAX XML support

from note 55
1. Fixed
2. Added special wrapper for File/Stream/memptr/longchar. In 4gl method @set-input-source@ is... Evgeny Kiselev

11/02/2013

05:24 PM Bug #2183: fix resource save/restoration when used with string/handle functions

> > (1) "Zero" handles
>
> As a general rule, we always implement any language feature (documented or not) that ca... Hynek Cihlar

11/01/2013

07:32 AM Bug #2183: fix resource save/restoration when used with string/handle functions

> > (2) Resource ID deallocation
>
> Yes, we need to solve this for sure. Constantin is working on something rela... Constantin Asofiei

07:06 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Overall, this is very good work.
+Answers+
> (1) "Zero" handles
As a general rule, we always implement any l... Greg Shah

09:54 PM Bug #2183 (Review): fix resource save/restoration when used with string/handle functions

Attached are the changes to review. The changes passed regression tests.
The source code includes several TODO comme... Hynek Cihlar

10/31/2013

03:48 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> I suspect the buffer is actually referencing a record whose lock has been downgraded to share-loc... Constantin Asofiei

03:39 AM Feature #1641: implement SAX XML support

# @handle.isHandleTypeOf@
- please do not use an existing class name for variables/parameters. It is confusing. I'm ... Constantin Asofiei

10:01 PM Feature #1641 (WIP): implement SAX XML support

1) I have question about procedure handle:
- in handle I have @ExternalProgramWrapper@ where I can get real instance... Evgeny Kiselev

10/30/2013

12:41 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

> Thus, record locks do survive, and we can end up having access to buffer referencing an exclusively-locked record o... Greg Shah

12:35 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Again, something else I've missed. I've been checking handles for static widgets which were only included in a FORM s... Constantin Asofiei

12:14 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

> 1. In the persistent procedure case, do 4GL transactions (and buffer scopes/record locks) end at the end of the ext... Constantin Asofiei

11:41 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

More questions:
1. In the persistent procedure case, do 4GL transactions (and buffer scopes/record locks) end at t... Greg Shah

11:20 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

I missed a rule; the static resources also get deleted when the internal proc/function which created them ends (regar... Constantin Asofiei

09:59 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Does this mean that we just need to defer the processing of TransactionManager.popScope() for external procedures tha... Greg Shah

08:39 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Notes about implicit deletion:
* from widget cases, only BUTTON, BROWSE and FILL-IN were tested, but the rules should... Constantin Asofiei

10/29/2013

08:54 AM Feature #2196 (WIP): implement proper resource deletion of resources created in a procedure ran p...

Constantin Asofiei

03:35 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

From #2120 notes 60, 61, 62 - static queries are undeletable, but their handle can be deleted (and a subsequent HANDL... Constantin Asofiei

10/25/2013

06:04 AM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...

From #1612 notes 27 and 28:
Constantin Asofiei comment:
> remember the ErrorManager.recordOrShowError changes relat... Constantin Asofiei

06:02 AM Bug #2197 (Closed): fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-ST...

Constantin Asofiei

03:13 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

From #2120 notes 49 and 50:
Comment by Greg Shah:
> Do we need a new "hook" to handle the class unloading "event"... Constantin Asofiei

03:12 AM Feature #2196 (Closed): implement proper resource deletion of resources created in a procedure ra...

Constantin Asofiei

10/21/2013

03:51 AM Feature #1641: implement SAX XML support

Evgeny, following is my review. The main concerns are about abstracting the sax reading and writing, to not write cod... Constantin Asofiei

09:17 PM Feature #1641: implement SAX XML support

First drop for review:
1) SaxAttributes is close to finish version, there are some not important TODOs
2) SaxEntity... Evgeny Kiselev

10/20/2013

05:04 PM Bug #2183 (WIP): fix resource save/restoration when used with string/handle functions

Hynek Cihlar

02:06 PM Feature #2013: implement the SELF system handle

> Perhaps just the NullWidget stuff is open?
Yes, only the NullWidget usage remains to be removed. Constantin Asofiei

01:47 PM Feature #2013: implement the SELF system handle

What is left to do on this task? I think your recent work with async events/sockets probably filled most of the gaps... Greg Shah

01:40 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

The BUFFER-FIELD implementation of COLUMN-LABEL, DATA-TYPE, FORMAT and LABEL will be handled in other tasks that are ... Greg Shah

12:09 PM Feature #1781 (Closed): add missing support for the WIDGET-HANDLE builtin function

Greg Shah

10/18/2013

05:39 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Committed to p2j_repo as revision 10401. Hynek Cihlar

12:56 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Check it in and distribute it. Greg Shah

12:46 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Regression tests passed. Hynek Cihlar

02:01 PM Feature #1634: implement full native library (.so or DLL) support

Loading/Unloading
# No loading of a library occurs until a RUN statement is executed which matches a PROCEDURE EXT... Greg Shah

12:24 PM Feature #1634: implement full native library (.so or DLL) support

After a long effort of writing testcases, I have enough results to have sufficient understanding of how the native li... Greg Shah

08:52 AM Feature #1646 (Closed): implement BASE64-ENCODE/BASE64-DECODE built-in functions

Greg Shah

04:44 AM Feature #1641: implement SAX XML support

I think there is a good chance that the progress documentation is wrong; although the code passes, I couldn't find a ... Constantin Asofiei

10/17/2013

07:32 PM Feature #1641: implement SAX XML support

what means in documentation @A CHARACTER or LONGCHAR expression evaluating to the value of the attribute.@ for exampl... Evgeny Kiselev

05:32 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

I'm sorry, I forgot..
It passed regression testing. Vadim Gindin

02:12 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

What is the status of regression testing? (I know the answer but you were supposed to post it here so there is docum... Greg Shah

01:32 PM Feature #1646: implement BASE64-ENCODE/BASE64-DECODE built-in functions

committed to bzr. Revision 10399. Vadim Gindin

05:04 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Yes, I forgot to mention that the regression test is in progress. Hynek Cihlar

05:02 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

It looks good. Please conversion regression test this. Greg Shah

04:52 PM Feature #1781: add missing support for the WIDGET-HANDLE builtin function

Built-in functions ordered alphabetically, see the attached hc_upd20131017a.zip. Hynek Cihlar

02:36 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Committed to bzr as 10400. Eugenie Lyzenko

02:14 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

Go ahead. Greg Shah

01:54 PM Feature #2074: add CAN-QUERY() and CAN-SET() support

> Runtime testing is enough.
The runtime testing has been passed. The results can be found at 10398_4e69e3d_201310... Eugenie Lyzenko