FWD » Core Development » Base Language

12/02/2013

03:08 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Hynek Cihlar wrote:
> > # in the end, each resource contains its own support for ADM-DATA and UNIQUE-ID (I mean, the... Constantin Asofiei

12/01/2013

06:41 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Constantin Asofiei wrote:
> # @XEntityImpl.getName and XEntityImpl.setName@ - this is a question for Evgeny: is the @... Evgeny Kiselev

02:00 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

GenericWidget columnLabel setter/getter should call handle.invalidAttribute not just throw an exception (see note-5).... Hynek Cihlar

01:44 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Buffer resource is not mentioned but is also missing implementations for adm-data, unique-id, namespace-uri and buffe... Hynek Cihlar

12:08 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

SOAPHeaderEntryImpl is heavily unimplemented. Still implement those local-name and namespace-uri attributes mentioned... Hynek Cihlar

11:27 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Constantin Asofiei wrote:
> Hynek, some notes:
> # SAX resource is WIP by Evgeny (and I expect all attrs/methods to... Hynek Cihlar

11/30/2013

05:51 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

Hynek, some notes:
# SAX resource is WIP by Evgeny (and I expect all attrs/methods to be implemented, including ADM-... Constantin Asofiei

04:50 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed

I have summarized the state of all attributes and what needs to be done. Please review the attached Calc sheet.
Al... Hynek Cihlar

04:45 PM Feature #2041 (WIP): implement runtime support for "shared" attributes that are just stubbed

Hynek Cihlar

10:23 AM Feature #1641: implement SAX XML support

Review for 1129a.zip; I like how you handled the callbacks in @XMLCallbackWrapper@ and how @SaxReaderImpl@ code looks... Constantin Asofiei

08:22 PM Feature #1641: implement SAX XML support

new drop for review:
1) Finishing with callback handler wrapper
2) added DTD and schema validation in SaxReader
3)... Evgeny Kiselev

11/26/2013

06:42 PM Feature #1641: implement SAX XML support

Greg Shah wrote:
> How much more time do you estimate that you will need to complete this work?
I've finishing with... Evgeny Kiselev

11:39 AM Feature #1641: implement SAX XML support

How much more time do you estimate that you will need to complete this work? Greg Shah

09:03 AM Feature #1634: implement full native library (.so or DLL) support

Greg Shah wrote:
> I will go ahead and return 'O' instead of 'R' for getParameterModes().
OK. This will allow Cont... Constantin Asofiei

08:49 AM Feature #1634: implement full native library (.so or DLL) support

I will go ahead and return 'O' instead of 'R' for getParameterModes().
The mode checking for native API calls is d... Greg Shah

01:25 AM Feature #1634: implement full native library (.so or DLL) support

Greg Shah wrote:
> > BTW, the native invocation code I think looks better in a distinct class; NativeProcedureCaller... Constantin Asofiei

08:41 AM Bug #2183 (Closed): fix resource save/restoration when used with string/handle functions

Greg Shah

05:32 AM Bug #2183: fix resource save/restoration when used with string/handle functions

The code (hc_upd20131118a.zip) passed regression tests (the run 20131116) and was committed as revision 10416. Hynek Cihlar

11/25/2013

05:14 PM Feature #1634: implement full native library (.so or DLL) support

> BTW, the native invocation code I think looks better in a distinct class; NativeProcedureCaller.invoke should deleg... Greg Shah

09:17 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

The 4GL process launching requires a controlling terminal or pty. For instance, the programs that are launched from ... Greg Shah

09:00 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

> Greg/Eugenie: if the client is ran in a non-TTY mode, the process launching will not work. Is this by intent?
Ye... Eugenie Lyzenko

03:17 AM Feature #1650: process launching support for Windows (JNI library changes and any associated modi...

Greg/Eugenie: if the client is ran in a non-TTY mode, the process launching will not work. Is this by intent? I think... Constantin Asofiei

11/24/2013

11:50 AM Feature #1634: implement full native library (.so or DLL) support

Greg Shah wrote:
> Question: what does the NativeProcedureCaller.invoke() return value mean/what is it used for? It... Constantin Asofiei

11:42 AM Feature #1634: implement full native library (.so or DLL) support

Question: what does the NativeProcedureCaller.invoke() return value mean/what is it used for? It is not clear from t... Greg Shah

11/22/2013

04:20 PM Feature #1634: implement full native library (.so or DLL) support

Misc Notes
The 4GL doesn't use native language header files or other definitions. No common OS platforms provide ... Greg Shah

04:10 PM Feature #1634: implement full native library (.so or DLL) support

As mentioned before, EXTENT parameters are always passed as a pointer. One cannot pass an extent var of indeterminat... Greg Shah

03:59 PM Feature #1634: implement full native library (.so or DLL) support

RETURN Parameter Additional Notes
The definition of a RETURN parameter can be placed as the 1st parameter definiti... Greg Shah

02:22 PM Feature #1634: implement full native library (.so or DLL) support

Outbound Checking Findings
The use of "outbound" means on the outbound "side" of the API call. In other words these ... Greg Shah

12:12 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> We can partially mitigate this (for the body of the message) by only setting the context during t... Constantin Asofiei

11:06 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

We can partially mitigate this (for the body of the message) by only setting the context during the state sync proces... Greg Shah

10:25 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> What are the implications for setting context permanently for the reader/writer threads on DIRECT... Constantin Asofiei

10:13 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

OK, then let's get the context set properly instead of reworking all of this code.
What are the implications for s... Greg Shah

10:11 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Yes, I agree with you, but that is not enough. To make all call-paths reachable from the frame deletion code independ... Constantin Asofiei

09:49 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

My point is that the applyChanges() method is already running in the proper instance because that instance is what is... Greg Shah

09:42 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> Isn't the @this@ reference in LogicalTerminal.applyChanges() the same as the instance returned by... Constantin Asofiei

09:41 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

> this will need the context-local LogicalTerminal instance (obtained via LogicalTerminal.locate()) to destroy the fr... Greg Shah

11:42 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

> What is there in the visible flag case that requires the context?
The problem is that a frame (for which its insta... Constantin Asofiei

09:42 AM Feature #1641: implement SAX XML support

If there is no difference in the versions, use the one that is Apache licensed. Greg Shah

06:17 AM Feature #1641: implement SAX XML support

Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > Unfortunately we need to add woodstox StAX api. Because JDK S... Evgeny Kiselev

05:22 AM Feature #1641: implement SAX XML support

Evgeny Kiselev wrote:
> Unfortunately we need to add woodstox StAX api. Because JDK StAX api is not support any vali... Constantin Asofiei

05:12 AM Feature #1641: implement SAX XML support

Unfortunately we need to add woodstox StAX api. Because JDK StAX api is not support any validation (DTD and schemas).... Evgeny Kiselev

11/21/2013

02:16 PM Bug #1971: emit worker versions for functions to fix source-procedure handle

I am OK with the changes. Greg Shah

01:53 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Generally speaking, to increase security, it is a good practice to limit the use of credentials (e.g. security contex... Greg Shah

09:14 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

LE: the queue may be multiplexed, thus the reason... I think we need to do something similar to how Dispatcher.proces... Constantin Asofiei

09:12 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg, is there a specific reason the Reader/Writer threads don't have a security context set? I ask this because some... Constantin Asofiei

11/20/2013

11:27 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> 1. The addition of a BLOCK node as a prior sibling to CS_INSTANCE_VARS in the templates, seems a ... Constantin Asofiei

09:36 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Hynek Cihlar wrote:
> ... I am attaching the latest changes with the fixed RemoteResource/RemoteResourceImpl/Agent, ... Constantin Asofiei

09:26 AM Bug #1971: emit worker versions for functions to fix source-procedure handle

See attached. Constantin Asofiei

11/19/2013

04:19 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Yesterday's regression test run ended with suspiciously high number of errors. I've started another control run. Mean... Hynek Cihlar

11/18/2013

06:27 PM Feature #1641: implement SAX XML support

>OK, I understand now. What StAX implementation will you be using?
I'm using standard implementation in JDK.
http:... Evgeny Kiselev

02:52 AM Feature #1641: implement SAX XML support

Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> So Idea is parse tag by tag. Java SAX API cannot parse tag by t... Constantin Asofiei

11:47 AM Bug #1971: emit worker versions for functions to fix source-procedure handle

There was no update attached. Greg Shah

11:26 AM Bug #1968: implement MAP TO actual-name IN handle clause for function definitions

I'm fine with the 1116c changes. There is a minor formatting problem in SourceNameMapper (blank line missing before ... Greg Shah

11:21 AM Feature #1972 (Closed): provide full-support for DYNAMIC-FUNCTION set to function parameters

Greg Shah

10:54 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Code Review 1116e
I am OK with the changes. I do have some questions:
1. The addition of a BLOCK node as a pri... Greg Shah

09:30 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Constantin Asofiei wrote:
> Hynek, the RemoteResource/RemoteResourceImpl/Agent changes are incorrect. The @RemoteRes... Hynek Cihlar

02:30 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Hynek, the RemoteResource/RemoteResourceImpl/Agent changes are incorrect. The @RemoteResource@ interface is used to s... Constantin Asofiei

03:01 AM Feature #2138 (WIP): finish SEARCH-TARGET support

Constantin Asofiei

11/17/2013

06:20 PM Feature #1641: implement SAX XML support

Constantin Asofiei wrote:
> > 2) ProcDefaultHandler is specify in update, but I've found that java SAX API is not co... Evgeny Kiselev

04:28 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Attached is the release candidate.
* I reverted the weak references introduced in hc_upd20131115a.zip, deallocati... Hynek Cihlar

11/16/2013

02:33 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Attached update fixes the @buffer_name_conflicts.rules@ problem and some other regressions found during testing. The ... Constantin Asofiei

02:02 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

My buffer scoping changes exposed some incorrect usage of the @DictionaryWorker@. Currently, the @DictionaryWorker@ u... Constantin Asofiei

02:08 PM Bug #1971 (WIP): emit worker versions for functions to fix source-procedure handle

Attached update fixes the SOURCE and TARGET procedure push for java-style function calls. Built on top of the #1968 u... Constantin Asofiei

04:44 AM Feature #1972 (Feedback): provide full-support for DYNAMIC-FUNCTION set to function parameters

This is fixed by #2068. Can be closed. Constantin Asofiei

03:45 AM Bug #1968 (WIP): implement MAP TO actual-name IN handle clause for function definitions

Adds support for the @FUNCTION ... MAP TO@ case. The rule is that the search is done recursively, until it finds it o... Constantin Asofiei

02:32 AM Feature #1641: implement SAX XML support

> 2) ProcDefaultHandler is specify in update, but I've found that java SAX API is not correct. Here like SAX-WRITER w... Constantin Asofiei

11/15/2013

01:53 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > When a resource is deleted (by all means) is its instance metho... Hynek Cihlar

01:45 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Hynek Cihlar wrote:
> When a resource is deleted (by all means) is its instance method Deletable.delete always calle... Constantin Asofiei

01:37 PM Bug #2183: fix resource save/restoration when used with string/handle functions

> > What is the boundary for the resource lifetime in this case? In other words, when should the fromString() return ... Hynek Cihlar

01:09 PM Bug #2183: fix resource save/restoration when used with string/handle functions

> What is the boundary for the resource lifetime in this case? In other words, when should the fromString() return an... Constantin Asofiei

12:48 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Greg Shah wrote:
> Code Review 1115a
>
> 1. The explicit classes imported in handle.java should be imported with ... Hynek Cihlar

12:47 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Constantin Asofiei wrote:
> Are you sure that @WeakReference@ is the way to go? What about this scenario:
> # user ... Hynek Cihlar

12:26 PM Bug #2183: fix resource save/restoration when used with string/handle functions

Code Review 1115a
1. The explicit classes imported in handle.java should be imported with the wildcard.
2. hand... Greg Shah

11:31 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Are you sure that @WeakReference@ is the way to go? What about this scenario:
# user creates a resource and saves it... Constantin Asofiei

11:22 AM Bug #2183: fix resource save/restoration when used with string/handle functions

See the attached hc_upd20131115a.zip with the latest code version. It contains changes and fixes from the previous co... Hynek Cihlar

08:37 AM Bug #2183: fix resource save/restoration when used with string/handle functions

Please document the current status and upload the latest version for code review. Greg Shah

01:35 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Added tests related to implicit resource deletion and @INSTANTIATING-PROCEDURE@ attribute. Constantin Asofiei

01:21 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

This update contains the following:
# more changes related to DYNAMIC attribute (to mark the resource as dynamic or ... Constantin Asofiei

12:20 PM Feature #1641: implement SAX XML support

> I don't see any validation of the source parameter in the set-input-source or additional validation of the input so... Evgeny Kiselev

11/14/2013

12:55 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

OK, I'll try this too, as it will save lots of round-trips to the client. At this time, it works using a @FrameConfig... Constantin Asofiei

12:11 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Perhaps we should just sync the flag. I assume that would fix the case 1 issue? It would also solve some number of ... Greg Shah

11:50 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> If you can fix the pause-before-end issue quickly, include it with this task.
I think I have a f... Constantin Asofiei

10:33 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

If you can fix the pause-before-end issue quickly, include it with this task.
I am OK for you to open a new Bug fo... Greg Shah

10:24 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

My changes in static frame deletion somehow ended up digging some other problems:
# the pause-before-end behaviour: ... Constantin Asofiei

07:30 AM Feature #1634: implement full native library (.so or DLL) support

Some Calling Convention Findings
STDCALL is really the default calling convention on 32-bit Windows (whether run in ... Greg Shah

06:28 AM Feature #1634: implement full native library (.so or DLL) support

Polymorphic Types
> And another one: I wonder how _POLY cases behave in this case... will a _POLY still get automa... Greg Shah

06:06 AM Feature #1634: implement full native library (.so or DLL) support

Inbound Checking Findings
The use of "inbound" means on the inbound "side" of the API call. In other words these ar... Greg Shah

11/13/2013

03:09 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Greg Shah wrote:
> 1. Missing history entry in RecordBuffer and TemporaryBuffer.
> 2. Some methods are missing java... Constantin Asofiei

01:38 PM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

Code Review 1113c
I like the results very much. Some minor issues:
1. Missing history entry in RecordBuffer an... Greg Shah

10:31 AM Feature #2196: implement proper resource deletion of resources created in a procedure ran persistent

It took a while, but I have a good version. In the end, I had these two notifications and @INSTANTIATING-PROCEDURE@ s... Constantin Asofiei

11/08/2013

12:58 PM Feature #1634: implement full native library (.so or DLL) support

The 64-bit Windows Openedge 11.3.1 installation has now been tested and it basically works as expected. The 64-bit c... Greg Shah

11:21 AM Feature #1634: implement full native library (.so or DLL) support

Function Pointer Lookup
Once the library is successfully loaded, a pointer to the function that is to be called must... Greg Shah

11/07/2013

04:30 PM Feature #1634: implement full native library (.so or DLL) support

Loading/Unloading Additional Findings
# On Windows, you can load using no path, relative path or an absolute path (s... Greg Shah

11:08 AM Feature #1634: implement full native library (.so or DLL) support

I have now added many more tests. In addition, I have gotten all tests running in 32-bit OE 10.2B06 in both Windows ... Greg Shah

11/06/2013

03:46 AM Feature #1641: implement SAX XML support

> 2. Added special wrapper for File/Stream/memptr/longchar. In 4gl method @set-input-source@ is not important, first ... Constantin Asofiei

09:15 PM Feature #1641: implement SAX XML support

from note 55
1. Fixed
2. Added special wrapper for File/Stream/memptr/longchar. In 4gl method @set-input-source@ is... Evgeny Kiselev