Activity
From 12/18/2013 to 01/16/2014
01/16/2014
- 03:12 PM Feature #1634: implement full native library (.so or DLL) support
- Greg Shah wrote:
> Constantin: What is the easiest way to determine if a given BDT[] instance is an indeterminate le... - 02:33 PM Feature #1634: implement full native library (.so or DLL) support
- Constantin: What is the easiest way to determine if a given BDT[] instance is an indeterminate length array? I have ...
- 10:50 AM Bug #1969 (Closed): buffer names in get-signature
- 10:36 AM Bug #1969: buffer names in get-signature
- Committed to bzr revision 10440.
- 10:06 AM Bug #1969: buffer names in get-signature
- > I think you missed something in the SchemaDictionary change:
You're right, I missed that. Sorry.
I'm fine wi... - 10:03 AM Bug #1969: buffer names in get-signature
- Greg Shah wrote:
> 1. The SchemaDictionary lowercases the name before it saves off the legacy_name annotation, but s... - 09:25 AM Bug #1969: buffer names in get-signature
- Code Review 0115a
1. The SchemaDictionary lowercases the name before it saves off the legacy_name annotation, but ... - 08:43 AM Bug #1969 (Review): buffer names in get-signature
- PS: conversion testing has passed, runtime testing is not needed.
- 08:43 AM Bug #1969 (WIP): buffer names in get-signature
- Attached update fixes the BUFFER and TABLE parameter names reported by GET-SIGNATURE.
The legacy, case-sensitive n... - 07:19 AM Feature #1645: implement web services support
- Committed to bzr revision 10439.
- 06:42 AM Feature #1645: implement web services support
- Code Review 0116a
I am fine with the changes. Go ahead and check it in.
Evgeny: I still want you to review t... - 03:27 AM Feature #1645: implement web services support
- and the update...
- 03:26 AM Feature #1645: implement web services support
- main part of runtime testing has passed. need to double check the CTRL-C part.
Attached version is merged with rev... - 06:55 AM Feature #1641: implement SAX XML support
- Please check in your SAX testcases.
- 07:39 PM Feature #1641: implement SAX XML support
- Committed to bzr revision 10438.
01/15/2014
- 01:53 AM Feature #1641: implement SAX XML support
- Review for 0113a.zip: the update is OK, but please make the @XCommonImpl.isValid@ field protected instead of package-...
- 08:40 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
> Review for 0112a.zip:
> * all files are missing history entries. When you add history e...
01/13/2014
- 05:04 PM Bug #2197: fix the error message list cleanup when NO-ERROR mode is enabled and ERROR-STATUS:ERRO...
- Start by writing cases to investigate this behavior, then propose a solution.
- 08:26 AM Feature #1608: implement full appserver support (from 4GL clients only)
- 0110e.zip was committed to bzr rev 10434.
- 08:23 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Check it in and distribute.
- 02:42 AM Feature #1608: implement full appserver support (from 4GL clients only)
- 0110e.zip has passed runtime testing.
- 02:59 AM Feature #1641: implement SAX XML support
- Review for 0112a.zip:
* all files are missing history entries. When you add history entries, don't forget to update ... - 08:59 PM Feature #1641: implement SAX XML support
- added correct @DELETE@ operation for DOM/SAX.
01/10/2014
- 10:32 AM Feature #1645: implement web services support
- Greg, I'm fine with how the runtime works with my testing. I'll put this through regression testing once I'm done wit...
- 09:38 AM Feature #1645: implement web services support
- OK, finish your own testing AND take into account any feedback from Evgeny from his code review of WebServiceHelper.i...
- 09:13 AM Feature #1645: implement web services support
- Added the TODO.
Evgeny: when you find some time, please take a look into WebServiceHelper.invoke, the core code fo... - 08:47 AM Feature #1645: implement web services support
- I have no problem deferring this work. Please add comments to the javadoc to explain that the work is a TODO and the...
- 08:45 AM Feature #1645: implement web services support
- Greg, all of these are not used by the server code. Also, the gain vs cost of implementing them I don't think is wort...
- 08:38 AM Feature #1645: implement web services support
- Everything looks good. My only question is related to this (and the related commented-out code):...
- 07:41 AM Feature #1645: implement web services support
- Greg Shah wrote:
> 2. How safe is the use of IllegalArgumentException in SOAPHeaderImpl.getHeaderNode()/setHeaderNod... - 10:30 AM Feature #1608: implement full appserver support (from 4GL clients only)
- Attached contains 0109c.zip (with a change in LogicalTerminal too, as TransactionManager no longer needs to be cached...
- 09:00 AM Feature #2225: implement ssl and async realted connection options for web services
- The @-maxConnections@, @-connectionLifetime@, @-nosessionreuse@ and @-nohostverify@ options are not yet implemented b...
- 08:57 AM Feature #2225 (New): implement ssl and async realted connection options for web services
01/09/2014
- 04:34 PM Feature #1645: implement web services support
- Code Review 0109d
1. SOAPFactory.throwError() needs javadoc.
2. How safe is the use of IllegalArgumentException... - 03:09 PM Feature #1645: implement web services support
- Attached update adds:
# runtime implementation for legacy SOAP Header, Header Entry, Fault and Fault Detail resource... - 03:54 PM Feature #1608: implement full appserver support (from 4GL clients only)
- The changes look fine. Check them in when they pass testing.
- 02:57 PM Feature #1608: implement full appserver support (from 4GL clients only)
- Fixes a couple of problems in appserver agents:
# @ProcedureManager$WorkArea$scopeFinished@ was popping the target-p... - 03:09 PM Feature #2022 (Review): runtime support for web services
- 03:08 PM Feature #1995 (Review): runtime support for SOAP
- 03:05 PM Feature #1644: implement SOAP support
- All updates and discussions for this task was moved to #1645.
- 03:02 AM Feature #1641: implement SAX XML support
- Evgeny Kiselev wrote:
>After deleting X-DOCUMENT all nodes become uninitialized.
You've checked only the root X-N... - 07:50 PM Feature #1641: implement SAX XML support
- After deleting @X-DOCUMENT@ all nodes become uninitialized....
01/08/2014
- 08:36 AM Feature #1641: implement SAX XML support
- Evgeny, we missed something: deletion of the SAX and DOM/XML objects. How I've noticed this: the @XCommonImpl.resourc...
01/07/2014
- 06:46 PM Feature #1641: implement SAX XML support
- Greg Shah wrote:
> Please place them in testcases/uast/xml/dom/ and testcases/uast/xml/sax/ directories.
DOM testca... - 06:02 PM Feature #1641: implement SAX XML support
- Passed the regression testing. Committed at bzr revision 10428.
- 08:24 AM Feature #1641: implement SAX XML support
- I have no objections. We need to get this committed as soon as it passes regression testing.
> BTW, I can't find ... - 03:39 AM Feature #1641: implement SAX XML support
- Did this pass testing? If yes, then this is next on queue to be committed, unless Greg has any objections.
BTW, I ... - 07:41 PM Feature #1641: implement SAX XML support
- 1) merged with latest revision(removed SAX_ATTRIBUTES and SAX_READER from @IdKind@ enum, because all SAX objects are ...
- 06:01 PM Feature #1988 (Review): runtime support for SAX
- 06:00 PM Feature #1988 (WIP): runtime support for SAX
01/06/2014
- 05:46 PM Feature #2041 (Closed): implement runtime support for "shared" attributes that are just stubbed
- 05:09 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- The final change set attached. Committed at revision 10427.
- 07:49 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- OK, remove the @ProcedureManager.setInstantiatingProcedure@ (because is no longer used and it will just confuse reade...
- 07:44 AM Feature #2041 (Review): implement runtime support for "shared" attributes that are just stubbed
- 07:40 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Fixed and changes attached. Regression tests passed.
- 03:36 PM Feature #2184: create and populate the temp-table on the remote side, based on the received metad...
- This comes into play to dynamically create and/or populate an input temp-table (on the appserver side) or an output t...
- 03:16 PM Feature #1645: implement web services support
- Greg Shah wrote:
> Other than that, my only question is in ControlFlowOps.initializeProxy(), is there any way the Il... - 11:43 AM Feature #1645: implement web services support
- Code Review 1224a
I like the improved abstraction of some parts of the runtime (e.g. ServerHelper). It also seems... - 01:20 PM Feature #2208: create a java application running web services for testing purposes
- Some more notes: 4GL seems to alter the received SOAP Envelope by adding i.e. additional XMLNS attributes at the root...
- 10:13 AM Feature #1995 (WIP): runtime support for SOAP
- 07:42 AM Feature #1641: implement SAX XML support
- Review for 0104a.zip:
* SaxAttributesImpl.removeAttribute (both versions): javadoc for the parameters is not on dist...
01/05/2014
- 07:03 PM Feature #1645: implement web services support
- Constantin Asofiei wrote:
> LE: Nevermind, there is the @XmlHelper.write@ in P2J.
I've used for SAX writer:...
01/04/2014
- 04:44 PM Feature #1645: implement web services support
- LE: Nevermind, there is the @XmlHelper.write@ in P2J.
- 04:01 PM Feature #1645: implement web services support
- Evgeny: please help me a little with something related to @X-Noderef@ resources. Is there an existing way to serializ...
- 02:56 PM Feature #1641: implement SAX XML support
- fixed issues from note 90
- 12:45 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
> Review for 1231a.zip:
> # what are licences for the new jars?
under BSD license. It wa...
01/03/2014
- 07:10 AM Feature #2208: create a java application running web services for testing purposes
- Evgeny, please make it a priority to add basic services which work with SOAP Faults and SOAP Headers (response and re...
- 07:09 AM Feature #1644: implement SOAP support
- I've started working on finishing the SOAP Fault support (part of #1645). The SOAP Header support is highly dependent...
- 04:34 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- OK, the location is the right one, but you need to do it only if we are starting an external proc; also, remove the @...
- 04:15 AM Feature #1641: implement SAX XML support
- Review for 1231a.zip:
# what are licences for the new jars?...
01/01/2014
- 05:17 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Calling @ProcedureManager.setInstantiatingProcedure@ from the constructor of @ExternalProgramWrapper@ is too early, a...
- 08:02 PM Feature #1641: implement SAX XML support
- 1) added DTD validation with specific schema-paths
2) added XSD schema validation
3) added callback resolveEntity pro...
12/25/2013
- 07:33 PM Feature #1641: implement SAX XML support
- This update has passed regression.
But I have found that I forgot implementation of @NONAMESPACE-SCHEMA-LOCATION@ ...
12/24/2013
- 07:40 AM Feature #1645: implement web services support
- This version adds validation for the header callback proc/context and fixes the soap faults (though some more testing...
- 06:15 AM Feature #2215: implement the unwrapped mode of passing parameters to web service requests
- OpenEdge's unwrapped mode allows 4GL values and variables as arguments for a web service request; these are automatic...
- 06:01 AM Feature #2215 (New): implement the unwrapped mode of passing parameters to web service requests
12/23/2013
- 08:13 AM Feature #1645: implement web services support
- I've cleaned up and documented the code for the web services implementation. What major features are missing:
* fini... - 03:07 AM Feature #1641: implement SAX XML support
- Evgeny, the logic looks good, I don't have any other comments beside some formatting/javadoc issues and some left-beh...
- 08:07 PM Feature #1641: implement SAX XML support
- Constantin Asofiei wrote:
> Review for 1215a.zip:
> - MemptrInputStream.read - is it possible to save the mptr.leng... - 02:32 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- 1222a.zip looks good, go ahead and get it regression tested.
- 07:08 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Fixed the issues with the INSTANTIATING-PROCEDURE attribute. Also resolved an incoming conflict on the @BufferImpl.ge...
12/21/2013
- 03:31 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- 1220a.zip passed testing, was committed to bzr rev 10424.
12/20/2013
- 06:38 PM Feature #1645: implement web services support
- 1. Create new redmine tasks for the unwrapped mode and any error/fault processing that is not being implemented. Put...
- 02:36 PM Feature #1645: implement web services support
- The wrapped mode is working nicely, async mode is almost done too (only remaining feature is canceling the requests),...
- 09:21 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Code Review 1220a
I am fine with the changes. I think that these errors are really things that are generically ra... - 06:27 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- This version raises the "** Value too large for integer. (78)" if the given value can't be stored in a 64 bit integer...
- 06:38 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- PS: the @ProcedureManager.getInstantiatingProcedure(Object referent);@ will perform no validation, will return the ha...
- 06:37 AM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Review of 1219a.zip:
# I would prefer to have a @ProcedureManager.setInstantiatingProcedure(Object referent, handle i...
12/19/2013
- 05:41 PM Feature #2041: implement runtime support for "shared" attributes that are just stubbed
- Changes attached, please review. Regression test is pending.
- 02:44 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- AFAIK, the subtract is correct for the 2s complement, but the code is missing check for value greater than max unsign...
- 12:27 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- OK, one more question about the TWO_64 usage. In @ResourceIdHelper.idFromString@, you have this code (btw, shouldn't ...
- 11:59 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- True, I was looking at the other method. Please ignore the comment about throwing an exception when calling @handle.f...
- 10:02 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Hynek Cihlar wrote:
> Sorry, I didn't express myself clearly. With your change, when "-1" is passed to @handle.fromS... - 09:54 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin Asofiei wrote:
> > Also when you call @handle.fromString()@ with a negative number, an exception is throw... - 09:01 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Hynek Cihlar wrote:
> Constantin, I would remove the doc references about treating the long as unsigned number, now ... - 08:54 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin, I would remove the doc references about treating the long as unsigned number, now we use it as plain sign...
- 08:00 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Code Review 1219b
I am OK with the changes. If Hynek is OK with them, then go ahead with testing. - 02:40 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- This is 1218a.zip merged with latest rev. 1218a.zip passed, 1219a.zip was committed to bzr revision 10423.
1219b.z...
12/18/2013
- 05:16 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin Asofiei wrote:
> I should have caught this earlier. Why are negative resource ids ignored in @ResourceIdHe... - 05:04 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- Constantin Asofiei wrote:
> Fixed signatures of static proxy methods. Added logging to @RemoteObject.registerStaticN... - 03:20 PM Bug #2183: fix resource save/restoration when used with string/handle functions
- Code Review 1218a
The changes all look good.
The LT will need merging with the one just checked in by VIG.
I... - 08:20 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Fixed signatures of static proxy methods. Added logging to @RemoteObject.registerStaticNetworkServer@, to report any ...
- 06:22 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- I should have caught this earlier. Why are negative resource ids ignored in @ResourceIdHelper.idFromString@?...
- 04:50 AM Bug #2183: fix resource save/restoration when used with string/handle functions
- Some socket-related static proxy methods got bad after the 1118a.zip update, as some signatures are out-of-sync. I'm ...
Also available in: Atom