Project

General

Profile

Activity

From 09/09/2014 to 10/08/2014

10/07/2014

09:07 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review evk_upd20141003a.zip
1. The redirected terminal change now looks much safer.
2. Please describe the...
Greg Shah
08:26 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
merged with latest revision
fixed issue with box[]
In @Stream@ lazyNewLine now working only with put operation, EXP...
Evgeny Kiselev

09/30/2014

08:56 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
What is the status of your work on this task? Greg Shah

09/23/2014

09:02 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
In the redirected terminal output (see @RedirectedTerminal.sync()@), we are not supposed to generate output when:
...
Greg Shah

09/22/2014

08:54 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
I've found problem in calculating border for frame.
Border is calculating correct, but message will appear on the "b...
Evgeny Kiselev

09/19/2014

12:30 PM Bug #2338 (Closed): fix _MSG function
Greg Shah
10:35 AM Bug #2338: fix _MSG function
committed to revision 10614 Vadim Gindin
09:47 AM Bug #2338: fix _MSG function
Vadim Gindin wrote:
> The update vig_upd20140917a.zip has passed regression testing. Can I commit it?
Yes, go ahead...
Constantin Asofiei
06:04 AM Bug #2338: fix _MSG function
The update vig_upd20140917a.zip has passed regression testing. Can I commit it? Vadim Gindin

09/18/2014

12:49 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> Constantin Asofiei wrote:
> > update 0917
> for TerminalStream class you've rollback next ...
Constantin Asofiei
09:22 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Constantin Asofiei wrote:
> update 0917
for TerminalStream class you've rollback next lines:...
Evgeny Kiselev

09/17/2014

10:45 AM Bug #2338: fix _MSG function
Yes, I checked all tests. Here is the final update. Vadim Gindin
09:46 AM Bug #2338: fix _MSG function
Vadim Gindin wrote:
> This is a final update. Can I run regression testing?
If your standalone tests all pass (incl...
Constantin Asofiei
09:45 AM Bug #2338: fix _MSG function
This is a final update. Can I run regression testing? Vadim Gindin
04:10 AM Bug #2338: fix _MSG function
Vadim Gindin wrote:
> Added implementation for warnings to ErrorManager methods.
>
> Questions.
> 1. There are 2...
Constantin Asofiei
08:54 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
> do you think that adding a row at the bottom of the frame (when output to stream) might be something specific to 4G... Greg Shah
08:17 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny, this version is merged with the latest P2J. What else needs to be done:
# test all PUT versions (PUT ... AT/...
Constantin Asofiei
07:42 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> > 3. The @RedirectedTerminal@ change seems dangerous and incorrect. @box[i]@ will only be t...
Constantin Asofiei

09/15/2014

05:57 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Constantin Asofiei wrote:
> Evgeny Kiselev wrote:
> > P2J output with my patch:
> If you are referring to 0910a.zi...
Evgeny Kiselev
04:12 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> P2J output with my patch:
If you are referring to 0910a.zip, try to break it like this:
<p...
Constantin Asofiei
01:06 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Constantin Asofiei wrote:
> # about MESSAGE (and maybe other statements, like DISPLAY) when output is not the termin...
Evgeny Kiselev
04:39 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Constantin Asofiei wrote:
> # about the box issue:
> - is this a regression from your update or a bug you found?
>...
Evgeny Kiselev
08:19 AM Bug #2338: fix _MSG function
Added implementation for warnings to ErrorManager methods.
Questions.
1. There are 2 methods @ErrorManager.isSile...
Vadim Gindin

09/12/2014

12:54 PM Feature #2385 (Closed): implement environment access on GUI interfaces.
Greg Shah
10:54 AM Feature #2385: implement environment access on GUI interfaces.
0911c passed regression tests. Committed revision 10608. Marius Gligor

09/11/2014

02:07 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> testcases:
> uast/no_echo/put_unformatted_bug.p
> uast/no_echo/put_unformtted_bug1.p
# pl...
Constantin Asofiei
12:16 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
committed testcases into testcases/uast/no_echo
revision 1199.
testcases:
uast/no_echo/put_unformatted_bug.p
ua...
Evgeny Kiselev
07:23 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Evgeny Kiselev wrote:
> > What standalone testcases have you run to confirm your changes are correct?
I think Greg...
Constantin Asofiei
01:58 PM Feature #2385: implement environment access on GUI interfaces.
Code Review 0911c
The changes look good. Please get these runtime regression tested.
Greg Shah
01:39 PM Feature #2385: implement environment access on GUI interfaces.
OK. I understood thanks. Marius Gligor
01:37 PM Feature #2385: implement environment access on GUI interfaces.
In other words, when you call @DirectoryManager.getInstance()@ on the client, you will get a remote proxy to a server... Greg Shah
01:36 PM Feature #2385: implement environment access on GUI interfaces.
The @DirectoryServer@ class (which backs the @DirectoryManager.getInstance()@ on the server side) uses @Utils.getDire... Greg Shah
01:34 PM Feature #2385: implement environment access on GUI interfaces.
Marius Gligor wrote:
> Yes you are right it works in @/server/default/runtime/default/@
> But on note 12 you said:...
Constantin Asofiei
01:33 PM Feature #2385: implement environment access on GUI interfaces.
done. Marius Gligor
01:30 PM Feature #2385: implement environment access on GUI interfaces.
Yes you are right it works in @/server/default/runtime/default/@
But on note 12 you said: @The lookup should allow ...
Marius Gligor
01:24 PM Feature #2385: implement environment access on GUI interfaces.
I think you need to have it located in @/server/default/runtime/default/@ instead of @/server/default/@. Greg Shah
01:21 PM Feature #2385: implement environment access on GUI interfaces.
It works only for DirScope.ACCOUNTS Marius Gligor
01:17 PM Feature #2385: implement environment access on GUI interfaces.
I tried to use @DirectoryManager.getInstance()@ but it doesn't work.
I'm using the following code:...
Marius Gligor
12:41 PM Feature #2385: implement environment access on GUI interfaces.
Code Review 0911b
Instead of adding a @ServerExports@ method to access the read-only flag, please use the @Directo...
Greg Shah
11:35 AM Feature #2385: implement environment access on GUI interfaces.
Fixed 0911a code review. The read only flag is global and read from server node @readOnlyEnvironments@ which should h... Marius Gligor
10:49 AM Feature #2385: implement environment access on GUI interfaces.
Code Review 0911a
The changes are very good.
> a) The read only flag which change the loading rule from client ...
Greg Shah
09:51 AM Feature #2385 (Review): implement environment access on GUI interfaces.
Marius Gligor
09:26 AM Feature #2385: implement environment access on GUI interfaces.
1. I fixed code review issues from 0910a.
2. I integrated the changes from task #2366 related to override default ...
Marius Gligor

09/10/2014

07:08 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> What is the status of your regression testing?
I've just started regression testing with latest ...
Evgeny Kiselev
07:04 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Greg Shah wrote:
> Code Review 0910a
>
> I am worried that your changes are just there to fix some very specific ...
Evgeny Kiselev
03:06 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
What is the status of your regression testing?
What standalone testcases have you run to confirm your changes are ...
Greg Shah
03:01 PM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
Code Review 0910a
I am worried that your changes are just there to fix some very specific behavior in a few testca...
Greg Shah
07:44 AM Feature #1628: fix any incompatibilities or missing features of NO-ECHO support
I've added addition comments in code. There is next algorithm.
1) first output is @put unformatted@ (in my case this...
Evgeny Kiselev
05:20 PM Feature #2385: implement environment access on GUI interfaces.
Code Review 0910a
1. Doesn't @StanzaIni@ always get used on the client side? If so, then the jar file reading is ...
Greg Shah
11:09 AM Feature #2385: implement environment access on GUI interfaces.
Here are my changes that I did so far on this task. Please do a code review on these changes and let me know the resu... Marius Gligor

09/09/2014

04:23 PM Bug #2338: fix _MSG function
Vadim Gindin wrote:
> I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(...
Constantin Asofiei
04:07 PM Bug #2338: fix _MSG function
I ran your test and in both cases (with or without NO-ERROR) it behaved in the same way. _MSG(1) = 74. The error bein... Vadim Gindin
01:21 PM Bug #2338: fix _MSG function
> > 1. With NO-ERROR the error number wasn't recorded to _MSG array. That is little unexpected.
> Please correct me,...
Vadim Gindin
01:02 PM Bug #2338: fix _MSG function
Vadim Gindin wrote:
> I'm not sure, that I understood correctly. I expected that 0 is the default value that exists ...
Constantin Asofiei
12:49 PM Bug #2338: fix _MSG function
Constantin Asofiei wrote:
> I think it shows that:
> # if a @NO-ERROR@ is added to @DELETE book@, then the ERROR-ST...
Vadim Gindin
06:57 AM Bug #2338: fix _MSG function
Vadim Gindin wrote:
> 2a. format constraint 1-digit number.
> While trying to validate number 10 there are an er...
Constantin Asofiei
 

Also available in: Atom