Activity
From 03/03/2020 to 04/01/2020
04/01/2020
- 01:13 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Tried various combinations, none seems to work. Anything else we ... - 12:59 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Tried various combinations, none seems to work. Anything else we need to do apart from @gradle j... - 12:44 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
@Co... - 12:43 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > OK, so the one that already exist we do not 'refactor' but we nee... - 12:01 PM Feature #4384: Builtin OO Implementation
- OK
- 11:34 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> OK, so the one that already exist we do not 'refactor' but we need to add them as exceptions.
... - 11:30 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> This one, and maybe others, I think were added early on, and were written 'by hand', wit... - 11:17 AM Feature #4384: Builtin OO Implementation
- > One way would be to find the p2j.oo equivalent automatically (searching for the LegacyResource annotation), and use...
- 11:11 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> That's exactly what we did and observed the pattern we described, problem is for instance @IHttp... - 11:09 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter ru... - 11:07 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConv... - 11:05 AM Feature #4384: Builtin OO Implementation
- > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter rules - a IWebHandler ...
- 11:02 AM Feature #4384: Builtin OO Implementation
- Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConverter@ rules - a @IWebHandler...
- 11:01 AM Feature #4384: Builtin OO Implementation
- >> Yes, but in Java we use "camel cased" names.
>
> camel case for variables, class names are still pascal case it ... - 09:57 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
>
> Yes, but in Java we use "camel cased" names.
camel case for variables, class names are still... - 09:46 AM Feature #4384: Builtin OO Implementation
- > it seems the conversion translate the OE names to all lower for the package name
Yes. Except the @Progress@ and... - 08:56 AM Feature #4384: Builtin OO Implementation
- Quick question on naming convention, for interfaces it seems the conversion translate the OE names to all lower for t...
03/31/2020
- 03:16 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> But didn't you mentioned c'tors are already treated differently in FWD? Not sure if we have that... - 02:45 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
OK,... - 02:41 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, d... - 02:31 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
03/30/2020
- 02:39 PM Bug #4602: fixes for OO 4GL and structured error handling
- From #4384-121:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic f... - 02:32 PM Bug #4602 (Review): fixes for OO 4GL and structured error handling
- 02:31 PM Feature #4384: Builtin OO Implementation
- Marian, what's the use case for the extent problem? Can you modify it so that it uses a fixed extent? Or to execute ...
- 02:02 PM Feature #4384: Builtin OO Implementation
- > From these, I think only the last two may need explicit fixing - as it looks like the ERROR can be 'eaten' by a par...
- 01:08 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynam... - 12:55 PM Feature #4384: Builtin OO Implementation
- I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic functions), which cove...
- 04:51 AM Feature #4384: Builtin OO Implementation
- We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynamicArray@ because as t...
03/28/2020
- 12:17 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Maybe this is the issue, we're using an @internalProcedure@ block...
03/27/2020
- 11:15 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Maybe this is the issue, we're using an @internalProcedure@ block for constructors so it should ... - 10:00 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> A @RETUNR ERROR "foo"@ sets the @RETURN-VALUE@ in some cases. And if there is no @BLOCK... - 09:35 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> - there is no real difference between return error, return error new AppError (I think this stat... - 09:26 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> OK, that is fair. We need to handle all cases with compatibility before implementing any optimiz... - 09:14 AM Feature #4384: Builtin OO Implementation
- OK, that is fair. We need to handle all cases with compatibility before implementing any optimizations.
- 09:03 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.pr... - 08:54 AM Feature #4384: Builtin OO Implementation
- In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.processLegacyError()@ ...
- 07:19 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Marian Edu wrote:
> > Will try to change the test to see if that is still the case, right now t... - 05:45 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Will try to change the test to see if that is still the case, right now the errors are not being... - 05:33 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
03/26/2020
- 03:02 PM Feature #4384: Builtin OO Implementation
- Eugenie Lyzenko wrote:
> I do not need to restart conversion for this change, right?
Reconversion is not needed.
- 02:54 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
... - 02:43 PM Feature #4384: Builtin OO Implementation
- I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
The reason: I was processi... - 01:55 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Creating an empty @hosts.txt@ file in working folder solved the issue though so we're all good n... - 01:06 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> While writing this thought to regenerate the code for the tests and try again, it now seems the ... - 12:35 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Did eventually made a pu...
03/24/2020
- 03:47 PM Feature #4384: Builtin OO Implementation
- @bzr send@ would maintain the revision history. An alternative is to zip up only your changed files and send those. ...
- 03:44 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Thanks Greg, quick quest... - 03:28 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> is the issue with error throwing from two or more level deep method call fixed already?
Yes, ev... - 03:24 PM Feature #4384: Builtin OO Implementation
- I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
- 03:23 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, the changes are in 4231b rev 11389
>
> Some parts were a little tricky to fix... - 03:19 PM Feature #4384: Builtin OO Implementation
- Marian, the changes are in 4231b rev 11389
Some parts were a little tricky to fix... sorry it took so long. If yo... - 04:09 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> So, should we change Assert as it should using internalProcedure block and loadClass with static... - 02:57 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Let me know if you have questions or need more test cases for thi...
03/23/2020
- 06:29 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Let me know if you have questions or need more test cases for this one.
Thanks Marian, I still ... - 03:58 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I don't understand this part - do you have an explicit te... - 09:30 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I don't understand this part - do you have an explicit test?
I see it now... a two or m... - 08:51 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> All assert methods in there are static, some use internalProcedure blocks but others don't and s... - 08:17 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Can you isolate this in a simple example? Or point me to an existing test?
>
Since... - 06:12 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Say one methodA needs to call another methodB with some default parameters, the parameters sent ... - 04:32 AM Feature #4384: Builtin OO Implementation
- We somehow still have some issues with the error handling there.
Say one methodA needs to call another methodB wit...
03/19/2020
- 09:27 AM Feature #4384: Builtin OO Implementation
- FYI, the named enum instances will be @final static@ and will have no mutable state. I agree that we don't need @Con...
- 03:05 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > ... what does ContextLocal does?
> In FWD, all clients are on th...
03/18/2020
- 02:34 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> ... what does ContextLocal does?
In FWD, all clients are on the same Java process. And the Jav... - 08:44 AM Feature #4384: Builtin OO Implementation
- FYI, my work on enums (#4349) is in process. I will have generic conversion and runtime support for enums when I am ...
- 07:45 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin, while the conversion now seems to work we again don't see the client window status b... - 07:24 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, how did you define the static members? This needs to be something like this:
> ... - 07:18 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s... - 07:15 AM Feature #4384: Builtin OO Implementation
- Marian, how did you define the static members? This needs to be something like this:...
- 05:49 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s... - 04:28 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> There's something weird - the code you posted in the stacktrace should never execute dur... - 03:58 AM Feature #4384: Builtin OO Implementation
- There's something weird - the code you posted in the stacktrace should never execute during conversion. Did you add ...
- 03:35 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
03/17/2020
- 06:25 AM Feature #4384: Builtin OO Implementation
- > None of those files in conflict were changed by us locally so I would say I can just pick the 'other' version and r...
- 06:23 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I assume that you have not changed the files in the merge conflict list?
>
> The new 4231b bra... - 06:20 AM Feature #4384: Builtin OO Implementation
- I assume that you have not changed the files in the merge conflict list?
The new 4231b branch is a "superset" of 4... - 06:04 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
03/16/2020
- 08:35 AM Feature #4384: Builtin OO Implementation
- @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@ has been removed.
- 07:24 AM Feature #4384: Builtin OO Implementation
- > Can we try to modify other classes - like longchar or CopyLob ( of course - only if we can do it ) ?
Yes, please... - 06:19 AM Feature #4384: Builtin OO Implementation
- The email patches are in 4231b ref 11364
* Fixed an issue with method call's argument annotation in case of chained ... - 04:59 AM Feature #4384: Builtin OO Implementation
- When testing ByteBucket methods we have found that is need for improvement in other classes who is used by ByteBucket...
03/13/2020
- 03:46 PM Feature #3810: SECURITY-POLICY and other security features
- Task branch 4335a was merged to trunk as revision 11345.
- 03:45 PM Feature #3254: add support for running 4GL on multiple threads in a single session
- Task branch 4335a was merged to trunk as revision 11345.
- 03:39 PM Feature #3867: direct java class access from 4GL code
- Task branch 4335a was merged to trunk as revision 11345.
- 03:37 PM Feature #3867 (Closed): direct java class access from 4GL code
- 10:58 AM Feature #3868: customer servlet integration/support
- Greg Shah wrote:
> 1. What can we do to make it simple to configure/load these servlets? I want to avoid a huge amo...
03/12/2020
- 09:28 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
- Do you have a simple example for this? Conversion rules should choose the @putBytes_1@ if the argument is @Memptr@.
- 09:25 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
- Constantin Asofiei wrote:
> See #3751-492 for a comprehensive list of overload rules. We need support for method ov...
03/11/2020
- 04:00 PM Feature #4384: Builtin OO Implementation
- > Greg, do we have some guildelines how the converted 4GL ENUMs should look? I think we need to add HashAlgorithmEnum...
03/10/2020
- 09:42 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> The issue was due to the fact that @GetEnum@ methods in skeleton class for Enum were not static,... - 09:37 AM Feature #4384: Builtin OO Implementation
- On 3/10/20 12:20 PM, Mihai Tiganea wrote:
> Getting deeper with tests for openedge.core.bytebucket I discover commen... - 04:22 AM Feature #4384: Builtin OO Implementation
- It turns out returning an object<> that has a reference that was not 'registered' with @ObjectOps@ will fail anyway w...
- 03:58 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> > * Gradlew.bat deploy.all for oo/openedge/core/memptr/test_method_get_hash_algorithm.p ...
03/09/2020
- 04:55 PM Support #4032: block/transaction processing context-local and other performance improvements
- I've documented some ideas related to Constantin's CFS reflection optimization task (#1970).
- 04:55 PM Feature #1970: improve ControlFlowOps method resolution by reflection
- I've been thinking about how we could cache method instances in @ControlFlowOps@ recently. I started to document my ...
- 08:16 AM Feature #4384: Builtin OO Implementation
- On 3/9/20 1:36 PM, Mihai Tiganea wrote:
>
> After create tests in progress for ByteBucket and Memptr constructors, ...
03/04/2020
- 10:31 AM Bug #4484 (Closed): Accumulator confusion using same field for count and total
- 10:31 AM Bug #4483 (Closed): Unable to use logical variable check in underline statement
- 10:30 AM Bug #4482 (Closed): Enable/Disable with empty EXCEPT causes issues
- 10:30 AM Bug #4480 (Closed): Extent does not become fixed when there is an initial list of values
- 10:29 AM Bug #4455 (Closed): Extent field on unsubscripted next-prompt not converted properly
- 10:29 AM Bug #4427 (Closed): Unable to convert keyword input when used to index into an extent
- 10:29 AM Bug #4425 (Closed): Lost frame_id when converting code with missing field names to update
- 10:28 AM Bug #4424 (Closed): Additional def var needed to receive table handle when keyword FOR included i...
- 10:28 AM Bug #4423 (Closed): Incorrect buffer scoping when same buffer name used as a parameter to interna...
03/03/2020
- 02:54 PM Bug #4484 (Review): Accumulator confusion using same field for count and total
- Task branch 4207a was merged to trunk as revision 11344. Task can be moved to closed. It was still in WIP.
- 02:53 PM Bug #4483: Unable to use logical variable check in underline statement
- Task branch 4207a was merged to trunk as revision 11344.
- 02:51 PM Bug #4482: Enable/Disable with empty EXCEPT causes issues
- Task branch 4207a was merged to trunk as revision 11344.
- 02:50 PM Bug #4480: Extent does not become fixed when there is an initial list of values
- Task branch 4207a was merged to trunk as revision 11344.
- 02:49 PM Bug #4455: Extent field on unsubscripted next-prompt not converted properly
- Task branch 4207a was merged to trunk as revision 11344.
- 02:46 PM Bug #4453: Handling of filename with quotation mark broken in control_flow.rules
- Task branch 4207a was merged to trunk as revision 11344. There have not been any regressions or new issues related to...
- 02:28 PM Bug #4453 (WIP): Handling of filename with quotation mark broken in control_flow.rules
- 02:43 PM Bug #4427: Unable to convert keyword input when used to index into an extent
- Task branch 4207a was merged to trunk as revision 11344.
- 02:40 PM Bug #4425: Lost frame_id when converting code with missing field names to update
- Task branch 4207a was merged to trunk as revision 11344.
- 02:39 PM Bug #4424: Additional def var needed to receive table handle when keyword FOR included in def par...
- Task branch 4207a was merged to trunk as revision 11344.
- 02:38 PM Bug #4423: Incorrect buffer scoping when same buffer name used as a parameter to internal procedure
- Task branch 4207a was merged to trunk as revision 11344.
- 02:36 PM Bug #4476 (Closed): Shared frame does not get @ widget method generated
- 02:26 PM Bug #4476: Shared frame does not get @ widget method generated
- Greg Shah wrote:
> Task branch 4207a was merged to trunk as revision 11344.
>
> Is there anything left open in th... - 02:24 PM Bug #4476: Shared frame does not get @ widget method generated
- Task branch 4207a was merged to trunk as revision 11344.
Is there anything left open in this task? - 01:50 PM Bug #4563: assigning a dynamic extent var to a OO method call as rvalue
- Static vars/properties (with dynamic extent) should be included.
- 08:22 AM Bug #4563: assigning a dynamic extent var to a OO method call as rvalue
- The @testcases/uast/ext_arg_*.p@ tests explore how a parameter/variable (dynamic extent or not) used as an argument e...
- 08:14 AM Bug #4563 (New): assigning a dynamic extent var to a OO method call as rvalue
- 01:04 PM Bug #4123 (Closed): conversion generates incorrect java code for Extent statement
- Branch 4207a was merged to trunk as revision 11344.
- 01:04 PM Bug #4160 (WIP): Arrays assigment issue
- Branch 4207a was merged to trunk as revision 11344.
Also available in: Atom