Activity
From 03/17/2020 to 04/15/2020
04/16/2020
- 08:16 PM Feature #4384: Builtin OO Implementation
- 4384a was archived as dead on devsrv01. Please note that I was unable to @bzr push --overwrite@ on devsrv01 so I zip...
- 08:14 PM Feature #4384: Builtin OO Implementation
- Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer.goldencode.com/opt/...
04/15/2020
- 06:44 PM Feature #4384: Builtin OO Implementation
- > I think we should preserve 4384a as a dead branch on devsrv01 and create 4384b.
Will do. - 06:38 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> # rebase 4231b from trunk 11346
The rebase of 4231b is done.
> # replace the 4384a branch with ... - 05:57 PM Feature #4384: Builtin OO Implementation
- > Greg: can you please update the web repo?
Done. - 05:40 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I think the faster way is to:
>
> # merge the exact revisions from 4384a into 4231b
The 11426... - 05:36 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Yes, please zip it and upload it to xfer.
> I'm confused as ... - 04:25 PM Feature #4384: Builtin OO Implementation
- I think the faster way is to:
# merge the exact revisions from 4384a into 4231b
# rebase 4231b from trunk 11346
... - 02:06 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
>
> I'm trying to... - 01:40 PM Feature #4384: Builtin OO Implementation
- Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
I'm trying to rebase 4384a from 4231b, and I t... - 12:47 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Yes, please zip it and upload it to xfer.
I'm confused as of what you refer to when y... - 12:32 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > Did pulled the skeleton fresh and sync t... - 12:31 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Did pulled the skeleton fresh and sync the two folders, attached ... - 12:03 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Did pulled the skeleton fresh and sync the two folders, attached the patch.
Where did you pull ... - 11:21 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> OK, do let me know when they are there. I need to do a review and see if they can be me... - 10:48 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Will try to push the changes to 4384a now
OK, do let me know when they are there. I need to do... - 10:45 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, are all your 4384a changes pushed to xfer?
>
> Also, please upload to xfer th... - 10:22 AM Feature #4384: Builtin OO Implementation
- Marian, are all your 4384a changes pushed to xfer?
Also, please upload to xfer the full skeleton project, with you...
04/14/2020
- 10:03 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> > > Not sure how the skeleton works for you, looks like it's being used by the parser to resolve ... - 09:57 AM Feature #4384: Builtin OO Implementation
- Great!
- 09:44 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> Thanks for posting a high level status.
>
> It is very high priority to get the conversion par... - 09:41 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> > One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us under... - 09:40 AM Feature #4384: Builtin OO Implementation
- Thanks for posting a high level status.
It is very high priority to get the conversion parts finished ASAP. Can y... - 09:35 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us unde... - 09:34 AM Feature #4384: Builtin OO Implementation
- > One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us understand the need for t...
- 09:32 AM Feature #4384: Builtin OO Implementation
- > > Not sure how the skeleton works for you, looks like it's being used by the parser to resolve references,
Yes,... - 02:17 AM Feature #4384: Builtin OO Implementation
- Roger Borrello wrote:
> h2. OO Built-Ins Requiring Implementation
>
> Breakdown of OO BuiltIns to focus on:
> * ...
04/13/2020
- 10:22 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> As a temporary patch, you can move this section:
> [...]
> from @rules/fixups/post_par... - 08:27 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > If you want to fix this now, just move the @_1@ suffix fr... - 08:14 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> If you want to fix this now, just move the @_1@ suffix from the property getter to the J... - 08:13 AM Feature #4384: Builtin OO Implementation
- Marian, this is fixed in 3471a which will be in trunk soon.
If you want to fix this now, just move the @_1@ suffix... - 07:43 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > And the skeleton have a public property and protected methods lik... - 07:41 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> And the skeleton have a public property and protected methods like this:
> [...]
Hmm... are th... - 07:33 AM Feature #4384: Builtin OO Implementation
- And the skeleton have a public property and protected methods like this:...
- 07:30 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > The test is oo/openedge/net/message_part/test_property_headers.p
... - 07:28 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> The test is oo/openedge/net/message_part/test_property_headers.p
Marian, I'm looking into it. - 07:14 AM Feature #4384: Builtin OO Implementation
- OK, I give-up :(
I'm trying to make sense of why the conversion is using the wrong method name here but I really d...
04/11/2020
- 12:38 PM Feature #4384: Builtin OO Implementation
- I've tried to merge your changes to skeleton with ours and no wonder there are merge conflicts, I can solve those now...
04/09/2020
- 06:56 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> @Greg, do you have already a blue print for the OE Enums? We still have some issues with those a... - 02:54 AM Feature #4384: Builtin OO Implementation
- @Greg, do you have already a blue print for the OE Enums? We still have some issues with those and would be nice to k...
04/07/2020
- 01:51 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> FYI, I have updated @https://proj.goldencode.com/downloads/skeletons/repo@ to rev 89 earlier toda... - 01:43 PM Feature #4384: Builtin OO Implementation
- > Sounds simple enough, how do we know when we need to incorporate changes from 4231b, will someone notify us or we s...
- 01:39 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > I think is related to using a skeleton c... - 12:58 PM Feature #4384: Builtin OO Implementation
- The fix is in 4231b rev 11427 on xfer. I should have added it to 4384a, sorry.
You can try the rebase now :) - 12:53 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > I think is related to using a skeleton class. For example, at lea... - 12:42 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think is related to using a skeleton class. For example, at least the skeleton methods... - 12:40 PM Feature #4384: Builtin OO Implementation
- I think is related to using a skeleton class. For example, at least the skeleton methods are missing the @extent@ for...
- 12:39 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > @Constantin, the code generated still do... - 12:26 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > @Constantin, the code generated still doesn't work for us when in... - 12:16 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> In fact, you can always rebase an unbound 4384a branch from the latest 4231b on xfer and then @... - 12:15 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> @Constantin, the code generated still doesn't work for us when indeterminate extents are used. T... - 12:08 PM Feature #4384: Builtin OO Implementation
- > OK, we will continue to work with our local git repository and only I will push changes to bazaar to keep it simple...
- 11:49 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > There was no cast in the conversion rule and we didn't changed th... - 11:18 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> Created branch 4384a, branched from 4231b revision 11425.
>
> Access it:
>
> @bzr co sftp:/... - 12:11 PM Bug #4602: fixes for OO 4GL and structured error handling
- Another case to cover: simple statements with @NO-ERROR@, like @ch = h:name NO-ERROR.@ and @input from os-dir("missin...
04/06/2020
- 03:31 PM Feature #4384: Builtin OO Implementation
- Created branch 4384a, branched from 4231b revision 11425.
Access it:
@bzr co sftp://<userid>@xfer.goldencode.co...
04/03/2020
- 09:54 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> There was no cast in the conversion rule and we didn't changed the rules simply modified the gen... - 09:49 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
>
> W... - 09:38 AM Feature #4384: Builtin OO Implementation
- Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
What's the signature for @assignMu... - 09:25 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> fixes the reference but the uncheck cast is ugly to say at least :(
Changing the @assignMulti... - 09:15 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
04/01/2020
- 01:13 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Tried various combinations, none seems to work. Anything else we ... - 12:59 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Tried various combinations, none seems to work. Anything else we need to do apart from @gradle j... - 12:44 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
@Co... - 12:43 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > OK, so the one that already exist we do not 'refactor' but we nee... - 12:01 PM Feature #4384: Builtin OO Implementation
- OK
- 11:34 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> OK, so the one that already exist we do not 'refactor' but we need to add them as exceptions.
... - 11:30 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> This one, and maybe others, I think were added early on, and were written 'by hand', wit... - 11:17 AM Feature #4384: Builtin OO Implementation
- > One way would be to find the p2j.oo equivalent automatically (searching for the LegacyResource annotation), and use...
- 11:11 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> That's exactly what we did and observed the pattern we described, problem is for instance @IHttp... - 11:09 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter ru... - 11:07 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConv... - 11:05 AM Feature #4384: Builtin OO Implementation
- > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter rules - a IWebHandler ...
- 11:02 AM Feature #4384: Builtin OO Implementation
- Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConverter@ rules - a @IWebHandler...
- 11:01 AM Feature #4384: Builtin OO Implementation
- >> Yes, but in Java we use "camel cased" names.
>
> camel case for variables, class names are still pascal case it ... - 09:57 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
>
> Yes, but in Java we use "camel cased" names.
camel case for variables, class names are still... - 09:46 AM Feature #4384: Builtin OO Implementation
- > it seems the conversion translate the OE names to all lower for the package name
Yes. Except the @Progress@ and... - 08:56 AM Feature #4384: Builtin OO Implementation
- Quick question on naming convention, for interfaces it seems the conversion translate the OE names to all lower for t...
03/31/2020
- 03:16 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> But didn't you mentioned c'tors are already treated differently in FWD? Not sure if we have that... - 02:45 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
OK,... - 02:41 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, d... - 02:31 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
03/30/2020
- 02:39 PM Bug #4602: fixes for OO 4GL and structured error handling
- From #4384-121:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic f... - 02:32 PM Bug #4602 (Review): fixes for OO 4GL and structured error handling
- 02:31 PM Feature #4384: Builtin OO Implementation
- Marian, what's the use case for the extent problem? Can you modify it so that it uses a fixed extent? Or to execute ...
- 02:02 PM Feature #4384: Builtin OO Implementation
- > From these, I think only the last two may need explicit fixing - as it looks like the ERROR can be 'eaten' by a par...
- 01:08 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynam... - 12:55 PM Feature #4384: Builtin OO Implementation
- I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic functions), which cove...
- 04:51 AM Feature #4384: Builtin OO Implementation
- We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynamicArray@ because as t...
03/28/2020
- 12:17 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Maybe this is the issue, we're using an @internalProcedure@ block...
03/27/2020
- 11:15 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Maybe this is the issue, we're using an @internalProcedure@ block for constructors so it should ... - 10:00 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> A @RETUNR ERROR "foo"@ sets the @RETURN-VALUE@ in some cases. And if there is no @BLOCK... - 09:35 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> - there is no real difference between return error, return error new AppError (I think this stat... - 09:26 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> OK, that is fair. We need to handle all cases with compatibility before implementing any optimiz... - 09:14 AM Feature #4384: Builtin OO Implementation
- OK, that is fair. We need to handle all cases with compatibility before implementing any optimizations.
- 09:03 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.pr... - 08:54 AM Feature #4384: Builtin OO Implementation
- In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.processLegacyError()@ ...
- 07:19 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Marian Edu wrote:
> > Will try to change the test to see if that is still the case, right now t... - 05:45 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Will try to change the test to see if that is still the case, right now the errors are not being... - 05:33 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
03/26/2020
- 03:02 PM Feature #4384: Builtin OO Implementation
- Eugenie Lyzenko wrote:
> I do not need to restart conversion for this change, right?
Reconversion is not needed.
- 02:54 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
... - 02:43 PM Feature #4384: Builtin OO Implementation
- I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
The reason: I was processi... - 01:55 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Creating an empty @hosts.txt@ file in working folder solved the issue though so we're all good n... - 01:06 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> While writing this thought to regenerate the code for the tests and try again, it now seems the ... - 12:35 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Did eventually made a pu...
03/24/2020
- 03:47 PM Feature #4384: Builtin OO Implementation
- @bzr send@ would maintain the revision history. An alternative is to zip up only your changed files and send those. ...
- 03:44 PM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Thanks Greg, quick quest... - 03:28 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> is the issue with error throwing from two or more level deep method call fixed already?
Yes, ev... - 03:24 PM Feature #4384: Builtin OO Implementation
- I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
- 03:23 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, the changes are in 4231b rev 11389
>
> Some parts were a little tricky to fix... - 03:19 PM Feature #4384: Builtin OO Implementation
- Marian, the changes are in 4231b rev 11389
Some parts were a little tricky to fix... sorry it took so long. If yo... - 04:09 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> So, should we change Assert as it should using internalProcedure block and loadClass with static... - 02:57 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > Let me know if you have questions or need more test cases for thi...
03/23/2020
- 06:29 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Let me know if you have questions or need more test cases for this one.
Thanks Marian, I still ... - 03:58 PM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > I don't understand this part - do you have an explicit te... - 09:30 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> I don't understand this part - do you have an explicit test?
I see it now... a two or m... - 08:51 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> All assert methods in there are static, some use internalProcedure blocks but others don't and s... - 08:17 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Can you isolate this in a simple example? Or point me to an existing test?
>
Since... - 06:12 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Say one methodA needs to call another methodB with some default parameters, the parameters sent ... - 04:32 AM Feature #4384: Builtin OO Implementation
- We somehow still have some issues with the error handling there.
Say one methodA needs to call another methodB wit...
03/19/2020
- 09:27 AM Feature #4384: Builtin OO Implementation
- FYI, the named enum instances will be @final static@ and will have no mutable state. I agree that we don't need @Con...
- 03:05 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian Edu wrote:
> > ... what does ContextLocal does?
> In FWD, all clients are on th...
03/18/2020
- 02:34 PM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> ... what does ContextLocal does?
In FWD, all clients are on the same Java process. And the Jav... - 08:44 AM Feature #4384: Builtin OO Implementation
- FYI, my work on enums (#4349) is in process. I will have generic conversion and runtime support for enums when I am ...
- 07:45 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin, while the conversion now seems to work we again don't see the client window status b... - 07:24 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> Marian, how did you define the static members? This needs to be something like this:
> ... - 07:18 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s... - 07:15 AM Feature #4384: Builtin OO Implementation
- Marian, how did you define the static members? This needs to be something like this:...
- 05:49 AM Feature #4384: Builtin OO Implementation
- Marian Edu wrote:
> Constantin Asofiei wrote:
> > There's something weird - the code you posted in the stacktrace s... - 04:28 AM Feature #4384: Builtin OO Implementation
- Constantin Asofiei wrote:
> There's something weird - the code you posted in the stacktrace should never execute dur... - 03:58 AM Feature #4384: Builtin OO Implementation
- There's something weird - the code you posted in the stacktrace should never execute during conversion. Did you add ...
- 03:35 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
03/17/2020
- 06:25 AM Feature #4384: Builtin OO Implementation
- > None of those files in conflict were changed by us locally so I would say I can just pick the 'other' version and r...
- 06:23 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> I assume that you have not changed the files in the merge conflict list?
>
> The new 4231b bra... - 06:20 AM Feature #4384: Builtin OO Implementation
- I assume that you have not changed the files in the merge conflict list?
The new 4231b branch is a "superset" of 4... - 06:04 AM Feature #4384: Builtin OO Implementation
- Greg Shah wrote:
> @xfer.goldencode.com:/opt/fwd/4231b@ is now available. FYI, @xfer.goldencode.com:/opt/fwd/4335a@...
Also available in: Atom