Project

General

Profile

Activity

From 03/24/2020 to 04/22/2020

04/22/2020

11:39 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, another question please: who/when sets the @SERVLET_SRVR_...
Constantin Asofiei
11:23 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Constantin Asofiei wrote:
> Marian, another question please: who/when sets the @SERVLET_SRVR_DEBUG@ and @SERVLET_SER...
Marian Edu
10:42 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, another question please: who/when sets the @SERVLET_SRVR_DEBUG@ and @SERVLET_SERVER_APP_MODE@ CGI vars? I ca... Constantin Asofiei
10:50 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > Greg: please fix the permissions, I can't even do a checkout from https://proj.goldencode.com/d...
Constantin Asofiei
10:45 AM Feature #4384: Builtin OO Implementation
> Greg: please fix the permissions, I can't even do a checkout from https://proj.goldencode.com/downloads/skeletons/r... Greg Shah
10:37 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > I would try @bzr diff -p1 -r <your checkout revision>@ so th...
Constantin Asofiei
10:34 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, quick question - do you have the @toString@ method for @net.Uri@ class implement...
Marian Edu
10:32 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I would try @bzr diff -p1 -r <your checkout revision>@ so that on our side we can use...
Marian Edu
10:18 AM Feature #4384: Builtin OO Implementation
Marian, quick question - do you have the @toString@ method for @net.Uri@ class implemented? If not, I'm adding it in ... Constantin Asofiei
10:16 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> That sounds like fun, now that I can debug the whole conversion process this might be interestin...
Constantin Asofiei
10:15 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Should I try again a 'bzr send' for the skeleton or how should we send the changes there?
T...
Marian Edu
10:11 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > I see properties are converted to getter/setter methods and are a...
Marian Edu
10:06 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I see properties are converted to getter/setter methods and are annotated with the name as defin...
Constantin Asofiei
09:56 AM Feature #4384: Builtin OO Implementation
I see properties are converted to getter/setter methods and are annotated with the name as defined in 4GL, for variab... Marian Edu
06:15 AM Feature #4349: add support for 4GL ENUM
Hi Greg, we need @FlagsEnum@ for reflection so tried to implement something for this but there seems this is not yet ... Marian Edu

04/21/2020

06:05 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> Being more explicit about returning unknown when the input is unknown is a good practice. The fa...
Roger Borrello
05:48 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Added a simpler testcase @uast/library_calls/library_member2.p@ Roger Borrello
05:32 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Being more explicit about returning unknown when the input is unknown is a good practice. The fact that the matching... Greg Shah
05:22 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Roger Borrello wrote:
> Greg Shah wrote:
> > You will need to add the proper error handling, but otherwise it is fi...
Roger Borrello
05:18 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> I don't see anything obviously wrong. The code seems like it should work.
>
> You will need t...
Roger Borrello
05:04 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
I don't see anything obviously wrong. The code seems like it should work.
You will need to add the proper error h...
Greg Shah
04:39 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Made the changes to allow the pattern to be pre-compiled, but it no longer matches the given string.... Roger Borrello
02:53 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Code Review Task Branch 4231b Revision 11479
This is quite good. Here are some things to fix to make it better.
...
Greg Shah
02:19 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Ready for review...... Roger Borrello
02:14 PM Feature #4381 (WIP): implement LIBRARY() and MEMBER() built-in functions
Roger Borrello
12:43 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
That makes sense. Greg Shah
12:27 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Roger Borrello wrote:
> Should these be placed nearby @SEARCH@ in @FileSystemOps@ like @searchLibrary@ and @searchMe...
Roger Borrello
12:25 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Should these be placed nearby @SEARCH@ in @FileSystemOps@ like @searchLibrary@ and @searchMember@? Roger Borrello
10:55 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Created @uast/library_member.p@ testcase based off some customer code. However, the use of @LIBRARY@ in the sample do... Roger Borrello
10:41 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Useful background information on libraries: https://documentation.progress.com/output/ua/OpenEdge_latest/index.html#p... Roger Borrello
03:29 PM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> Code Review Task branch 4231b Revision 11470
>
> 1. In @KEEP-MESSAGES@ mode, have you checked ...
Roger Borrello
10:07 AM Feature #4395: add support for KEEP-MESSAGES option
Don't change existing sample code in a way that destroys the original intent and control flow. Add a new testcase an... Greg Shah
09:16 AM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> What is the testcase? Why is it retrying instead of exiting?
It is @uast/io/basic_redirecte...
Roger Borrello
08:48 AM Feature #4395: add support for KEEP-MESSAGES option
> It's difficult to determine how the 4GL is actually handling this. Perhaps it implicitly closes the stream, and we ... Greg Shah
05:38 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> OK, I see that we are missing from @Progress.Lang.Class@ the methods which resolve a cla...
Marian Edu
05:37 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @i...
Constantin Asofiei
05:29 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @invoke@ calls when @Para...
Marian Edu
05:18 AM Feature #4384: Builtin OO Implementation
Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @invoke@ calls when @ParameterList@ is involved (so ye... Constantin Asofiei
04:59 AM Feature #4384: Builtin OO Implementation
Quick question about @P.L.Class@ as that is listed in the short list there... do you need reflection support for that... Marian Edu

04/20/2020

04:53 PM Feature #4395: add support for KEEP-MESSAGES option
I have updates to correct behavior where @Press space bar to continue@ was displayed in ChUI, even though output was ... Roger Borrello
03:38 PM Feature #4395: add support for KEEP-MESSAGES option
Roger, PUT SCREEN issues in GUI are known, see #2372. Constantin Asofiei
03:31 PM Feature #4395: add support for KEEP-MESSAGES option
I am not seeing the testcases @put screen...@ show up in GUI like it does in 4GL. In @ThinClient@, the @putScreen@ me... Roger Borrello
02:32 PM Feature #4395: add support for KEEP-MESSAGES option
The latter seems most likely the same issue as #4619. Roger Borrello
02:27 PM Feature #4395: add support for KEEP-MESSAGES option
Code Review (cont.)
2. In @LowLevelStream@ and @StreamDaemon@ you need to add an @id@ parameter javadoc entry for...
Greg Shah
02:23 PM Feature #4395: add support for KEEP-MESSAGES option
Code Review Task branch 4231b Revision 11470
1. In @KEEP-MESSAGES@ mode, have you checked the following behavior?
...
Greg Shah
02:01 PM Feature #4395: add support for KEEP-MESSAGES option
> An unrelated issues has to do with how display "Last Line" with frame f-last. is handled, with message "A message."... Greg Shah
01:45 PM Feature #4395 (WIP): add support for KEEP-MESSAGES option
Roger Borrello
01:45 PM Feature #4395: add support for KEEP-MESSAGES option
Ready for review.... Roger Borrello
11:40 AM Feature #4395: add support for KEEP-MESSAGES option
In the spirit of "learning to fish", you could use the following to answer the question yourself:
@my-int-var = in...
Greg Shah
11:16 AM Feature #4395: add support for KEEP-MESSAGES option
Now we are cooking... @keepMessages@ is now available to the client in the critical location.
At looking at the s...
Roger Borrello
09:30 AM Feature #4395: add support for KEEP-MESSAGES option
> I do know my breakpoint in StreamDaemon.setKeepMessages(int id) doesn't get hit.
This breakpoint will be hit in ...
Greg Shah
09:27 AM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> See @ThinClient.getCurrentRedirection()@.
On the server side, @RemoteStream.setKeepMessages@ i...
Roger Borrello
07:22 AM Feature #4395: add support for KEEP-MESSAGES option
See @ThinClient.getCurrentRedirection()@. Greg Shah
01:02 AM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> > Do I still need to fiddle with RemoteStream if I am converting as:
>
> Yes. @RemoteStream@ ...
Roger Borrello

04/19/2020

05:45 PM Feature #4395: add support for KEEP-MESSAGES option
> Do I still need to fiddle with RemoteStream if I am converting as:
Yes. @RemoteStream@ is how it gets to the cl...
Greg Shah
05:14 PM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> @getKeepMessages()@ should be named @isKeepMessages()@ since the flag is a @boolean@. The standa...
Roger Borrello
10:35 AM Feature #4395: add support for KEEP-MESSAGES option
@getKeepMessages()@ should be named @isKeepMessages()@ since the flag is a @boolean@. The standard for Java "bean" n... Greg Shah
10:16 AM Feature #4395: add support for KEEP-MESSAGES option
It looks like there is a bug in @LogicalTerminal.message()@ whereby the output stream is never checked for redirectio... Roger Borrello
09:58 AM Feature #4395: add support for KEEP-MESSAGES option
That part is straightforward. I am using @setKeepMessages()@ without a parameter because it is an option that default... Roger Borrello

04/18/2020

06:40 AM Feature #4395: add support for KEEP-MESSAGES option
> I would just call the setter directly as setKeepMessages(true), instead of modifying the StreamFactory APIs.
Agr...
Greg Shah

04/17/2020

06:49 PM Feature #4395: add support for KEEP-MESSAGES option
Greg/Roger: the IO options can be emitted as a setter; see this portion of @convert/input_output.rules@:... Constantin Asofiei
06:39 PM Feature #4395: add support for KEEP-MESSAGES option
Please look at @StreamFactory@. You will see that it is stateless in regard to new streams. The @KEEP-MESSAGES@ fla... Greg Shah
05:18 PM Feature #4395: add support for KEEP-MESSAGES option
The @input_output.rules@ do not do anything with the @KEEP-MESSAGES@ options. There is the possibility of adding an a... Roger Borrello
03:49 PM Feature #4395: add support for KEEP-MESSAGES option
Updated testcase @uast/binary/read-text-and-binary.p@ to show there is no differences in having @keep-messages@ on th... Roger Borrello
02:27 PM Feature #4395: add support for KEEP-MESSAGES option
... Roger Borrello
12:33 PM Feature #4395: add support for KEEP-MESSAGES option
... Roger Borrello

04/16/2020

03:58 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Marian, just do a bzr revert and bzr clean-tree - to cleanup ...
Constantin Asofiei
03:35 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, just do a bzr revert and bzr clean-tree - to cleanup after the update.
OK, ...
Marian Edu
03:17 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Greg Shah wrote:
> > Branch 4384b was created from 4231b revision 11458. Access it using @bzr ...
Constantin Asofiei
03:02 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer...
Marian Edu
08:16 PM Feature #4384: Builtin OO Implementation
4384a was archived as dead on devsrv01. Please note that I was unable to @bzr push --overwrite@ on devsrv01 so I zip... Greg Shah
08:14 PM Feature #4384: Builtin OO Implementation
Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer.goldencode.com/opt/... Greg Shah

04/15/2020

06:44 PM Feature #4384: Builtin OO Implementation
> I think we should preserve 4384a as a dead branch on devsrv01 and create 4384b.
Will do.
Greg Shah
06:38 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> # rebase 4231b from trunk 11346
The rebase of 4231b is done.
> # replace the 4384a branch with ...
Constantin Asofiei
05:57 PM Feature #4384: Builtin OO Implementation
> Greg: can you please update the web repo?
Done.
Greg Shah
05:40 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I think the faster way is to:
>
> # merge the exact revisions from 4384a into 4231b
The 11426...
Constantin Asofiei
05:36 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Yes, please zip it and upload it to xfer.
> I'm confused as ...
Constantin Asofiei
04:25 PM Feature #4384: Builtin OO Implementation
I think the faster way is to:
# merge the exact revisions from 4384a into 4231b
# rebase 4231b from trunk 11346
...
Greg Shah
02:06 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
>
> I'm trying to...
Constantin Asofiei
01:40 PM Feature #4384: Builtin OO Implementation
Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
I'm trying to rebase 4384a from 4231b, and I t...
Constantin Asofiei
12:47 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Yes, please zip it and upload it to xfer.
I'm confused as of what you refer to when y...
Marian Edu
12:32 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > Did pulled the skeleton fresh and sync t...
Constantin Asofiei
12:31 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Did pulled the skeleton fresh and sync the two folders, attached ...
Marian Edu
12:03 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Did pulled the skeleton fresh and sync the two folders, attached the patch.
Where did you pull ...
Constantin Asofiei
11:21 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> OK, do let me know when they are there. I need to do a review and see if they can be me...
Marian Edu
10:48 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Will try to push the changes to 4384a now
OK, do let me know when they are there. I need to do...
Constantin Asofiei
10:45 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, are all your 4384a changes pushed to xfer?
>
> Also, please upload to xfer th...
Marian Edu
10:22 AM Feature #4384: Builtin OO Implementation
Marian, are all your 4384a changes pushed to xfer?
Also, please upload to xfer the full skeleton project, with you...
Constantin Asofiei

04/14/2020

10:03 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > > Not sure how the skeleton works for you, looks like it's being used by the parser to resolve ...
Constantin Asofiei
09:57 AM Feature #4384: Builtin OO Implementation
Great! Greg Shah
09:44 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Thanks for posting a high level status.
>
> It is very high priority to get the conversion par...
Marian Edu
09:41 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us under...
Marian Edu
09:40 AM Feature #4384: Builtin OO Implementation
Thanks for posting a high level status.
It is very high priority to get the conversion parts finished ASAP. Can y...
Greg Shah
09:35 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us unde...
Marian Edu
09:34 AM Feature #4384: Builtin OO Implementation
> One thing: I didn't anticipate your need to greatly change the skeletons. Can you help us understand the need for t... Greg Shah
09:32 AM Feature #4384: Builtin OO Implementation
> > Not sure how the skeleton works for you, looks like it's being used by the parser to resolve references,
Yes,...
Greg Shah
02:17 AM Feature #4384: Builtin OO Implementation
Roger Borrello wrote:
> h2. OO Built-Ins Requiring Implementation
>
> Breakdown of OO BuiltIns to focus on:
> * ...
Marian Edu

04/13/2020

10:22 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> As a temporary patch, you can move this section:
> [...]
> from @rules/fixups/post_par...
Marian Edu
08:27 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > If you want to fix this now, just move the @_1@ suffix fr...
Marian Edu
08:14 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> If you want to fix this now, just move the @_1@ suffix from the property getter to the J...
Constantin Asofiei
08:13 AM Feature #4384: Builtin OO Implementation
Marian, this is fixed in 3471a which will be in trunk soon.
If you want to fix this now, just move the @_1@ suffix...
Constantin Asofiei
07:43 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > And the skeleton have a public property and protected methods lik...
Marian Edu
07:41 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> And the skeleton have a public property and protected methods like this:
> [...]
Hmm... are th...
Constantin Asofiei
07:33 AM Feature #4384: Builtin OO Implementation
And the skeleton have a public property and protected methods like this:... Marian Edu
07:30 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > The test is oo/openedge/net/message_part/test_property_headers.p
...
Marian Edu
07:28 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> The test is oo/openedge/net/message_part/test_property_headers.p
Marian, I'm looking into it.
Constantin Asofiei
07:14 AM Feature #4384: Builtin OO Implementation
OK, I give-up :(
I'm trying to make sense of why the conversion is using the wrong method name here but I really d...
Marian Edu

04/11/2020

12:38 PM Feature #4384: Builtin OO Implementation
I've tried to merge your changes to skeleton with ours and no wonder there are merge conflicts, I can solve those now... Marian Edu

04/09/2020

06:56 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> @Greg, do you have already a blue print for the OE Enums? We still have some issues with those a...
Greg Shah
02:54 AM Feature #4384: Builtin OO Implementation
@Greg, do you have already a blue print for the OE Enums? We still have some issues with those and would be nice to k... Marian Edu

04/07/2020

01:51 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> FYI, I have updated @https://proj.goldencode.com/downloads/skeletons/repo@ to rev 89 earlier toda...
Marian Edu
01:43 PM Feature #4384: Builtin OO Implementation
> Sounds simple enough, how do we know when we need to incorporate changes from 4231b, will someone notify us or we s... Greg Shah
01:39 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Marian Edu wrote:
> > Constantin Asofiei wrote:
> > > I think is related to using a skeleton c...
Greg Shah
12:58 PM Feature #4384: Builtin OO Implementation
The fix is in 4231b rev 11427 on xfer. I should have added it to 4384a, sorry.
You can try the rebase now :)
Constantin Asofiei
12:53 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > I think is related to using a skeleton class. For example, at lea...
Marian Edu
12:42 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think is related to using a skeleton class. For example, at least the skeleton methods...
Marian Edu
12:40 PM Feature #4384: Builtin OO Implementation
I think is related to using a skeleton class. For example, at least the skeleton methods are missing the @extent@ for... Constantin Asofiei
12:39 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > @Constantin, the code generated still do...
Marian Edu
12:26 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > @Constantin, the code generated still doesn't work for us when in...
Marian Edu
12:16 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> In fact, you can always rebase an unbound 4384a branch from the latest 4231b on xfer and then @...
Marian Edu
12:15 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> @Constantin, the code generated still doesn't work for us when indeterminate extents are used. T...
Constantin Asofiei
12:08 PM Feature #4384: Builtin OO Implementation
> OK, we will continue to work with our local git repository and only I will push changes to bazaar to keep it simple... Greg Shah
11:49 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > There was no cast in the conversion rule and we didn't changed th...
Marian Edu
11:18 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Created branch 4384a, branched from 4231b revision 11425.
>
> Access it:
>
> @bzr co sftp:/...
Marian Edu
12:11 PM Bug #4602: fixes for OO 4GL and structured error handling
Another case to cover: simple statements with @NO-ERROR@, like @ch = h:name NO-ERROR.@ and @input from os-dir("missin... Constantin Asofiei

04/06/2020

03:31 PM Feature #4384: Builtin OO Implementation
Created branch 4384a, branched from 4231b revision 11425.
Access it:
@bzr co sftp://<userid>@xfer.goldencode.co...
Greg Shah

04/03/2020

09:54 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> There was no cast in the conversion rule and we didn't changed the rules simply modified the gen...
Constantin Asofiei
09:49 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
>
> W...
Marian Edu
09:38 AM Feature #4384: Builtin OO Implementation
Marian, there's a FWD conversion bug for this extent assign case. I'll fix it.
What's the signature for @assignMu...
Constantin Asofiei
09:25 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> fixes the reference but the uncheck cast is ugly to say at least :(
Changing the @assignMulti...
Marian Edu
09:15 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
Marian Edu

04/01/2020

01:13 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Tried various combinations, none seems to work. Anything else we ...
Marian Edu
12:59 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Tried various combinations, none seems to work. Anything else we need to do apart from @gradle j...
Constantin Asofiei
12:44 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
@Co...
Marian Edu
12:43 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > OK, so the one that already exist we do not 'refactor' but we nee...
Marian Edu
12:01 PM Feature #4384: Builtin OO Implementation
OK Greg Shah
11:34 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> OK, so the one that already exist we do not 'refactor' but we need to add them as exceptions.
...
Constantin Asofiei
11:30 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> This one, and maybe others, I think were added early on, and were written 'by hand', wit...
Marian Edu
11:17 AM Feature #4384: Builtin OO Implementation
> One way would be to find the p2j.oo equivalent automatically (searching for the LegacyResource annotation), and use... Greg Shah
11:11 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> That's exactly what we did and observed the pattern we described, problem is for instance @IHttp...
Constantin Asofiei
11:09 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter ru...
Constantin Asofiei
11:07 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConv...
Marian Edu
11:05 AM Feature #4384: Builtin OO Implementation
> Greg: for the skeleton classes, the Java equivalent is the one returned by our NameConverter rules - a IWebHandler ... Greg Shah
11:02 AM Feature #4384: Builtin OO Implementation
Greg: for the skeleton classes, the Java equivalent is the one returned by our @NameConverter@ rules - a @IWebHandler... Constantin Asofiei
11:01 AM Feature #4384: Builtin OO Implementation
>> Yes, but in Java we use "camel cased" names.
>
> camel case for variables, class names are still pascal case it ...
Greg Shah
09:57 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
>
> Yes, but in Java we use "camel cased" names.
camel case for variables, class names are still...
Marian Edu
09:46 AM Feature #4384: Builtin OO Implementation
> it seems the conversion translate the OE names to all lower for the package name
Yes. Except the @Progress@ and...
Greg Shah
08:56 AM Feature #4384: Builtin OO Implementation
Quick question on naming convention, for interfaces it seems the conversion translate the OE names to all lower for t... Marian Edu

03/31/2020

03:16 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> But didn't you mentioned c'tors are already treated differently in FWD? Not sure if we have that...
Constantin Asofiei
02:45 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> The error fixes mentioned in #4384-121 are in 4231b rev 11406 - xfer was updated.
OK,...
Marian Edu
02:41 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, d...
Marian Edu
02:31 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, what's the use case for the extent problem? Can you modify it so that it uses a ...
Marian Edu

03/30/2020

02:39 PM Bug #4602: fixes for OO 4GL and structured error handling
From #4384-121:
> I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic f...
Constantin Asofiei
02:32 PM Bug #4602 (Review): fixes for OO 4GL and structured error handling
Constantin Asofiei
02:31 PM Feature #4384: Builtin OO Implementation
Marian, what's the use case for the extent problem? Can you modify it so that it uses a fixed extent? Or to execute ... Constantin Asofiei
02:02 PM Feature #4384: Builtin OO Implementation
> From these, I think only the last two may need explicit fixing - as it looks like the ERROR can be 'eaten' by a par... Greg Shah
01:08 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynam...
Constantin Asofiei
12:55 PM Feature #4384: Builtin OO Implementation
I have FWD fixes for cases of 'nested' calls (for ctors, methods, internal procedures, dynamic functions), which cove... Constantin Asofiei
04:51 AM Feature #4384: Builtin OO Implementation
We have an issue with the 'extent' variables here, we get at NPE on @ArrayAssigner.registerDynamicArray@ because as t... Marian Edu

03/28/2020

12:17 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Maybe this is the issue, we're using an @internalProcedure@ block...
Marian Edu

03/27/2020

11:15 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Maybe this is the issue, we're using an @internalProcedure@ block for constructors so it should ...
Constantin Asofiei
10:00 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> A @RETUNR ERROR "foo"@ sets the @RETURN-VALUE@ in some cases. And if there is no @BLOCK...
Marian Edu
09:35 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> - there is no real difference between return error, return error new AppError (I think this stat...
Constantin Asofiei
09:26 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> OK, that is fair. We need to handle all cases with compatibility before implementing any optimiz...
Marian Edu
09:14 AM Feature #4384: Builtin OO Implementation
OK, that is fair. We need to handle all cases with compatibility before implementing any optimizations. Greg Shah
09:03 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.pr...
Constantin Asofiei
08:54 AM Feature #4384: Builtin OO Implementation
In regard to 4231b rev 11398, do we need to loop through the enclosing blocks in @BlockManager.processLegacyError()@ ... Greg Shah
07:19 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Marian Edu wrote:
> > Will try to change the test to see if that is still the case, right now t...
Constantin Asofiei
05:45 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Will try to change the test to see if that is still the case, right now the errors are not being...
Marian Edu
05:33 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
Marian Edu

03/26/2020

03:02 PM Feature #4384: Builtin OO Implementation
Eugenie Lyzenko wrote:
> I do not need to restart conversion for this change, right?
Reconversion is not needed.
Constantin Asofiei
02:54 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
...
Eugenie Lyzenko
02:43 PM Feature #4384: Builtin OO Implementation
I think your problem is now fixed in 4231b 11398 (xfer was updated, too). Please test.
The reason: I was processi...
Constantin Asofiei
01:55 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Creating an empty @hosts.txt@ file in working folder solved the issue though so we're all good n...
Constantin Asofiei
01:06 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> While writing this thought to regenerate the code for the tests and try again, it now seems the ...
Marian Edu
12:35 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Did eventually made a pu...
Marian Edu

03/24/2020

03:47 PM Feature #4384: Builtin OO Implementation
@bzr send@ would maintain the revision history. An alternative is to zip up only your changed files and send those. ... Greg Shah
03:44 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@.
Thanks Greg, quick quest...
Marian Edu
03:28 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> is the issue with error throwing from two or more level deep method call fixed already?
Yes, ev...
Constantin Asofiei
03:24 PM Feature #4384: Builtin OO Implementation
I have pushed revision 11389 to @xfer.goldencode.com:/opt/fwd/4231b@. Greg Shah
03:23 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, the changes are in 4231b rev 11389
>
> Some parts were a little tricky to fix...
Marian Edu
03:19 PM Feature #4384: Builtin OO Implementation
Marian, the changes are in 4231b rev 11389
Some parts were a little tricky to fix... sorry it took so long. If yo...
Constantin Asofiei
04:09 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> So, should we change Assert as it should using internalProcedure block and loadClass with static...
Constantin Asofiei
02:57 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Let me know if you have questions or need more test cases for thi...
Marian Edu
 

Also available in: Atom