Project

General

Profile

Activity

From 04/15/2020 to 05/14/2020

05/14/2020

06:24 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Marian, I need also tests about these:
* raised errors (QUIT, STOP, ERROR, etc)
* some tests for the before-table -...
Constantin Asofiei

05/13/2020

02:48 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
OK, do you know if you can use table with extent fields (or extent arguments) for SOAP requests? Constantin Asofiei
01:13 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Constantin Asofiei wrote:
> Marian, can you please run the full 'primitives' suite in SoapUI and commit the log? The...
Marian Edu
01:11 PM Feature #3310: add support for the equivalent of the OpenEdge Web Services Adapter (and ProxyGen)...
Marian, can you please run the full 'primitives' suite in SoapUI and commit the log? The current log has only a small... Constantin Asofiei
01:10 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> My current changes in @LegacyClass@:
My change here is on @getLegacyClass@ to call on ObjectOp...
Marian Edu
12:02 PM Feature #4384: Builtin OO Implementation
My current changes in @LegacyClass@:... Greg Shah
10:47 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Regarding previous use of @registerClass@, it turns out a legacy class must be registered before...
Constantin Asofiei
10:30 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I meant @pendingInitialized.pop()@, which needs to be done in @scopeFinished()@, as @s...
Marian Edu
10:12 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > OK, did that, pushed changes (rev 11557)...
Constantin Asofiei
10:10 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > OK, did that, pushed changes (rev 11557), seems to work now thank...
Marian Edu
09:22 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> OK, did that, pushed changes (rev 11557), seems to work now thanks.
You forgot a @pop@ for @pen...
Constantin Asofiei
07:41 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I think @ObjectOps.newInstanceInternal@ (the private one) needs to keep a registry of 'p...
Marian Edu
05:36 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I can try to get around this by directly using @setOption@ instead as that one returns logical s...
Constantin Asofiei
05:24 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, a few issues:
> * I don't understand all the @ObjectOps.registerClass@ calls - ...
Marian Edu

05/12/2020

06:30 PM Bug #4602: fixes for OO 4GL and structured error handling
Greg Shah wrote:
> I want to avoid using @undoThrow()@ everywhere in our runtime. This was designed to be used from...
Constantin Asofiei
06:01 PM Bug #4602: fixes for OO 4GL and structured error handling
I want to avoid using @undoThrow()@ everywhere in our runtime. This was designed to be used from within a @BlockMana... Greg Shah
05:48 PM Bug #4602: fixes for OO 4GL and structured error handling
Greg Shah wrote:
> 1. If I understand correctly, any direct usage of @new ErrorConditionException(...)@ will not wor...
Constantin Asofiei
01:10 PM Bug #4602: fixes for OO 4GL and structured error handling
I'm reproducing some discussion from #4349.
#4349-55:
>> Greg Shah wrote:
>>
>> Consider this code:
>>
>> ...
Greg Shah
05:22 PM Feature #4384: Builtin OO Implementation
Marian, a few issues:
* I don't understand all the @ObjectOps.registerClass@ calls - what was the reason you added t...
Constantin Asofiei
02:25 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > This is giving false twice, the object is not valid but no error ...
Marian Edu
01:43 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> This is giving false twice, the object is not valid but no error message. Debugging it I can see...
Constantin Asofiei
01:35 PM Feature #4384: Builtin OO Implementation
I'm going nuts over here, not the first time I have fun trying to figure out why an object can't be instantiated - so... Marian Edu
01:40 PM Bug #4355: exception member of the CATCH block can be referenced after the block catching it
Greg Shah wrote:
> Constantin: Can you link us to the discussion of your fix (and the revision of 4231b in which the...
Constantin Asofiei
01:18 PM Bug #4355 (Test): exception member of the CATCH block can be referenced after the block catching it
This is fixed in 4231b.
Constantin: Can you link us to the discussion of your fix (and the revision of 4231b in wh...
Greg Shah

05/08/2020

05:42 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Named events are used in some of the HTTP classes, I see there is conversion support for events....
Constantin Asofiei
05:27 AM Feature #4384: Builtin OO Implementation
Named events are used in some of the HTTP classes, I see there is conversion support for events. On subscribe/unsubsc... Marian Edu

05/07/2020

10:44 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> True, how about I rename it to @hasInstanceCtor@?
Yes, even better.
Constantin Asofiei
10:41 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> The change is functionally correct, but the @hasDefCtor@ var name no longer means what...
Marian Edu
10:37 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Look in @annotations/method_defs.rules@, the @check_ctors@ function and @hasDefCtor@ fla...
Constantin Asofiei
10:32 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Constantin Asofiei wrote:
> > > We need an int... but please add...
Marian Edu
10:20 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> You mean the @_constructor__@ method in FWD, right? I think you are correct here, we s...
Marian Edu
07:35 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Question about conversion of OO classes, in 4GL if there is any constructor defined the default ...
Constantin Asofiei
07:31 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> To be clear, I'm thinking about the built-in classes here. For example, we could provide alterna...
Constantin Asofiei
07:17 AM Feature #4384: Builtin OO Implementation
To be clear, I'm thinking about the built-in classes here. For example, we could provide alternate versions of @lega... Greg Shah
07:14 AM Feature #4384: Builtin OO Implementation
> > Constantin: Right now we don't have any mechanism to overload @@LegacyParameter@ signatures using Java literal ty... Greg Shah
06:13 AM Feature #4384: Builtin OO Implementation
Question about conversion of OO classes, in 4GL if there is any constructor defined the default no-parameters one is ... Marian Edu
08:23 AM Feature #4349: add support for 4GL ENUM
> I'm planning to emit specific versions of these in each flags enum subclass. They will call the worker at the paren... Greg Shah
07:24 AM Feature #4349: add support for 4GL ENUM
> > > Calling the one in super is fine. The problem is the return type - if the return type is the actual enum type,... Greg Shah
05:23 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Calling the one in super is fine. The problem is the ret...
Marian Edu

05/06/2020

05:54 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Constantin: Right now we don't have any mechanism to overload @@LegacyParameter@ signatures using...
Constantin Asofiei
05:05 PM Feature #4384: Builtin OO Implementation
Constantin: Right now we don't have any mechanism to overload @@LegacyParameter@ signatures using Java literal types ... Greg Shah
11:15 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Constantin, I see the getter methods are not used anymore but pub...
Greg Shah
11:08 AM Feature #4384: Builtin OO Implementation
Marian, the fix for #4384-266 is in 4384b rev 11545. This fixes the @test_char_longchar.p@ test. Please check your ... Constantin Asofiei
07:02 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin, I see the getter methods are not used anymore but public properties with no @LegacyS...
Constantin Asofiei
05:19 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Look at @UriEncodingTypeEnum@ and change all others to match this pattern.
>
Consta...
Marian Edu
03:52 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > We need an int... but please add some constants for these...
Marian Edu
03:38 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> We need an int... but please add some constants for these values, and not emit just @1@ ...
Constantin Asofiei
03:36 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Also, please make some changes, so that @LegacySignature.serializ...
Constantin Asofiei
03:03 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Also, please make some changes, so that @LegacySignature.serializable@ is a boolean flag...
Marian Edu
03:05 PM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> Calling the one in super is fine. The problem is the return type - if the return type i...
Constantin Asofiei
02:32 PM Feature #4349: add support for 4GL ENUM
Marian Edu wrote:
> Constantin Asofiei wrote:
> > For @FlagsEnum.cls@ - see @ClassDefinition.registerEnumMethods@.
...
Constantin Asofiei
05:14 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> For @FlagsEnum.cls@ - see @ClassDefinition.registerEnumMethods@.
>
> Here, we need to...
Marian Edu

05/05/2020

06:33 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Did pushed some testcase right now - oo\longchar\test_char_longchar.p. You will see the two can'...
Constantin Asofiei
04:51 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin, this seems to work but you should better take a look at it before... attached the pa...
Constantin Asofiei
01:40 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > FlagsEnum
>
> I'm editing this, is there anything for Marian to do?
Hmm... I don't think so...
Constantin Asofiei
01:17 PM Feature #4384: Builtin OO Implementation
> This includes LegacyEnum, FlagsEnum, and anything else runtime-specific for enums. (Greg, please correct me if I'm ... Greg Shah
12:28 PM Feature #4384: Builtin OO Implementation
I've rebased 4384b rev 11477 from 4231b rev 11524, new 4384b rev is 11544.
Marian, sorry but for some FWD code I t...
Constantin Asofiei
08:41 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Yes, push everything you have at this time. I want to review first, and if we can't m...
Marian Edu
08:32 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Yes it should be there already, I have some additional changes that I can push if you want to do...
Constantin Asofiei
08:30 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, is the @variable-sig.patch@ in 4384b? I want to start checking these and at leas...
Marian Edu
08:27 AM Feature #4384: Builtin OO Implementation
Marian, is the @variable-sig.patch@ in 4384b? I want to start checking these and at least rebase 4384b with latest 42... Constantin Asofiei
05:54 PM Feature #4635: bundle CREATE folowed by ASSIGN in a single statement
In terms of generated bytecode, the @tt1.createAndAssign("f1", "f2", "f3", 1, 2, 3);@ call actually takes ~2.5 more b... Constantin Asofiei
04:20 PM Feature #4635: bundle CREATE folowed by ASSIGN in a single statement
There are some cases where this pattern of a CREATE followed by an ASSIGN using only that temp-table's fields is used... Constantin Asofiei
04:14 PM Feature #4635 (New): bundle CREATE folowed by ASSIGN in a single statement
Constantin Asofiei
01:40 PM Feature #4349: add support for 4GL ENUM
For @FlagsEnum.cls@ - see @ClassDefinition.registerEnumMethods@.
Here, we need to add the proper signatures for al...
Constantin Asofiei
07:42 AM Feature #4349: add support for 4GL ENUM
For the infinite recursion - the issue was that @WidgetPool@ was calling @TM.getTransactionHelper()@ and @PM.getProce... Constantin Asofiei
07:29 AM Feature #4349: add support for 4GL ENUM
Greg, regarding the static c'tor problem: I think the @LegacyEnum.createEnumWorker@ should return @null@ if @Configur... Constantin Asofiei
05:05 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
>
> Please note that the code above will result in tracked objects (e.g. in the session object ch...
Marian Edu
02:27 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> Consider this code:
>
> [...]
>
> @LegacyErrorException@ extends @ErrorConditionException@ ...
Marian Edu

05/04/2020

05:45 PM Feature #3869: enhance JasperReports support with sub-reports and ProDataSets
The following are some answers by Stanislav to some questions related to Jasper and multiple queries.
> Is it poss...
Greg Shah
03:45 PM Feature #4349: add support for 4GL ENUM
Consider this code:... Greg Shah
11:55 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, I'm working on stabilizing 4231b conversion, and after that I'll work on integra...
Marian Edu
09:19 AM Feature #4384: Builtin OO Implementation
Marian, I'm working on stabilizing 4231b conversion, and after that I'll work on integrating/testing your changes. I... Constantin Asofiei
07:38 AM Feature #4384: Builtin OO Implementation
Ah, one question I've meant to ask before... in 4GL the compiler is less strict when it comes of longchar/character d... Marian Edu
07:31 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I've pushed the latest skeletons rev 93 to @https://proj.goldencode.com/downloads/skeletons/repo/...
Marian Edu
07:14 AM Feature #4384: Builtin OO Implementation
I've pushed the latest skeletons rev 93 to @https://proj.goldencode.com/downloads/skeletons/repo/@. Greg Shah
04:44 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I've applied the skeleton patch and some additional to rev 93
This is a revision of w...
Marian Edu
02:14 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I've applied the skeleton patch and some additional to rev 93
So, what shall we do? T...
Marian Edu

05/03/2020

02:43 PM Feature #4384: Builtin OO Implementation
I've applied the skeleton patch and some additional to rev 93 Constantin Asofiei

05/01/2020

02:14 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
Just documenting some articles related to this:
* This article (https://knowledgebase.progress.com/articles/Article/...
Roger Borrello
12:08 PM Feature #4349: add support for 4GL ENUM
4231b revision 11511 is the next pass at enum runtime and conversion, still unfinished. Registration has been modifie... Greg Shah
11:33 PM Feature #4349: add support for 4GL ENUM
I've checked in the first pass at the base classes. They are unfinished.
I've moved the creation of the data stru...
Greg Shah
10:07 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> # What is the conversion support status of the items in #4384-1?
Greg, as far as I know everyt...
Marian Edu
10:05 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> OK, I have changed all enums in skeleton to use the standard OE definition, do you want that as ...
Marian Edu
09:53 AM Feature #4384: Builtin OO Implementation
OK, I have changed all enums in skeleton to use the standard OE definition, do you want that as an eclipse patch or how? Marian Edu
09:13 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Greg/Marian, have you changed the skeleton classes to use DEFINE ENUM instead of propert...
Marian Edu
09:08 AM Feature #4384: Builtin OO Implementation
I have not. I have only pulled the @LegacyEnum@ and @FlagsEnum@ from 4384b and reworked those before commit in 4231b... Greg Shah
06:16 AM Feature #4384: Builtin OO Implementation
Greg/Marian, have you changed the skeleton classes to use DEFINE ENUM instead of property members, for the 4GL enums? Constantin Asofiei
03:00 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Marian: I am trying to get all the enums support from 4384b into 4231b. I hope to have this toni...
Marian Edu

04/30/2020

04:15 PM Feature #4384: Builtin OO Implementation
Marian: I am trying to get all the enums support from 4384b into 4231b. I hope to have this tonight, though there is... Greg Shah
11:01 AM Feature #4349: add support for 4GL ENUM
I've forgot to add the LegacySignature to the GetEnum method.
I don t plan to continue with enum conversion for no...
Constantin Asofiei
08:55 AM Feature #4349: add support for 4GL ENUM
> Constantin, do you think two maps are needed to handle say about 5-10 enum members that one might use? Those will b... Greg Shah
10:44 AM Bug #4628: redirection doesn't seem to close an output stream on a block retry
As noted above, the fact that the @MESSAGE SET@ output is not redirected in FWD is a known issue. We've never fixed ... Greg Shah
10:09 AM Feature #4395 (Test): add support for KEEP-MESSAGES option
Greg Shah

04/29/2020

06:09 PM Feature #4349: add support for 4GL ENUM
> One thing I wanted to mention about enums is those can be used in switch/case statements, also would be nice to mak... Greg Shah
05:57 PM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> The two @byValue@ and @byName@ maps will always hold all the enum values.
Constantin,...
Marian Edu
05:38 PM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> From Marian:
>
> > One thing I wanted to mention about enums is those can be used in switch/ca...
Marian Edu
05:32 PM Feature #4349: add support for 4GL ENUM
From Marian:
> One thing I wanted to mention about enums is those can be used in switch/case statements, also woul...
Greg Shah
04:47 PM Feature #4349: add support for 4GL ENUM
I was just about to check in all the LegacyEnum, FlagsEnum, and the fixups of all the existing enum subclasses. It l... Greg Shah
04:04 PM Feature #4349: add support for 4GL ENUM
Greg, the first pass at DEFINE ENUM conversion is in 4231b rev 11503. Please review.
The @oo/enums@ tests convert,...
Constantin Asofiei
03:17 PM Feature #4349: add support for 4GL ENUM
Good, I like it.
> Does someone have the FWD equivalent for FlagsEnum ?
These are checked in to 4384b. I will ...
Greg Shah
03:12 PM Feature #4349: add support for 4GL ENUM
Does someone have the FWD equivalent for @FlagsEnum@ ? Constantin Asofiei
03:06 PM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> This means that @first in list@ and @createEnum with 2nd and 3rd argument a String@ would both lo...
Constantin Asofiei
02:59 PM Feature #4349: add support for 4GL ENUM
Overall, I like the approach.
> The conversion rules will take care of linking these together, and the runtime wil...
Greg Shah
02:20 PM Feature #4349: add support for 4GL ENUM
I just checked in new tests for @Clone()@ (it doesn't work) and @Progress.Lang.Enum:ToObject()@ (works like @GetEnum(... Greg Shah
02:18 PM Feature #4349: add support for 4GL ENUM
Greg, my plan is for something like this:... Constantin Asofiei
12:47 PM Feature #4349: add support for 4GL ENUM
Greg, I've added stubs for @ObjectOps.newDynamicEnum@ and we also need a @ObjectOps.registerEnum(Class<? extends Lega... Constantin Asofiei
12:11 PM Feature #4349: add support for 4GL ENUM
Fixed in rev 559. These were mostly cases where I had tested the code and then later changed the include file withou... Greg Shah
11:53 AM Feature #4349: add support for 4GL ENUM
Greg, can you compile in 4GL all programs/classes in @oo/enums@? I have some weird errors:
* @oo.enums.Ordinals@ and...
Constantin Asofiei
11:12 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> > Can we rename @p2j.oo.lang.Enum@ to @p2j.oo.lang.LegacyEnum@? To avoid java conflicts...
>
>...
Marian Edu
11:11 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> Greg Shah wrote:
> > I don't think we need indexed lookup, but we do need to do an orde...
Marian Edu
11:00 AM Feature #4349: add support for 4GL ENUM
> Can we rename @p2j.oo.lang.Enum@ to @p2j.oo.lang.LegacyEnum@? To avoid java conflicts...
Yes.
Greg Shah
10:48 AM Feature #4349: add support for 4GL ENUM
Can we rename @p2j.oo.lang.Enum@ to @p2j.oo.lang.LegacyEnum@? To avoid java conflicts... Constantin Asofiei
10:20 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> Greg Shah wrote:
> > I don't think we need indexed lookup, but we do need to do an orde...
Constantin Asofiei
10:17 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> I don't think we need indexed lookup, but we do need to do an ordered (in the order of definition...
Constantin Asofiei
10:14 AM Feature #4349: add support for 4GL ENUM
> Or toggleFlag, unsetFlag, setFlag and getEnum are all we need?
This should be the list, but the toggleFlag, uns...
Greg Shah
10:00 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> How do you define an enum to extend @FlagsEnum@ in 4GL?
By using the @flags@ option.....
Marian Edu
09:52 AM Feature #4349: add support for 4GL ENUM
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Yes, I'll take the conversion. Do you have a comprehensive list ...
Constantin Asofiei
09:47 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> Yes, I'll take the conversion. Do you have a comprehensive list of all the static metho...
Marian Edu
09:36 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> Marian: Let me know when you have your latest enum changes in 4384b. I'll pull them and use th...
Marian Edu
09:22 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> Constantin: If you want to continue with the conversion, do let me know. I would then focus on t...
Constantin Asofiei
09:12 AM Feature #4349: add support for 4GL ENUM
Constantin: If you want to continue with the conversion, do let me know. I would then focus on the runtime parts.
...
Greg Shah
08:59 AM Feature #4349: add support for 4GL ENUM
> I've couldn't find a solution for using a Java enum though
Correct, we cannot use Java enums. The result must b...
Greg Shah
08:12 AM Feature #4349: add support for 4GL ENUM
Marian Edu wrote:
> I think right now the @Enum@ class holds references to all enum members (hash map on enum class)...
Constantin Asofiei
08:06 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> * I assume there will be a @BaseEnum@ super-class?
Why another @BaseEnum@ class, we alr...
Marian Edu
07:58 AM Feature #4349: add support for 4GL ENUM
Greg, about the review:
* I assume there will be a @BaseEnum@ super-class?
* we need to override @toLegacyString@ a...
Constantin Asofiei
07:55 AM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> Good. So far, your feedback is completely consistent with my plan.
I've couldn't find a solutio...
Marian Edu
07:10 AM Feature #4349: add support for 4GL ENUM
Good. So far, your feedback is completely consistent with my plan.
Constantin: I still need your thoughts on the ...
Greg Shah
06:40 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> The converted members need to be @object@ instances in FWD (with a ref to the actual enu...
Marian Edu
03:51 AM Feature #4349: add support for 4GL ENUM
Marian Edu wrote:
> I think if we use a private constructor and don't use @ObjectOps@ at all to create the enum memb...
Constantin Asofiei
02:45 AM Feature #4349: add support for 4GL ENUM
Constantin Asofiei wrote:
> A quick note, the enum values should be emitted like this:
> [...]
>
> As an enum va...
Marian Edu
06:02 PM Feature #4384: Builtin OO Implementation
I have some issues with the @URI@ encode/decode, the 4GL implementation is not really matching the one available in U... Marian Edu
06:21 AM Feature #4384: Builtin OO Implementation
Ah, forgot you are on windows. You need to add this node on the same level as @systemUser@, with the user's Windows p... Constantin Asofiei
05:57 AM Feature #4384: Builtin OO Implementation
Marian, the error is related to appserver agents. Do you have @Server ready@ message in the log? If yes, then non-web... Constantin Asofiei
05:52 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> OK, moving skeleton files in project root and let the p2j.cfg.xml as is seems to solve it.
As...
Marian Edu
05:19 AM Feature #4384: Builtin OO Implementation
OK, moving skeleton files in project root and let the p2j.cfg.xml as is seems to solve it. Marian Edu
05:06 AM Feature #4384: Builtin OO Implementation
Constantin, the update you've made on @testcases@ repository for the appsrv/rest kinda ruined the environment, at lea... Marian Edu
05:31 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
Constantin Asofiei wrote:
> Roger, anything related to retry should be ran from the command line and not the procedu...
Roger Borrello
03:19 PM Feature #4395: add support for KEEP-MESSAGES option
Task is ready for test. Roger Borrello

04/28/2020

07:15 PM Feature #4349 (WIP): add support for 4GL ENUM
Greg Shah
07:15 PM Feature #4349: add support for 4GL ENUM
The first set of runtime changes will be to get the parent classes (@Progress.Lang.Enum@ and @Progress.Lang.FlagsEnum... Greg Shah
06:47 PM Feature #4349: add support for 4GL ENUM
4231b rev 11498 contains conversion-related fixes for 4GL ENUM. This was done by chasing down INTERFACE_DEF, KW_INTE... Constantin Asofiei
06:27 PM Feature #4349: add support for 4GL ENUM
A quick note, the enum values should be emitted like this:... Constantin Asofiei
09:45 AM Feature #3853: implement LOG-MANAGER runtime
Constantin Asofiei wrote:
> See the @charRsp@ parameter - that's the inline definition.
Ah, I see... that is a plac...
Marian Edu
09:36 AM Feature #3853: implement LOG-MANAGER runtime
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > See @log_manager/common/dyn_objects.p@ and @profiler/procedur...
Constantin Asofiei
09:36 AM Feature #3853: implement LOG-MANAGER runtime
Constantin Asofiei wrote:
> See @log_manager/common/dyn_objects.p@ and @profiler/procedure_class/procedure.p@, thi...
Marian Edu
09:33 AM Feature #3853: implement LOG-MANAGER runtime
Marian Edu wrote:
> What test does that exactly Constantin, inline variable definition isn't possible in 4gl... both...
Constantin Asofiei
09:30 AM Feature #3853: implement LOG-MANAGER runtime
Constantin Asofiei wrote:
> I've seen something interesting in a logmanager test:
> [...]
>
> You can inline the...
Marian Edu
08:47 AM Feature #3853: implement LOG-MANAGER runtime
OK. Please create a task to record the problem so we don't forget it. Greg Shah
08:37 AM Feature #3853: implement LOG-MANAGER runtime
I've seen something interesting in a logmanager test:... Constantin Asofiei
08:49 AM Feature #4630: inline var definition for an OUTPUT parameter in an async RUN call
4GL allows inline of a var definition for at least this case:... Constantin Asofiei
08:48 AM Feature #4630 (New): inline var definition for an OUTPUT parameter in an async RUN call
Constantin Asofiei

04/27/2020

05:16 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
Roger, anything related to retry should be ran from the command line and not the procedure editor.
If you run it...
Constantin Asofiei
04:20 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
> The error message already has a conflicting use. (99) is not being reported by FWD, which must be an unsupported er... Greg Shah
12:21 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
New testcase: @./uast/io/redirected_stream_close_on_retry.p@:... Roger Borrello
11:36 AM Bug #4628: redirection doesn't seem to close an output stream on a block retry
Greg Shah wrote:
> Please cut this down to be something much smaller. I seriously doubt that more than 10% is neede...
Roger Borrello
03:59 PM Feature #3812 (Test): additions to SESSION system-handle
Greg Shah
12:22 PM Feature #3812: additions to SESSION system-handle
The changes are in 4231b rev 11490. Constantin Asofiei
01:47 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin Asofiei wrote:
> > I've edited #3855-102 with more details about the work required.
...
Constantin Asofiei
01:32 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Constantin Asofiei wrote:
> I've edited #3855-102 with more details about the work required.
Constantin, we're wo...
Marian Edu
01:00 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
I've edited #3855-102 with more details about the work required. Constantin Asofiei
12:56 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
I've configured the testcases project to be able to run the appsrv and rest tests:
* the appserver is state-free. I...
Constantin Asofiei
12:39 PM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
4231b rev 11490 contains improvements related to TABLE, DATASET and more. A summary of what is left:
For REST:
*...
Constantin Asofiei
12:24 PM Feature #3854: update appserver support with PASOE features
Some improvements are in 4231b rev 11490.
What is left is not PASOE related, after running a appserver test suite:...
Constantin Asofiei
10:02 AM Feature #4629: implement fully compatible 4GL collections (backed by protected temp-tables)
A simple version of the 4GL collections was implemented instead of the temp-table backed alternative in #4384.
As ...
Greg Shah
09:55 AM Feature #4629 (New): implement fully compatible 4GL collections (backed by protected temp-tables)
Greg Shah
08:48 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
>
> For now, let's do the simple approach and map things to the Java collections.
>
> As usu...
Marian Edu
08:44 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I have a question about collections/maps, the implementation in 4GL is based on temp-tables but ...
Greg Shah
05:04 AM Feature #4384: Builtin OO Implementation
I have a question about collections/maps, the implementation in 4GL is based on temp-tables but I would say using exi... Marian Edu
01:48 AM Bug #4602: fixes for OO 4GL and structured error handling
Constantin Asofiei wrote:
> Marian, a weird question: in case of argument validation errors for appserver calls, doe...
Marian Edu

04/26/2020

12:30 PM Bug #4602: fixes for OO 4GL and structured error handling
Marian, a weird question: in case of argument validation errors for appserver calls, does the caller's @block-level@ ... Constantin Asofiei
08:31 AM Bug #4628: redirection doesn't seem to close an output stream on a block retry
RETRY is a very specific thing. Better to say that than to say re-execution, which has no 4GL meaning. The problem ... Greg Shah

04/24/2020

06:13 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
Please cut this down to be something much smaller. I seriously doubt that more than 10% is needed. No prompting of ... Greg Shah
04:02 PM Bug #4628: redirection doesn't seem to close an output stream on a block retry
One of the behaviors of the 4GL and FWD when the error condition raised from i = integer("garbage"). is to jump execu... Roger Borrello
03:57 PM Bug #4628 (New): redirection doesn't seem to close an output stream on a block retry
Roger Borrello
01:49 PM Feature #3812: additions to SESSION system-handle
Greg Shah wrote:
> Conversion + stubs or full support?
Full support, with some restrictions. I'll document them onc...
Constantin Asofiei
01:48 PM Feature #3812: additions to SESSION system-handle
Conversion + stubs or full support? Greg Shah
01:41 PM Feature #3812: additions to SESSION system-handle
Following are added:
* @SESSION:CURRENT-REQUEST-INFO@ and @SESSION:CURRENT-RESPONSE-INFO@
* @server:REQUEST-INFO@ a...
Constantin Asofiei
01:49 PM Feature #4381 (Test): implement LIBRARY() and MEMBER() built-in functions
Greg Shah
01:48 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> @private static@ methods should be after all @public static@ methods in a file.
Oops. Sorry. U...
Roger Borrello
01:37 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
@private static@ methods should be after all @public static@ methods in a file. Greg Shah
01:24 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
... Roger Borrello
12:47 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Minor edits:... Greg Shah
12:38 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> It is a useless feature. For now, I see no reason to add it. We could handle the file part, but...
Roger Borrello
11:53 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
It is a useless feature. For now, I see no reason to add it. We could handle the file part, but even that has no me... Greg Shah
11:47 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
It does look like @SEARCH@ needs some work, because when you pass "filename.pl<<member.r>>" the 4GL is able to find t... Roger Borrello
10:55 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> 4. Have you confirmed the following?
>
> * Does it matter whether or not the procedure library...
Roger Borrello
10:41 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Code Review Task Branch 4231b Reviison 11480
Overall, it is good.
1. In @FileSystemOps", move the new @private ...
Greg Shah
01:38 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> gets converted to
> [...]
Found it, probably serialization not needed yet but was a fun lear...
Marian Edu
01:12 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I didn't yet look into the @Web@ package and that is tight to the PASOE and web handlers mainly ...
Constantin Asofiei
12:56 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Marian: Other than the missing enum stuff which I am resolving, is there anything else blocking y...
Marian Edu
12:39 PM Feature #4384: Builtin OO Implementation
Marian: Other than the missing enum stuff which I am resolving, is there anything else blocking you from delivering t... Greg Shah
07:31 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> For variables/properties, the changes would be at the beginning of the @convert/variab...
Marian Edu
01:33 PM Feature #4392: add -pf support for appserver CONNECT() method
Greg Shah wrote:
> This task is for the "server" handle-based resource (the appserver 4GL features, not database) an...
Igor Skornyakov
01:21 PM Feature #4392: add -pf support for appserver CONNECT() method
This task is for the "server" handle-based resource (the appserver 4GL features, not database) and the method @CONNEC... Greg Shah
01:07 PM Feature #4392: add -pf support for appserver CONNECT() method
Greg Shah wrote:
> What is the status of this task?
This was done in the scope of #3813.
Igor Skornyakov
11:43 AM Feature #4392: add -pf support for appserver CONNECT() method
What is the status of this task? Greg Shah
01:06 PM Feature #4349: add support for 4GL ENUM
> maybe we can prevent those from being deleted and not show in session objects list somehow
Yes, as noted above t...
Greg Shah
01:02 PM Feature #4349: add support for 4GL ENUM
Greg Shah wrote:
> > I have a draft implementation for Enum and FlagsEnum that I've refactored so maybe the generato...
Marian Edu
12:37 PM Feature #4349: add support for 4GL ENUM
> I have a draft implementation for Enum and FlagsEnum that I've refactored so maybe the generator could start using ... Greg Shah
08:31 PM Feature #4349: add support for 4GL ENUM
h2. 4GL Behavior/Functionality
* Enums are implicitly final subclasses of @Progress.Lang.Enum@ (regular enums) or ...
Greg Shah

04/23/2020

02:18 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian: please try my previous suggestions and repost the patch.
Wouldn't be easier to ...
Marian Edu

04/22/2020

11:39 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, another question please: who/when sets the @SERVLET_SRVR_...
Constantin Asofiei
11:23 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Constantin Asofiei wrote:
> Marian, another question please: who/when sets the @SERVLET_SRVR_DEBUG@ and @SERVLET_SER...
Marian Edu
10:42 AM Feature #3855: implement equivalent support for REST (classic appserver, PASOE REST and WEB trans...
Marian, another question please: who/when sets the @SERVLET_SRVR_DEBUG@ and @SERVLET_SERVER_APP_MODE@ CGI vars? I ca... Constantin Asofiei
10:50 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > Greg: please fix the permissions, I can't even do a checkout from https://proj.goldencode.com/d...
Constantin Asofiei
10:45 AM Feature #4384: Builtin OO Implementation
> Greg: please fix the permissions, I can't even do a checkout from https://proj.goldencode.com/downloads/skeletons/r... Greg Shah
10:37 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > I would try @bzr diff -p1 -r <your checkout revision>@ so th...
Constantin Asofiei
10:34 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, quick question - do you have the @toString@ method for @net.Uri@ class implement...
Marian Edu
10:32 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I would try @bzr diff -p1 -r <your checkout revision>@ so that on our side we can use...
Marian Edu
10:18 AM Feature #4384: Builtin OO Implementation
Marian, quick question - do you have the @toString@ method for @net.Uri@ class implemented? If not, I'm adding it in ... Constantin Asofiei
10:16 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> That sounds like fun, now that I can debug the whole conversion process this might be interestin...
Constantin Asofiei
10:15 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Should I try again a 'bzr send' for the skeleton or how should we send the changes there?
T...
Marian Edu
10:11 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > I see properties are converted to getter/setter methods and are a...
Marian Edu
10:06 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> I see properties are converted to getter/setter methods and are annotated with the name as defin...
Constantin Asofiei
09:56 AM Feature #4384: Builtin OO Implementation
I see properties are converted to getter/setter methods and are annotated with the name as defined in 4GL, for variab... Marian Edu
06:15 AM Feature #4349: add support for 4GL ENUM
Hi Greg, we need @FlagsEnum@ for reflection so tried to implement something for this but there seems this is not yet ... Marian Edu

04/21/2020

06:05 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> Being more explicit about returning unknown when the input is unknown is a good practice. The fa...
Roger Borrello
05:48 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Added a simpler testcase @uast/library_calls/library_member2.p@ Roger Borrello
05:32 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Being more explicit about returning unknown when the input is unknown is a good practice. The fact that the matching... Greg Shah
05:22 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Roger Borrello wrote:
> Greg Shah wrote:
> > You will need to add the proper error handling, but otherwise it is fi...
Roger Borrello
05:18 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Greg Shah wrote:
> I don't see anything obviously wrong. The code seems like it should work.
>
> You will need t...
Roger Borrello
05:04 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
I don't see anything obviously wrong. The code seems like it should work.
You will need to add the proper error h...
Greg Shah
04:39 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Made the changes to allow the pattern to be pre-compiled, but it no longer matches the given string.... Roger Borrello
02:53 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Code Review Task Branch 4231b Revision 11479
This is quite good. Here are some things to fix to make it better.
...
Greg Shah
02:19 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Ready for review...... Roger Borrello
02:14 PM Feature #4381 (WIP): implement LIBRARY() and MEMBER() built-in functions
Roger Borrello
12:43 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
That makes sense. Greg Shah
12:27 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Roger Borrello wrote:
> Should these be placed nearby @SEARCH@ in @FileSystemOps@ like @searchLibrary@ and @searchMe...
Roger Borrello
12:25 PM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Should these be placed nearby @SEARCH@ in @FileSystemOps@ like @searchLibrary@ and @searchMember@? Roger Borrello
10:55 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Created @uast/library_member.p@ testcase based off some customer code. However, the use of @LIBRARY@ in the sample do... Roger Borrello
10:41 AM Feature #4381: implement LIBRARY() and MEMBER() built-in functions
Useful background information on libraries: https://documentation.progress.com/output/ua/OpenEdge_latest/index.html#p... Roger Borrello
03:29 PM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> Code Review Task branch 4231b Revision 11470
>
> 1. In @KEEP-MESSAGES@ mode, have you checked ...
Roger Borrello
10:07 AM Feature #4395: add support for KEEP-MESSAGES option
Don't change existing sample code in a way that destroys the original intent and control flow. Add a new testcase an... Greg Shah
09:16 AM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> What is the testcase? Why is it retrying instead of exiting?
It is @uast/io/basic_redirecte...
Roger Borrello
08:48 AM Feature #4395: add support for KEEP-MESSAGES option
> It's difficult to determine how the 4GL is actually handling this. Perhaps it implicitly closes the stream, and we ... Greg Shah
05:38 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> OK, I see that we are missing from @Progress.Lang.Class@ the methods which resolve a cla...
Marian Edu
05:37 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @i...
Constantin Asofiei
05:29 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @invoke@ calls when @Para...
Marian Edu
05:18 AM Feature #4384: Builtin OO Implementation
Marian, I'm mostly interested in @Progress.Lang.Class:new@ and @invoke@ calls when @ParameterList@ is involved (so ye... Constantin Asofiei
04:59 AM Feature #4384: Builtin OO Implementation
Quick question about @P.L.Class@ as that is listed in the short list there... do you need reflection support for that... Marian Edu

04/20/2020

04:53 PM Feature #4395: add support for KEEP-MESSAGES option
I have updates to correct behavior where @Press space bar to continue@ was displayed in ChUI, even though output was ... Roger Borrello
03:38 PM Feature #4395: add support for KEEP-MESSAGES option
Roger, PUT SCREEN issues in GUI are known, see #2372. Constantin Asofiei
03:31 PM Feature #4395: add support for KEEP-MESSAGES option
I am not seeing the testcases @put screen...@ show up in GUI like it does in 4GL. In @ThinClient@, the @putScreen@ me... Roger Borrello
02:32 PM Feature #4395: add support for KEEP-MESSAGES option
The latter seems most likely the same issue as #4619. Roger Borrello
02:27 PM Feature #4395: add support for KEEP-MESSAGES option
Code Review (cont.)
2. In @LowLevelStream@ and @StreamDaemon@ you need to add an @id@ parameter javadoc entry for...
Greg Shah
02:23 PM Feature #4395: add support for KEEP-MESSAGES option
Code Review Task branch 4231b Revision 11470
1. In @KEEP-MESSAGES@ mode, have you checked the following behavior?
...
Greg Shah
02:01 PM Feature #4395: add support for KEEP-MESSAGES option
> An unrelated issues has to do with how display "Last Line" with frame f-last. is handled, with message "A message."... Greg Shah
01:45 PM Feature #4395 (WIP): add support for KEEP-MESSAGES option
Roger Borrello
01:45 PM Feature #4395: add support for KEEP-MESSAGES option
Ready for review.... Roger Borrello
11:40 AM Feature #4395: add support for KEEP-MESSAGES option
In the spirit of "learning to fish", you could use the following to answer the question yourself:
@my-int-var = in...
Greg Shah
11:16 AM Feature #4395: add support for KEEP-MESSAGES option
Now we are cooking... @keepMessages@ is now available to the client in the critical location.
At looking at the s...
Roger Borrello
09:30 AM Feature #4395: add support for KEEP-MESSAGES option
> I do know my breakpoint in StreamDaemon.setKeepMessages(int id) doesn't get hit.
This breakpoint will be hit in ...
Greg Shah
09:27 AM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> See @ThinClient.getCurrentRedirection()@.
On the server side, @RemoteStream.setKeepMessages@ i...
Roger Borrello
07:22 AM Feature #4395: add support for KEEP-MESSAGES option
See @ThinClient.getCurrentRedirection()@. Greg Shah
01:02 AM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> > Do I still need to fiddle with RemoteStream if I am converting as:
>
> Yes. @RemoteStream@ ...
Roger Borrello

04/19/2020

05:45 PM Feature #4395: add support for KEEP-MESSAGES option
> Do I still need to fiddle with RemoteStream if I am converting as:
Yes. @RemoteStream@ is how it gets to the cl...
Greg Shah
05:14 PM Feature #4395: add support for KEEP-MESSAGES option
Greg Shah wrote:
> @getKeepMessages()@ should be named @isKeepMessages()@ since the flag is a @boolean@. The standa...
Roger Borrello
10:35 AM Feature #4395: add support for KEEP-MESSAGES option
@getKeepMessages()@ should be named @isKeepMessages()@ since the flag is a @boolean@. The standard for Java "bean" n... Greg Shah
10:16 AM Feature #4395: add support for KEEP-MESSAGES option
It looks like there is a bug in @LogicalTerminal.message()@ whereby the output stream is never checked for redirectio... Roger Borrello
09:58 AM Feature #4395: add support for KEEP-MESSAGES option
That part is straightforward. I am using @setKeepMessages()@ without a parameter because it is an option that default... Roger Borrello

04/18/2020

06:40 AM Feature #4395: add support for KEEP-MESSAGES option
> I would just call the setter directly as setKeepMessages(true), instead of modifying the StreamFactory APIs.
Agr...
Greg Shah

04/17/2020

06:49 PM Feature #4395: add support for KEEP-MESSAGES option
Greg/Roger: the IO options can be emitted as a setter; see this portion of @convert/input_output.rules@:... Constantin Asofiei
06:39 PM Feature #4395: add support for KEEP-MESSAGES option
Please look at @StreamFactory@. You will see that it is stateless in regard to new streams. The @KEEP-MESSAGES@ fla... Greg Shah
05:18 PM Feature #4395: add support for KEEP-MESSAGES option
The @input_output.rules@ do not do anything with the @KEEP-MESSAGES@ options. There is the possibility of adding an a... Roger Borrello
03:49 PM Feature #4395: add support for KEEP-MESSAGES option
Updated testcase @uast/binary/read-text-and-binary.p@ to show there is no differences in having @keep-messages@ on th... Roger Borrello
02:27 PM Feature #4395: add support for KEEP-MESSAGES option
... Roger Borrello
12:33 PM Feature #4395: add support for KEEP-MESSAGES option
... Roger Borrello

04/16/2020

03:58 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Marian, just do a bzr revert and bzr clean-tree - to cleanup ...
Constantin Asofiei
03:35 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, just do a bzr revert and bzr clean-tree - to cleanup after the update.
OK, ...
Marian Edu
03:17 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Greg Shah wrote:
> > Branch 4384b was created from 4231b revision 11458. Access it using @bzr ...
Constantin Asofiei
03:02 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer...
Marian Edu
08:16 PM Feature #4384: Builtin OO Implementation
4384a was archived as dead on devsrv01. Please note that I was unable to @bzr push --overwrite@ on devsrv01 so I zip... Greg Shah
08:14 PM Feature #4384: Builtin OO Implementation
Branch 4384b was created from 4231b revision 11458. Access it using @bzr co sftp://<userid>@xfer.goldencode.com/opt/... Greg Shah

04/15/2020

06:44 PM Feature #4384: Builtin OO Implementation
> I think we should preserve 4384a as a dead branch on devsrv01 and create 4384b.
Will do.
Greg Shah
06:38 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> # rebase 4231b from trunk 11346
The rebase of 4231b is done.
> # replace the 4384a branch with ...
Constantin Asofiei
05:57 PM Feature #4384: Builtin OO Implementation
> Greg: can you please update the web repo?
Done.
Greg Shah
05:40 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> I think the faster way is to:
>
> # merge the exact revisions from 4384a into 4231b
The 11426...
Constantin Asofiei
05:36 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
>
> > Yes, please zip it and upload it to xfer.
> I'm confused as ...
Constantin Asofiei
04:25 PM Feature #4384: Builtin OO Implementation
I think the faster way is to:
# merge the exact revisions from 4384a into 4231b
# rebase 4231b from trunk 11346
...
Greg Shah
02:06 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
>
> I'm trying to...
Constantin Asofiei
01:40 PM Feature #4384: Builtin OO Implementation
Marian, did you do a bzr merge or bzr rebase for 4384a, with 4231b?
I'm trying to rebase 4384a from 4231b, and I t...
Constantin Asofiei
12:47 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Yes, please zip it and upload it to xfer.
I'm confused as of what you refer to when y...
Marian Edu
12:32 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian Edu wrote:
> > > Did pulled the skeleton fresh and sync t...
Constantin Asofiei
12:31 PM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian Edu wrote:
> > Did pulled the skeleton fresh and sync the two folders, attached ...
Marian Edu
12:03 PM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Did pulled the skeleton fresh and sync the two folders, attached the patch.
Where did you pull ...
Constantin Asofiei
11:21 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> OK, do let me know when they are there. I need to do a review and see if they can be me...
Marian Edu
10:48 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Will try to push the changes to 4384a now
OK, do let me know when they are there. I need to do...
Constantin Asofiei
10:45 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, are all your 4384a changes pushed to xfer?
>
> Also, please upload to xfer th...
Marian Edu
10:22 AM Feature #4384: Builtin OO Implementation
Marian, are all your 4384a changes pushed to xfer?
Also, please upload to xfer the full skeleton project, with you...
Constantin Asofiei
 

Also available in: Atom