Project

General

Profile

Activity

From 04/20/2021 to 05/19/2021

05/19/2021

03:31 AM Feature #4384: Builtin OO Implementation
Trying some 4GL code for the same and how it gets converted guess the easiest is to simply not use any 'local' variab... Marian Edu
03:16 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> Branch 4384j was merged into branch 3821c as revision 12363.
>
> Created new branch 4384k from...
Marian Edu

05/14/2021

06:18 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
FWD complains on the very first test with @Incompatible datatypes found during runtime conversion. (5729)@... Roger Borrello
06:07 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
Here is the completed testcase, along with the expected outcomes. Checked in as @uast/compare_various_buffer-values.p... Roger Borrello
12:27 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
Now try with int, logical, decimal, character, etc fields. Constantin Asofiei
12:20 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
This testcase:... Roger Borrello
10:54 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
Roger, I think for the POLY case 4GL doesn't convert the right operand to the left operand's type.
We currently fo...
Constantin Asofiei
10:52 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
The 4GL doesn't make a conversion of the @"today"@ string to a date when performing the comparison, so @h:buffer-fiel... Roger Borrello

05/10/2021

11:36 AM Bug #5296: output parameters are cleared if an argument is another function call
I think the @wrap@ methods for the field, property and other cases should return a BDT anon-class which overrides a @... Constantin Asofiei
06:10 AM Bug #5296: output parameters are cleared if an argument is another function call
Greg, I remembered the reason why this @wrap@ was needed and the registration was done at the caller, and not the def... Constantin Asofiei

05/05/2021

01:50 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
I don't recall the @table-handle for@ version, but from what I can see, this case just specifies the real handle var ... Constantin Asofiei
01:35 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Wait, I see 1 difference. The initialization of the @gh@ handle. Is that the only difference that is supposed to be... Greg Shah
01:34 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Constantin: I think the "table-handle for" case has been regressed. Or perhaps I misunderstand the idea.
I found ...
Greg Shah

05/04/2021

10:17 AM Feature #4384: Builtin OO Implementation
Branch 4384j was merged into branch 3821c as revision 12363.
Created new branch 4384k from 3821c rev 12363. The n...
Greg Shah
08:05 AM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> It is not merged yet. I just pushed the latest 3821c to xfer (rev 12362). Please post the @bzr ...
Marian Edu
07:47 AM Feature #4384: Builtin OO Implementation
It is not merged yet. I just pushed the latest 3821c to xfer (rev 12362). Please post the @bzr send@ of the merged ... Greg Shah
06:05 AM Feature #4384: Builtin OO Implementation
@Greg, did you merged that already and created a new branch that we need to pick-up or not just yet? I have local cha... Marian Edu

04/30/2021

12:33 PM Feature #4384: Builtin OO Implementation
> there are some compatibility and 'business entity' handlers as well as some extra classes I don't remember right no... Greg Shah
12:14 PM Feature #4384: Builtin OO Implementation
Greg Shah wrote:
> > I'm working on dynamic invoke (class/method/ctor) - right now trying to close @ParameterList@
...
Marian Edu
12:01 PM Feature #4384: Builtin OO Implementation
> I'm working on dynamic invoke (class/method/ctor) - right now trying to close @ParameterList@
Are the @WebHandle...
Greg Shah
09:26 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
As part of the shift to a subclass approach for @TableParameter@ and @DataSetParameter@, I'm also making the followin... Greg Shah

04/29/2021

11:04 AM Feature #4384: Builtin OO Implementation
> was that done on purpose, is there a catch or I can just replace that with @BaseDataType.incompatibleTypesOnConvers... Greg Shah
09:14 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> Don't we already process parent interfaces before child interfaces and imlemented interfaces be...
Constantin Asofiei
08:53 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
> But non-override methods will need to not collide with any Java method name from the hierarchy (this includes prope... Greg Shah
08:28 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Hmm... a two-pass approach I think it might work.
But non-override methods will need to not collide with any Java ...
Constantin Asofiei
08:17 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
My idea was this:
* We already convert the entire parent hierarchy before any child classes.
* In the parent, we ...
Greg Shah
02:51 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
The main reason this is JVM wide is because I couldn't find a way to solve this case.
You have a @Foo.m1@ and @Foo...
Constantin Asofiei
08:24 AM Bug #5296: output parameters are cleared if an argument is another function call
Since we are making this change, we could modify the @wrap()@ to be @outputParm()@ or @inputOututParm()@ and remove t... Greg Shah
08:08 AM Bug #5296: output parameters are cleared if an argument is another function call
It doesn't work to move this registration at @init()@, because the reference needs to change - and in lambda we can't... Constantin Asofiei
07:43 AM Bug #5296: output parameters are cleared if an argument is another function call
Code Review Task Branch 3821c Revision 12345
The changes themselves should do what you intend.
The biggest issu...
Greg Shah
05:57 AM Bug #5296: output parameters are cleared if an argument is another function call
The current changes are too aggressive, I need to limit them for only if there are OUTPUT/INPUT-OUTPUT parameters on ... Constantin Asofiei

04/28/2021

05:43 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
@SymbolResolver.WorkArea.javaMethodCollisions@ is a JVM-wide map that stores the javaname mapped to a given Java sign... Greg Shah
03:19 PM Bug #5296 (WIP): output parameters are cleared if an argument is another function call
The fix is in 3821c rev 12345
An improvement would be to emit @evaluate(() -> ...)@ only if there are no output/in...
Constantin Asofiei
02:10 PM Bug #5296: output parameters are cleared if an argument is another function call
If a call has output/input-output parameters, and also a function call, then the output argument registration is lost... Constantin Asofiei
02:01 PM Bug #5296 (Closed): output parameters are cleared if an argument is another function call
Constantin Asofiei
11:02 AM Bug #5294: parsing problems for assign-style statements with a OO chained lvalue
In OE, is possible to use an OO property or variable as the lvalue for an assign-style-statement. FWD can't parse th... Constantin Asofiei
10:59 AM Bug #5294 (Closed): parsing problems for assign-style statements with a OO chained lvalue
Constantin Asofiei
07:14 AM Feature #4384: Builtin OO Implementation
I'm working on dynamic invoke (class/method/ctor) - right now trying to close @ParameterList@ - and one aspect we're ... Marian Edu

04/27/2021

03:43 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> There should be plenty of calls like @hCall:set-parameter@ in that file, hCall is a handle and t...
Marian Edu
03:31 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> I don't see @call:set-parameter@ used here.
There should be plenty of calls like @hCa...
Marian Edu
03:21 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> Constantin Asofiei wrote:
> > Marian, please point me to the test which fails.
>
> oo/progre...
Constantin Asofiei
03:14 AM Feature #4384: Builtin OO Implementation
Constantin Asofiei wrote:
> Marian, please point me to the test which fails.
oo/progress/lang/parameter_list/test...
Marian Edu
03:11 AM Feature #4384: Builtin OO Implementation
Marian, please point me to the test which fails. Constantin Asofiei
01:45 AM Feature #4384: Builtin OO Implementation
Marian Edu wrote:
> It gives "No param_index annotation found"... hmm, looking at it in our tests we also use @set-p...
Marian Edu
01:37 AM Feature #4384: Builtin OO Implementation
Constantin, we have an issue with the conversion for tests that uses @Progress.Lang.ParameterList.setParameter@ metho... Marian Edu

04/26/2021

06:11 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
This use case actually comes back true instead of false, as happens in 4GL:... Roger Borrello
04:33 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
I think I understand what you are saying. This situations comes up when a new @date@ is created in an effort to perfo... Roger Borrello
01:15 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
This testcase isn't about regular date processing. It is about polymorphic type processing. All the @buffer-field()... Greg Shah
12:07 PM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
This update to the @date(BaseDataType)@ constructor does create @Unknown@ when an empty string is passed in:... Roger Borrello
10:55 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
Roger Borrello wrote:
> Just swapping the comparison operands so we go into @text.compareTo@ instead of @date.compar...
Roger Borrello
09:38 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
Constantin Asofiei wrote:
> Roger Borrello wrote:
> > Also, still awaiting review of the update mentioned in #5215-...
Roger Borrello
09:27 AM Bug #5288: Some date field character comparisons have runtime incompatibilities during runtime
Comparisons of @date@ fields to certain characters have problems. See testcase:... Roger Borrello
09:19 AM Bug #5288 (New): Some date field character comparisons have runtime incompatibilities during runtime
Roger Borrello
08:53 PM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
All of the following cases are converted to @TableParameter@:
* @INPUT TABLE@
* @INPUT-OUTPUT TABLE@
* @OUTPUT T...
Greg Shah

04/22/2021

03:28 PM Bug #5278: IMPORT UNFORMATTED raw with a process stream
In OE, you can call @IMPORT UNFORMATTED@ on a raw variable, with a file or process stream. In case of file, it behav... Constantin Asofiei
03:25 PM Bug #5278 (New): IMPORT UNFORMATTED raw with a process stream
Constantin Asofiei
08:44 AM Bug #5276: resolve issues with multi-byte character processing
We need to review our text processing (throughout the FWD runtime) to ensure that multi-byte character processing is ... Greg Shah
08:37 AM Bug #5276 (New): resolve issues with multi-byte character processing
Greg Shah

04/20/2021

07:20 PM Bug #4754 (Closed): DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Greg Shah
05:53 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
All is well... at least as far as this task is concerned. Roger Borrello
04:32 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
No, @DYNAMIC-FUNCTION()@ is not used in that code. If you confirm all is well, I will close it. Greg Shah
04:09 PM Bug #4754: DYNAMIC-FUNCTION parsing fails when first parameter is not an expression
Was this waiting for the large ChUI regression to complete in order to be closed? Roger Borrello
03:39 PM Support #4032: block/transaction processing context-local and other performance improvements
I had previously created the NO_TRANSACTION task in #4149. Greg Shah
12:34 PM Bug #4741 (Closed): RUN statement with a path to a procedure that does not have any extension fai...
Greg Shah
12:04 PM Bug #4741 (Review): RUN statement with a path to a procedure that does not have any extension fai...
I cannot see any reason to leave this task open. Roger Borrello
07:56 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
Greg Shah wrote:
> My changes have certainly broken this part.
>
> > Note that for table-handle and dataset-handl...
Constantin Asofiei
07:46 AM Feature #4350: method overload when they differ by a temp-table, dataset, buffer or object or ext...
My changes have certainly broken this part.
> Note that for table-handle and dataset-handle, the 4GL argument type...
Greg Shah
 

Also available in: Atom