Activity

From 06/28/2013 to 07/27/2013

09:00 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: The last drop was replaced with one including manifest changes. The runtime testing has been started. Eugenie Lyzenko
08:38 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: > The question: do I need to manually remove charva package in testing directory before start runtime testing? Or thi... Greg Shah
08:30 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: The drop with ConsoleDriver.java javadoc change. Going to test in devsrv01.
The question: do I need to manually re... Eugenie Lyzenko
08:17 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: OK, good. Greg Shah
08:16 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: > 1. You can remove the javadoc text from ConsoleDriver:
>
> * <p>
> * This replaces CHARVA driver.
>
> We don... Eugenie Lyzenko
07:59 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Code Review 0725a
1. You can remove the javadoc text from ConsoleDriver:... Greg Shah

06:45 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Additional files with references to CHARVA included in this drop to modify:
com/goldencode/p2j/ui/client/driver/Scre... Eugenie Lyzenko
01:31 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: > I can offer to place KeyProcessor.java under com/goldencode/p2j/ui/client/chui/driver/console. Is it OK?
Yes, it... Greg Shah
11:06 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: > When do you think you will be ready to test? It looks pretty close.
OK. I'll clean up the code soon and perform ... Eugenie Lyzenko
09:06 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: To be clear, I want you to get this tested, working and checked in before you do any work on the WIN32 version of the... Greg Shah
09:05 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Code Review 0724a
Overall, this is very good. Some minor things:
1. The copyright notice for ConsoleHelper is ... Greg Shah
08:48 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: I like the overall approach. The changes to make it console/Console* instead of ncurses/Ncurses* is very good. It i... Greg Shah

06:29 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: This is the first proposal for native implementation for Linux only. The Windows native part is still missing. But it... Eugenie Lyzenko

09:30 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Another offering is to move the helper class interfacing to JNI - ConsoleHelper to better location for example com/go... Eugenie Lyzenko
07:18 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: The drop includes java part of suggested changes for review. The native C code structure will depends on which way we... Eugenie Lyzenko

07:19 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: After rethink I would offer to rename:
- ncurses/NcursesDriver.java
to
- console/ConsoleDriver.java
and
- ncurse... Eugenie Lyzenko
06:18 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Another point to discuss is related to the terminal calls in Windows C code. I can see two options here:
1. Use Cons... Eugenie Lyzenko
12:13 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: The implementation plan:
1. Create two new classes in com/goldencode/p2j/ui/client/chui/driver:
- ncurses/NcursesDriv... Eugenie Lyzenko

04:15 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Some thoughts:
1. I don't see anything in addStringNative() that looks protectible. The entire function can be pu... Greg Shah
12:22 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Another word we can use readKey() untouched? May be removing try_again: label which is never used now. Eugenie Lyzenko
12:16 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: The code inside EVL<< .. EVL>> "braces" duplicates the original CHARVA source. The other code outside "braces" - GCD ... Eugenie Lyzenko
07:29 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: > 1. The calls detected as never used can be just ignored, we do not need to implement them in charva replacement, co... Greg Shah

06:07 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: The function list used in native NCURSES based code from charva.Toolkit.java(Java end, the JNI names to be implemente... Eugenie Lyzenko

05:09 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...: Attached are the versions of the Toolkit.c which are important to review (and the diffs between them).
Some import... Greg Shah

Also available in: Atom

FWD » Core Development » User Interface