Activity
From 07/17/2013 to 08/15/2013
08/15/2013
- 01:49 PM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- Go ahead with the ReadConsoleInput() version.
- 01:34 PM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- On Linux it returns 304 or 414 for F4 for example. On Windows _getch() returns 0x3E or 62 in decimal, so looks like n...
- 01:09 PM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- > I prefer to use ReadConsoleInput() console API if there is no objections. It is low-level console input function an...
- 11:57 AM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- > ... But it is very important to support attributes (e.g. underline, reverse...). These are heavily used in ChUI cod...
- 08:06 AM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- At this time our character driver for NCURSES doesn't support real colors either. But it is very important to suppor...
- 08:05 PM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- The next drop for review. This is the first workable version. The main issue I struggled with is character coding to ...
07/31/2013
- 02:48 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- I forgot: the src/com/goldencode/p2j/ui/client/chui/driver/charva/* has to be removed too. I did that now in bzr rev...
- 02:45 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Make sure to list the files that were removed in your distribution email.
- 02:44 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- I just did it here. It worked fine. The revision number is 10370. I just used bzr remove on the specific files and...
- 02:38 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- > Don't forget to remove the following files:
>
> lib/charva_cut_down_20100816.zip
> lib/charva_cut_down_20101216... - 02:15 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Don't forget to remove the following files:
lib/charva_cut_down_20100816.zip
lib/charva_cut_down_20101216.zip
li... - 12:36 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Yes, go ahead and check-in/distribute.
- 12:35 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Finally the regression testing has been passed with bzr code base 30368. So I guess it is ready to check in and distr...
- 12:51 PM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- It is a good start. Keep going.
- 09:15 AM Feature #2131: implement the Windows equivalent to the NCURSES/terminal support
- The first proposal of the Windows console native implementation for you to review. A lot of comments still left - be ...
07/26/2013
- 09:00 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- The last drop was replaced with one including manifest changes. The runtime testing has been started.
- 08:38 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- > The question: do I need to manually remove charva package in testing directory before start runtime testing? Or thi...
- 08:30 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- The drop with ConsoleDriver.java javadoc change. Going to test in devsrv01.
The question: do I need to manually re... - 08:17 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- OK, good.
- 08:16 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- > 1. You can remove the javadoc text from ConsoleDriver:
>
> * <p>
> * This replaces CHARVA driver.
>
> We don... - 07:59 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Code Review 0725a
1. You can remove the javadoc text from ConsoleDriver:...
07/25/2013
- 06:45 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Additional files with references to CHARVA included in this drop to modify:
com/goldencode/p2j/ui/client/driver/Scre... - 01:31 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- > I can offer to place KeyProcessor.java under com/goldencode/p2j/ui/client/chui/driver/console. Is it OK?
Yes, it... - 11:06 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- > When do you think you will be ready to test? It looks pretty close.
OK. I'll clean up the code soon and perform ... - 09:06 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- To be clear, I want you to get this tested, working and checked in before you do any work on the WIN32 version of the...
- 09:05 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Code Review 0724a
Overall, this is very good. Some minor things:
1. The copyright notice for ConsoleHelper is ... - 08:48 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- I like the overall approach. The changes to make it console/Console* instead of ncurses/Ncurses* is very good. It i...
07/24/2013
- 06:29 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- This is the first proposal for native implementation for Linux only. The Windows native part is still missing. But it...
07/23/2013
- 09:30 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Another offering is to move the helper class interfacing to JNI - ConsoleHelper to better location for example com/go...
- 07:18 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- The drop includes java part of suggested changes for review. The native C code structure will depends on which way we...
07/22/2013
- 07:19 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- After rethink I would offer to rename:
- ncurses/NcursesDriver.java
to
- console/ConsoleDriver.java
and
- ncurse... - 06:18 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Another point to discuss is related to the terminal calls in Windows C code. I can see two options here:
1. Use Cons... - 12:13 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- The implementation plan:
1. Create two new classes in com/goldencode/p2j/ui/client/chui/driver:
- ncurses/NcursesDriv...
07/17/2013
- 04:15 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Some thoughts:
1. I don't see anything in addStringNative() that looks protectible. The entire function can be pu... - 12:22 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- Another word we can use readKey() untouched? May be removing try_again: label which is never used now.
- 12:16 PM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- The code inside EVL<< .. EVL>> "braces" duplicates the original CHARVA source. The other code outside "braces" - GCD ...
- 07:29 AM Feature #1898: write a replacement for the CHARVA libTerminal.so as an NCURSES-based Linux shared...
- > 1. The calls detected as never used can be just ignored, we do not need to implement them in charva replacement, co...
Also available in: Atom