Activity

From 12/22/2013 to 01/20/2014

01/21/2014

08:15 PM Feature #1787: implement batch mode support: This update adds the Windows implementation for @SIGINT@ handler. Works in Windows 7 64-bit in virtual machine. Conti... Eugenie Lyzenko

01/20/2014

05:28 PM Feature #1787: implement batch mode support: Finding. The folowing code works fine in standalone application but does not work in library(like libp2j):... Eugenie Lyzenko
03:44 PM Feature #1787: implement batch mode support: This is implementation candidate for Linux @SIGINT@ interceptor.
The Java part consist of the new class @SigintWai... Eugenie Lyzenko
09:40 AM Feature #1787: implement batch mode support: I haven't gotten to the code review yet. But your approach for Windows is good. Greg Shah
05:11 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Review for 0121a.zip (btw, updates should be named using the day of work's date, not calendaristic):
# you are missi... Constantin Asofiei
04:45 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Here it is. An archive with recommended by you changes. The questions.
1) Do I correctly implenented @handle.unwrapI... Vadim Gindin
01:54 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Vadim Gindin wrote:
> I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrame... Constantin Asofiei
01:29 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): I tried to convert a simple procedure and it emitted correct (at first saw) java code @myFrameFrame.currentIteration(... Vadim Gindin
03:14 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: vig_upd20140116a.zip passed regression testing. Committed as rev #10443. Vadim Gindin
01:33 PM Feature #1801: add some frame options: Another argument for splitting the color from attribute I forgot to mention is the @Color@ class itself. It also keep... Hynek Cihlar
01:24 PM Feature #1801: add some frame options: Greg Shah wrote:
> Code Review 0119a
>
> 1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in Cons... Hynek Cihlar
01:21 PM Feature #1801: add some frame options: Greg Shah wrote:
> Code Review 0117a
> 1. Is the color-map.xml an example of the customer-specific (custom) color m... Hynek Cihlar
09:08 AM Feature #1801: add some frame options: Code Review 0119a
1. Why is there a dependency on @javax.jws.soap.SOAPBinding.Use@ in ConsolePrimitives?
2. Ple... Greg Shah
08:56 AM Feature #1801: add some frame options: Code Review 0117a
I was disconnected most of the weekend and didn't see your update until now. I'll check the 011... Greg Shah
12:13 PM Feature #1811: implement the AJAX client driver: 1. I did more investigations regarding the Google Chrome web browser.
Both Google Chrome and jetty teams works cu... Marius Gligor

01/19/2014

05:44 PM Feature #1787: implement batch mode support: > 4. What about Windows?
In Windows we do not have @sigwait()@. So another approach might be acceptable:
1. Ins... Eugenie Lyzenko
05:09 PM Feature #1801: add some frame options: The attached hc_upd20140119a.zip contains in-code documentation, file headers plus some cosmetic code changes. The co... Hynek Cihlar

01/18/2014

04:24 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): The work to determine the rules when the auxiliary field-group is created and how the field-group rows are made visib... Constantin Asofiei
04:03 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): I extended your test to output the content of each field group on every iteration and other useful information. Here ... Vadim Gindin
12:43 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Great, you can release 0116a.zip after it passes testing. Constantin Asofiei
12:16 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: There is no changes since last update vig_upd20140116a.zip Vadim Gindin
11:59 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: OK, place the final update here for review, before releasing it. Constantin Asofiei
07:20 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: So I tested it again. It works. I'm going to run regression testing. Vadim Gindin
07:26 PM Feature #1787: implement batch mode support: > But let's just call it init_ in all cases to keep the filenames shorter.
OK. This is the prepared base for appro... Eugenie Lyzenko

01/17/2014

06:15 PM Feature #1787: implement batch mode support: iniitalize_ would be fine. But let's just call it init_ in all cases to keep the filenames shorter. Greg Shah
05:32 PM Feature #1787: implement batch mode support: Greg,
Is it OK to name the native and OS dependent init modules as @initialize.(c|h)@ and @initialize_(linux|win).... Eugenie Lyzenko
01:17 PM Feature #1787: implement batch mode support: > Eugenie: please work toward having this work done (and regression tested and checked in) by end of day next Friday ... Eugenie Lyzenko
10:09 AM Feature #1787: implement batch mode support: > we should consider releasing an intermediate update (withtout the @KILL -INT@ fix)
Agreed.
Eugenie: please wo... Greg Shah
09:47 AM Feature #1787: implement batch mode support: Greg, a note: if there is a chance all the @kill -INT@ behaviour will not be ready until next friday, we should consi... Constantin Asofiei
08:40 AM Feature #1787: implement batch mode support: > Another things to discuss is about the signal processing init code for all required signals to special process. We ... Greg Shah
06:58 AM Feature #1787: implement batch mode support: > Yes. The sigaction() usage needs to be executed every time the client starts (instead of only when a child process ... Eugenie Lyzenko
08:17 PM Feature #1787: implement batch mode support: We can't use the Sun signal handling support otherwise this would limit our customer's usage of alternative JVMs.
... Greg Shah
05:46 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: As Vadim N. noted on #1655 note 63: the problem we have with @WIDTH@ and @WIDTH-CHARS@ can be found with @HEIGHT@ and... Constantin Asofiei
03:21 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Sorry, my bad. The test was missing a no-error clause for the last @this-procedure:current-window = h.@ assignment; s... Constantin Asofiei
02:24 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Constantin,
I've committed tests I have for this task. I already have similar tests. Could you comment, why do you... Vadim Gindin
04:06 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> Yes I did test it but my tests did not allow me to find this issue. It probably need to test i... Constantin Asofiei
03:25 PM Feature #1801: add some frame options: I am attaching changes with the protermcap color support for an early review. The code was functionally tested and is... Hynek Cihlar
02:08 PM Feature #1811: implement the AJAX client driver: Code Review 0116b
The code looks good. Does ChuiWebSimulator really need to call super.quit()? Greg Shah
01:29 PM Feature #1811: implement the AJAX client driver: System.exit(code) works fine.
Marius Gligor
01:07 PM Feature #1811: implement the AJAX client driver: Code Review 0117a
The changes look fine except for the END-ERROR approach already discussed above.
The use of S... Greg Shah
12:58 PM Feature #1811: implement the AJAX client driver: I checked in the TerminalMenu class and we have this code for the Exit menu item:... Greg Shah
12:16 PM Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> 1. I found another way to terminate the client process on connection close. Just simple put an... Constantin Asofiei
12:10 PM Feature #1811: implement the AJAX client driver: 1. I found another way to terminate the client process on connection close. Just simple put an END-ERROR key (code 30... Marius Gligor
08:34 PM Feature #1811: implement the AJAX client driver: > Using monospaced font results in an ugly screen so in JS I changed the monospaced with monospace font (see monospac... Greg Shah
08:24 PM Feature #1811: implement the AJAX client driver: Code Review 0116a
Generally, I'm OK with the code. My only concern: the use of @Runtime.getRuntime().halt(statusC... Greg Shah

01/16/2014

06:59 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Constantin Asofiei wrote:
> * @LogicalTerminal.setCurrentWindow(handle h)@ - have you tested the assignment using th... Vadim Gindin
03:37 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: * @LogicalTerminal.setCurrentWindow(handle h)@ - have you tested the assignment using the NO-ERROR clause too? Becaus... Constantin Asofiei
06:52 PM Feature #1787: implement batch mode support: > Before you tested, did you fix this issue I previously mentioned?
>
> > The sigaction() calls that used to be in... Eugenie Lyzenko
06:24 PM Feature #1787: implement batch mode support: Before you tested, did you fix this issue I previously mentioned?
> The sigaction() calls that used to be in the i... Greg Shah
06:14 PM Feature #1787: implement batch mode support: > OK, that means we have a problem to fix.
>
> Try this: temporarily re-enable the KeyReader thread and re-test. D... Eugenie Lyzenko
10:41 AM Feature #1787: implement batch mode support: > I have tested the our P2J client implementation for UI console mode. And kill behaves not the same as manual CTRL-C... Greg Shah
10:36 AM Feature #1787: implement batch mode support: > I'm not sure I understand what you've tested - your test was in P2J or 4GL?
OK. I have tested the our P2J client... Eugenie Lyzenko
10:25 AM Feature #1787: implement batch mode support: Eugenie Lyzenko wrote:
> I have tested the simple app with one fill-in in UI mode. The result is the same - kill -IN... Constantin Asofiei
09:10 AM Feature #1787: implement batch mode support: The drop fixes the today notes. Eugenie Lyzenko
09:05 AM Feature #1787: implement batch mode support: > Eugenie, two notes:
>
> check how kill -INT is treated for normal start in 4GL (non-batch). Double-check this be... Eugenie Lyzenko
06:37 AM Feature #1787: implement batch mode support: Code Review 0115b
1. Please put this comment in BatchDriver.init() ... Greg Shah
04:01 AM Feature #1787: implement batch mode support: About the update:
* the appserver connection is working properly.
* @ThinClient.isBatchInBackground@ - there is a... Constantin Asofiei
03:18 AM Feature #1787: implement batch mode support: Eugenie, two notes:
# check how @kill -INT@ is treated for normal start in 4GL (non-batch). Double-check this behavi... Constantin Asofiei
05:48 PM Feature #1801: add some frame options: I believe this was intended as the mechanism by which the server-side code would configure custom colors and have the... Greg Shah
05:42 PM Feature #1801: add some frame options: In the original code, @ColorSpec@ contains the method @addMapping(String, Color)@ allowing dynamically add color mapp... Hynek Cihlar
03:56 PM Feature #1811: implement the AJAX client driver: On Chrome seems to be a bug when secured connection (WSS) with self signed certificate is used.
https://code.google.... Marius Gligor
01:36 PM Feature #1811: implement the AJAX client driver: 1. Today I converted the keys.p application and I implemented the keyboard codes conversion for p4g.
I observed that... Marius Gligor
03:02 PM Feature #2037: runtime support for frame options: The testcases can be found here: #2227 Eugenie Lyzenko

01/15/2014

05:47 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is the update with batch-mode support added. Vadim Gindin
03:40 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: > We can choose to set the name displayed in the error message at LegacyAttribute annotation and change the CAN-QUER... Greg Shah
02:40 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Greg Shah wrote:
> Is there ever any way the 4GL can report WIDTH-CHARS as the attribute name? If not, then let's j... Constantin Asofiei
08:28 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: > Greg: we can add a low-priority task for this problem, as this looks like an exotic case.
OK.
>> 2) Attribute... Greg Shah
02:10 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I understand the problem. Unfortunately, I think this will need conversion changes, to let the handle.unwrap call kno... Constantin Asofiei
05:08 PM Feature #1787: implement batch mode support: OK. I'll need to dig more to clarify the STOP condition generation.
For now I've uploaded the changes clearing all... Eugenie Lyzenko
04:41 PM Feature #1787: implement batch mode support: I'm not sure, but I do wonder if it has something to do with our signal handling approach.
The sigaction() calls t... Greg Shah
04:21 PM Feature #1787: implement batch mode support: > Yes, except since there is no user input in these modes, the way to pass a @CTRL-C@ to the process is by using @kil... Eugenie Lyzenko
01:58 PM Feature #1787: implement batch mode support: > OK. I'm leaving for background mode:
>
> Batch processing will be performed using:
> OpenEdge Release ...
>
>... Greg Shah
01:35 PM Feature #1787: implement batch mode support: > 1. Copyright ranges need to be updated to 2014 for all files.
Done.
> 2. We DEFINITELY CANNOT include that Pr... Eugenie Lyzenko
01:16 PM Feature #1787: implement batch mode support: Code Review 0115a
1. Copyright ranges need to be updated to 2014 for all files.
2. We DEFINITELY CANNOT include... Greg Shah
01:07 PM Feature #1787: implement batch mode support: Eugenie Lyzenko wrote:
> Eugenie: @BatchDriver.init@ I don't think it should output the progress logo; it is enough ... Constantin Asofiei
12:59 PM Feature #1787: implement batch mode support: Eugenie: @BatchDriver.init@ I don't think it should output the progress logo; it is enough to output the messages aft... Eugenie Lyzenko
12:56 PM Feature #1787: implement batch mode support: Eugenie: @BatchDriver.init@ I don't think it should output the progress logo; it is enough to output the messages aft... Constantin Asofiei
12:40 PM Feature #1787: implement batch mode support: The drop adds foreground/background differences introduced via @client.sh@ script @"client:driver:background=true|fal... Eugenie Lyzenko
02:21 AM Feature #1787: implement batch mode support: The good news is that I think @pro -b &@ behaves the same as @pro -b@ (@kill -INT@ will raise a STOP condition in the... Constantin Asofiei
01:50 PM Feature #1811: implement the AJAX client driver: Code Review 0115a
I am generally fine with the changes. Minor feedback:
1. Some imports need to be shifted to ... Greg Shah
01:35 PM Feature #1811: implement the AJAX client driver: This feature isn't yet implemented but will be. We have a notification on web sockets when the connection is closed o... Marius Gligor
01:13 PM Feature #1811: implement the AJAX client driver: Marius: what happens when the browser is closed? Does the P2J client process get shut down properly? Constantin Asofiei
12:32 PM Feature #1811: implement the AJAX client driver: Today I started to implements the keyboard events protocol.
So far I tested:
-printable characters OK
-CTRL-C OK... Marius Gligor
11:33 AM Feature #1811: implement the AJAX client driver: By the way, our current ChUI client (swing and ncurses) does not support mouse events. You don't need to add support... Greg Shah
11:21 AM Feature #1811: implement the AJAX client driver: Very cool stuff. Please use testcases/uast/keys.p to test out your key processing. Compare the results to running t... Greg Shah
10:54 AM Feature #1811: implement the AJAX client driver: OK. Now it works from both command line and from IDE.
I attached some well known screens this time taken from my web... Marius Gligor
10:03 AM Feature #1811: implement the AJAX client driver: The swing chui client can be started with no problem from Eclipse (and I guess from other IDE too); just set it up li... Constantin Asofiei
09:58 AM Feature #1811: implement the AJAX client driver: OK Thanks. Now the SWING driver works fine.
I have configurations on my IDE to start the server and the client which... Marius Gligor
09:22 AM Feature #1811: implement the AJAX client driver: The problem is you have two distinct P2J builds - one for the server, and one for the client. And the serialVersionUI... Constantin Asofiei
09:17 AM Feature #1811: implement the AJAX client driver: Now seems to be a serialization problem.
WARNING: {Reader} failure in reading loop
java.io.InvalidClassException:... Marius Gligor
09:06 AM Feature #1811: implement the AJAX client driver: Take the @testcases/simple/server/server.sh@ from the repository. The problem is caused by the fact that the server i... Constantin Asofiei
09:03 AM Feature #1811: implement the AJAX client driver: I did a new conversion for Ask.p and Primes.p
Unfortunately when I want to start the primes.p on my emulator the se... Marius Gligor
08:34 AM Feature #1811: implement the AJAX client driver: > I've started to implements the protocol for keyboard management.
> I have good news! So far It's works fine see th... Greg Shah
08:32 AM Feature #1811: implement the AJAX client driver: Please note that you should always have a symbolic link in your project home (testcases/uast/) to the p2j/ directory ... Greg Shah
08:08 AM Feature #1811: implement the AJAX client driver: Thanks I fixed the problem.
I just copied the rules directory from p2j on testcases/uast/p2j/rules and the conversi... Marius Gligor
07:51 AM Feature #1811: implement the AJAX client driver: Then I think there is some other p2j/ installation on the path; and I can't be of much help with that. Why I say thi... Constantin Asofiei
07:41 AM Feature #1811: implement the AJAX client driver: My p2j project is updated and the build all is OK, no errors. However the conversion does not work.
The rules/annota... Marius Gligor
07:20 AM Feature #1811: implement the AJAX client driver: Make sure you are using the latest revision (and P2J is built). From the log, you have an outdated @rules/annotation... Constantin Asofiei
07:15 AM Feature #1811: implement the AJAX client driver: I attached the build log. Marius Gligor
07:13 AM Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> According to conversion handbook:
>
> export P2J=/home/mag/p2j
> export CLASSPATH=$P2J/bu... Marius Gligor
07:09 AM Feature #1811: implement the AJAX client driver: And what error do you get? Constantin Asofiei
07:06 AM Feature #1811: implement the AJAX client driver: According to conversion handbook:
export P2J=/mag/p2j/to/p2j
export CLASSPATH=$P2J/build/lib/p2j.jar
java com.... Marius Gligor
07:00 AM Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> So I tried to do a new conversion but unfortunately without success.
What command do you use... Constantin Asofiei
06:57 AM Feature #1811: implement the AJAX client driver: I've started to implements the protocol for keyboard management.
I have good news! So far It's works fine see the at... Marius Gligor

01/14/2014

06:49 PM Feature #1787: implement batch mode support: > My concern with your suggested approach is that we would have to find every place that is different when using the ... Eugenie Lyzenko
06:11 PM Feature #1787: implement batch mode support: > It is important that you make sure you re-run all your tests using the @pro -b@ since our current code may have som... Eugenie Lyzenko
06:03 PM Feature #1787: implement batch mode support: It is important that you make sure you re-run all your tests using the @pro -b@ since our current code may have some ... Greg Shah
06:02 PM Feature #1787: implement batch mode support: > Do we need to support both foreground and background mode?
Yes.
> Because the & option is used with -b option... Greg Shah
12:09 PM Feature #1787: implement batch mode support: > The key question: can we duplicate this behavior using the & directly from the shell?
May be this is not require... Eugenie Lyzenko
09:28 AM Feature #1787: implement batch mode support: >>> The correct command for batch mode in Linux is bpro, not pro
>>>
>> Is this officially documented somewhere? Be... Greg Shah
09:13 AM Feature #1787: implement batch mode support: Eugenie Lyzenko wrote:
> > There is a memory leak in the TypeAhead.taBuf list...
>
> Explain what do you mean tellin... Constantin Asofiei
09:04 AM Feature #1787: implement batch mode support: > There is a memory leak in the TypeAhead.taBuf list...
Explain what do you mean telling "memory leak". Another wo... Eugenie Lyzenko
08:57 AM Feature #1787: implement batch mode support: > > The correct command for batch mode in Linux is @bpro@, not @pro@
>
> Is this officially documented somewhere? ... Eugenie Lyzenko
08:54 AM Feature #1787: implement batch mode support: Greg Shah wrote:
> However, I wonder what the 4GL does when you "manually" send it the CTRL-C via @kill -INT <pid>@?... Constantin Asofiei
08:31 AM Feature #1787: implement batch mode support: > if ran under linux with pro -b -p a.p will output:
> ... Eugenie Lyzenko
08:27 AM Feature #1787: implement batch mode support: > if batch mode is enabled, then the KeyReader thread should not be started at all (as blocking for user input is imp... Greg Shah
06:05 AM Feature #1787: implement batch mode support: There is a memory leak in the @TypeAhead.taBuf@ list, when batch mode is activated. On linux, when the @BatchDriver.r... Constantin Asofiei
04:20 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: You're right.. Now I'm trying to implement it (batch-mode support) and I'm getting following problem. CURRENT-WINDOW ... Vadim Gindin
05:44 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim, on note 24 you mentioned that "window is unknown:" in batch mode. You forgot to implement this case in @LT.cur... Constantin Asofiei
12:33 PM Feature #1811: implement the AJAX client driver: The code changes in 0114a look good. There is some missing javadoc, but otherwise things seem pretty much on target.... Greg Shah
12:07 PM Feature #1811: implement the AJAX client driver: Today I started to implements the WebSockets protocol for screen management (server -> browser JS)
Please look at th... Marius Gligor
11:13 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): > AFAIK, P2J uses n widget rows for displaying the body of a n-down frame;
Correct.
> assuming that 4GL indeed ... Greg Shah
11:02 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): About the tests at note 10: your conclusions are wrong. If you look at the repeating IDs, you will see that there are... Constantin Asofiei
08:58 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: Attached update contains the correct changes applied to rev 10436 (compared to 10434). Constantin Asofiei
03:00 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: Error fix. Committed to bzr, rev #10436. Vadim Gindin

01/13/2014

05:13 PM Feature #2226: finish LAST-EVENT support: Please put all discussions into the task history for #1782 so that future readers don't have to look in 2 places for ... Greg Shah
05:10 PM Feature #2226: finish LAST-EVENT support: Basic behavior is working, but there are a number of special cases that don't yet work exactly like the 4GL. Please ... Greg Shah
05:08 PM Feature #2226 (Closed): finish LAST-EVENT support: Greg Shah
05:12 PM Feature #1782 (Closed): implement LAST-EVENT system handle and associated attributes: Greg Shah
04:54 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Here it is. Implementation of basic behavior Vadim Gindin
04:53 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Please post the final update zip here and we will close the task. Greg Shah
04:33 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: committed to bzr rev #10435 Vadim Gindin
03:17 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Ok, then stay with option 1 (constants) but make sure to document this in the javadoc for the fields (i.e. they are p... Constantin Asofiei
03:06 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin Asofiei wrote:
> ..
> Unless the DE_LOWEST and DE_HIGHEST are some codes from 4GL, is there a way to def... Vadim Gindin
03:13 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> ..
> > * Keyboard - as for note 81 - why can't the initializatio... Constantin Asofiei
05:11 PM Feature #2020 (Closed): runtime support for LAST-EVENT system handle and associated attributes: Greg Shah
04:59 PM Feature #1811: implement the AJAX client driver: It looks good (both the code in 0113a and the proposed protocol). Greg Shah
12:33 PM Feature #1811: implement the AJAX client driver: For a better view. Marius Gligor
12:30 PM Feature #1811: implement the AJAX client driver: The following classes are used to emulate a terminal:
ChuiWebDriver extends (ChuiScreenDriver implements ScreenDri... Marius Gligor
12:28 PM Feature #1811: implement the AJAX client driver: I did a lot of improvements inside the JS code:
- I'm using JS sub modules stored on separate script files.
- Scree... Marius Gligor
10:33 AM Feature #1811: implement the AJAX client driver: Code Review 0110a
I am fine with the general approach and how the code is progressing.
I only have 3 comments:
... Greg Shah

01/10/2014

04:29 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin Asofiei wrote:
..
> * Keyboard - as for note 81 - why can't the initialization of DE_LOWEST and DE_HIGHEST... Vadim Gindin
10:03 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: Vadim, I'm fine with the logic. All comments are about cleanup and javadoc/comment improvement:
* ClientState - you ... Constantin Asofiei
01:15 PM Feature #1811: implement the AJAX client driver: I designed minimal JS modules for Screen, Screen cursor, Message Beep and WebSocket communication management.
The at... Marius Gligor
04:31 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Go ahead and get it tested. Before committing, fix the tab characters in LT.setProcCurrentWindow:8627. Constantin Asofiei

01/09/2014

06:11 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Lost new results picture. Vadim Gindin
06:09 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): > I thought that you meant 1-DOWN by the phrase "non-down frame".
Yes, you have it right. Greg Shah
06:06 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Sorry, I made a simple logical error in my test and this led us to confusion. My error was in a rows number in the ou... Vadim Gindin
05:14 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Next update with last changes. Vadim Gindin
03:54 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Review for 0108a.zip:
* In files where the history entry is from 2014, update the copyright years in the file's head... Constantin Asofiei
07:01 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is an update with last changes. I merged it with current revision and checked if it is ok again. If I correctly ... Vadim Gindin
03:49 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Go ahead with the runtime testing. I'll do the review tomorrow. Constantin Asofiei
03:28 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Here is the update. I'm waiting for your permission to start regression testing. Vadim Gindin
03:56 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: > Correct result. I'm going to run regression testing.
Perfect. Post the update here, once you've added javadoc/todo's. Constantin Asofiei
07:33 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: I tested your ENDKEY test.
Progress shows:
PF4 - END-ERROR [KEYPRESS]
Java shows:
F4 - END-ERROR [KEYPRESS]
Cor... Vadim Gindin
11:07 AM Feature #1811: implement the AJAX client driver: > 1. I think that is better to start by designing our custom binary protocol.
OK, good.
> 2. The Dojo toolkit S... Greg Shah
10:22 AM Feature #1811: implement the AJAX client driver: 1. I think that is better to start by designing our custom binary protocol. This means that we have to define the str... Marius Gligor

01/08/2014

06:10 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Sorry, I forgot about this-procedure:current-window. Here is the test:... Vadim Gindin
04:23 PM Feature #1811: implement the AJAX client driver: > Maybe a short research on how to use GZIP with embedded jetty could be useful.
> Do you think that a JSON and GZIP... Greg Shah
01:28 PM Feature #1811: implement the AJAX client driver: 1. WebSockets are full-duplex communication channels over TCP. So we have to implements a communication protocol on s... Marius Gligor
10:51 AM Feature #1811: implement the AJAX client driver: Ref. #2201 implement the web client process spawning and server redirect.
Passed the regression tests.
Committed re... Marius Gligor
11:29 AM Feature #2201 (Closed): implement the web client process spawning and server redirect: Greg Shah

01/07/2014

01:47 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Vadim Gindin wrote:
> I mean, what tests do you consider as basic?
Case 8 from the table, @widget and key events@, ... Constantin Asofiei
01:08 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: I mean, what tests do you consider as basic? Vadim Gindin
01:07 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin Asofiei wrote:
> .. just ensure the basic tests work.
I wrote in the table results of all tests I have... Vadim Gindin
09:20 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: After contacting Guy, the conclusion is that the server project does not use the program which reads the LAST-EVENT:L... Constantin Asofiei
08:41 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: > Greg: can ENDKEY label (and last-key) be ever produced by user key press?
I'm not sure. Normally, I would have ... Greg Shah
05:00 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: The server project uses the LAST-EVENT:LABEL in only one place, with a case like (this is an assumption, as I can't f... Constantin Asofiei
01:41 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Review of 0107a.zip:
* please try not to post updates merged with other tasks; if you find it difficult to work more... Constantin Asofiei
01:01 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Sorry I forgot to add the comment about the path. Here is updated archive. Vadim Gindin
12:56 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is an update with last changes. Vadim Gindin
12:04 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I ran the program using @pro -p a.p@; if you run it using @pro -p somefolder/a.p@, then you will have @somefolder/a.p... Constantin Asofiei
12:01 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Yes, I checked it again. My exact message is:
@** /home/vig/winhandles/simple2.p: Unable to evaluate field for assig... Vadim Gindin
11:52 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> Thank you, but Progress shows full path to procedure file starting from root folder "/". @Envi... Constantin Asofiei
11:32 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Thank you, but Progress shows full path to procedure file starting from root folder "/". @EnvironmentOps.getSourceNam... Vadim Gindin
10:37 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> Constantin, could you help me. I didn't find in @ErrorManager@ a possibility to include in the... Constantin Asofiei
10:32 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Constantin, could you help me. I didn't find in @ErrorManager@ a possibility to include in the error message the name... Vadim Gindin
07:04 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Great. Please finish the changes I mentioned in note 27 (expect the @current-window = ?@ case) and post the update here. Constantin Asofiei
06:06 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Yes it works and moreover there are no more need to move KW_NO_ERROR manually. Here is the new AST node:... Vadim Gindin
05:08 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: > It seems it because KW_NO_ERROR is inside expression and unfortunately I forced to wrap EXPRESSION inside STATEMENT... Constantin Asofiei
04:54 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I understand, thank you. Now it produces this Java code:... Vadim Gindin
03:47 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> I added first change in the frame_scoping.rules to emit KW_NO_ERROR in a some place in the tar... Constantin Asofiei
12:21 PM Feature #1811: implement the AJAX client driver: Code Review 0107a
I am fine with the changes. When it passes regression testing, please check it in and distribut... Greg Shah
11:42 AM Feature #1811: implement the AJAX client driver: Here are the latest changes on my local repository after an update from remote repository.
Only two files was merged... Marius Gligor

01/06/2014

05:10 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Yes It will be simpler. But It looks like the last change you propose is a solution of some private task. I added fir... Vadim Gindin
02:29 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: > KW_NO_ERROR probably should not be included inside EXPRESSION. Am I right? The question is how this ast node should... Constantin Asofiei
02:10 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I corrected the rules block you specified to force it transfer KW_NO_ERROR too and got this ast node (after annotatio... Vadim Gindin
09:11 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim Gindin wrote:
> I can only suspect that the transformation from @assignment@ to @expression@ is going in the a... Constantin Asofiei
09:06 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Thank you Constantin!
I ran the conversion process with @f2+cb@ options and got my first result, but when I ran th... Vadim Gindin
07:58 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Vadim, to identify if the problem is in the parser, then is best to check the AST generated by the FRONT phase, as th... Constantin Asofiei
03:42 PM Feature #1811: implement the AJAX client driver: Something else to consider with the protocol is that the GUI driver/javascript will have more significant requirement... Greg Shah
03:32 PM Feature #1811: implement the AJAX client driver: Additional Details on the Protocol
1. The protocol will need to be full-duplex. It must be possible to have both ... Greg Shah
03:06 PM Feature #1811: implement the AJAX client driver: > We have to design the protocol used by websockets.
> We have two options: JSON or binary payloads. As I remember y... Greg Shah
02:55 PM Feature #1811: implement the AJAX client driver: Code Review 1223a
I am fine with the changes.
Please merge up to the latest bzr revision (10426) and then run r... Greg Shah
02:36 PM Feature #1787 (Closed): implement batch mode support: Greg Shah
02:05 PM Feature #1787: implement batch mode support: evl_upd20131221b.zip did pass the regression testing and committed to bzr as 10426. Eugenie Lyzenko
10:15 AM Feature #1787: implement batch mode support: Go ahead, commit and distribute it. Greg Shah
09:18 AM Feature #1787: implement batch mode support: Greg Shah wrote:
> Constantin: do you see any concerns?
I don't see any obvious problems in the logic. My only conc... Constantin Asofiei
08:53 AM Feature #1787: implement batch mode support: I am OK with the changes.
Constantin: do you see any concerns?
If not, then the check in can proceed. Greg Shah
01:22 PM Feature #2027 (Closed): preliminary runtime support for CREATE_WIDGET and an IN WINDOW clause: Greg Shah
01:16 PM Feature #2212 (WIP): design websockets protocol for bidirectional communication between the javas...: Marius Gligor
11:12 AM Feature #1782: implement LAST-EVENT system handle and associated attributes: Constantin will be the one doing a more detailed review of your latest code.
I have taken a quick look at the code... Greg Shah
09:45 AM Feature #1801: add some frame options: > Could somebody explain the rationale behind the varying end escape sequences? I.e., why are some colors terminated ... Greg Shah

01/05/2014

10:23 AM Feature #1801: add some frame options: Greg Shah wrote:
> Alright, please do try to resolve the variable end sequences as elegantly as possible. Try to im... Hynek Cihlar

01/04/2014

01:23 PM Feature #1787: implement batch mode support: Well, I've got the CTRL-C tests fully passed in one round. Take a look at 2014 year results from:
10425_ed8b6f3_2014... Eugenie Lyzenko
04:29 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Thank you for the explanation. I wrote an ast node in my previous comment (#28). Vadim Gindin

01/03/2014

01:56 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: First, in regard to your specific problem, I doubt the issue is in the parser. The NO-ERROR should emit as:
ErrorMa... Greg Shah
01:53 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: I'm trying to fix no-error loose during conversion of this statement:
@current-window = h no-error.@
I am viewi... Vadim Gindin
06:05 AM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Some general notes:
# in the implementations for all @current/default/active-window@ APIs in @LogicalTerminal@, wher... Constantin Asofiei
12:18 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): > Well, the current-iteration is not linked with an iterating block
Yes, this is exactly how we have implemented d... Greg Shah
10:42 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Vadim Gindin wrote:
> P.S. About numbering. What problem do you see in it? I viewed same values for newly created wi... Constantin Asofiei
08:13 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Here are widget attrs:
!widget_attrs.png!
In this result we can see values of following attrs (in order of appearing)... Vadim Gindin
05:14 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): Well, the @current-iteration@ is not linked with an iterating block; lets take this case:... Constantin Asofiei
12:10 PM Feature #1801: add some frame options: Alright, please do try to resolve the variable end sequences as elegantly as possible. Try to implement the simple/s... Greg Shah
07:17 PM Feature #1801: add some frame options: Greg Shah wrote:
> If I understand you correctly, you are suggesting that for NCurses/Curses we directly use the par... Hynek Cihlar

01/02/2014

02:39 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): This is somewhat consistent with my theory. On a 5-down frame, you would expect 5 sets of widgets, but it looks like... Greg Shah
01:08 PM Feature #1801: add some frame options: This is going in the right direction.
If I understand you correctly, you are suggesting that for NCurses/Curses we... Greg Shah

12/31/2013

06:56 PM Feature #1801: add some frame options: Here's a proposed sample of the xml format for storing the color mappings. Parsing the escape sequence into a more st... Hynek Cihlar
08:46 PM Feature #1801: add some frame options: Internally to P2J, a color is represented with the @Color@ class. The @Color@ class holds the (logical) color value a... Hynek Cihlar
09:51 AM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): I've prepared first test... Vadim Gindin

12/29/2013

05:30 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): The objective for this task is to implement the CURRENT-ITERATION attribute for widgets. The documentation is quite ... Greg Shah
05:07 PM Feature #2162: add support for CURRENT-ITERATION attribute (for widget objects): From the Progress Language Reference for v11.0:... Greg Shah

12/25/2013

06:55 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Here is an update. Sorry that it is merged with 1782 changes. It's not final. In this task there is only @setCurrentW... Vadim Gindin
05:52 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: no-error in the case of current-window errors sets ERROR-STATUS:ERROR flag to true. Vadim Gindin
05:50 PM Feature #2016: implement CURRENT-WINDOW, ACTIVE-WINDOW and DEFAULT-WINDOW system handles: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Here are test cases:
> > 1) same.p - testing equality of all t... Vadim Gindin
04:30 PM Feature #1787: implement batch mode support: Greg,
The runtime regression tests are finally all passed. The results can be found in 10425_ed8b6f3_20131225_evl.... Eugenie Lyzenko

12/24/2013

05:26 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Here is an update, containing current solutions. Vadim Gindin
08:35 AM Feature #1787: implement batch mode support: The testing results summary at this time:
1. The main part is OK.
2. The 3-way CTRL-C tests are passed.
3. The 2-w... Eugenie Lyzenko

12/23/2013

05:59 PM Feature #1782: implement LAST-EVENT system handle and associated attributes: Table contains testcases and results for both Progress and Java.
"Progress" column contains expected output. Testca... Vadim Gindin
09:57 AM Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> Actually the build does not require sudo permissions. You have to use some command line argum... Constantin Asofiei
09:52 AM Feature #1811: implement the AJAX client driver: Actually the build does not require sudo permissions.
You have to use some command line arguments to execute the pos... Marius Gligor
09:44 AM Feature #1811: implement the AJAX client driver: Marius Gligor wrote:
> Constantin: I think that is no need to do that. This issue should be tested only on a local c... Constantin Asofiei
09:38 AM Feature #1811: implement the AJAX client driver: Constantin: I think that is no need to do that. This issue should be tested only on a local copy of Majic not on devs... Marius Gligor
09:33 AM Feature #1811: implement the AJAX client driver: Go ahead with regression testing on devsrv01 *without* making changes to enable the web chui. That will allow us to g... Greg Shah
09:30 AM Feature #1811: implement the AJAX client driver: Marius: I've made the sudo-related changes for your account on devsrv01. After regression testing passes, make sure t... Constantin Asofiei
08:36 AM Feature #1811: implement the AJAX client driver: On Saturday and today I did a lot of tests on a local copy of Majic project.
Finally I succeeded to configure the di... Marius Gligor
07:16 PM Feature #2037 (WIP): runtime support for frame options: Hynek Cihlar

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

01/21/2014

01/20/2014

01/19/2014

01/18/2014

01/17/2014

01/16/2014

01/15/2014

01/14/2014

01/13/2014

01/10/2014

01/09/2014

01/08/2014

01/07/2014

01/06/2014

01/05/2014

01/04/2014

01/03/2014

01/02/2014

12/31/2013

12/29/2013

12/25/2013

12/24/2013

12/23/2013