Project

General

Profile

Activity

From 05/22/2015 to 06/20/2015

06/20/2015

01:53 PM Feature #2252: implement GUI client support
Greg Shah wrote:
> Code Review Task Branch 2559b Revision 10883
>
> I'm fine with the changes.
>
> Am I correc...
Hynek Cihlar
10:46 AM Feature #2252: implement GUI client support
Code Review Task Branch 2559b Revision 10883
I'm fine with the changes.
Am I correct to assume the other items ...
Greg Shah
10:29 AM Feature #2252: implement GUI client support
Hynek Cihlar wrote:
> For #2559, please review regression fixes committed to task branch 2559b. The changes do not a...
Eugenie Lyzenko
06:41 AM Feature #2252: implement GUI client support
For #2559, please review regression fixes committed to task branch 2559b. The changes do not affect ChUI so no Majic ... Hynek Cihlar

06/19/2015

05:18 PM Feature #2252: implement GUI client support
Task branch 2559 has been committed to bzr trunk, revision 10882. Hynek Cihlar
09:26 AM Feature #2252: implement GUI client support
Code Review Task Branch 2559 rev 10881
I'm good with the changes. Please merge to trunk, commit and notify.
Greg Shah
09:21 PM Feature #2252: implement GUI client support
For #2559, I have resolved all the points from the last review, fixed all regressions and other bugs found. The chang... Hynek Cihlar
04:08 PM Feature #2546: implement combo-box widget in GUI
The update for review has implementation for @ThinClient@ change related to the mouse clicks outside drop-down. The n... Eugenie Lyzenko
10:44 PM Feature #2546: implement combo-box widget in GUI
The update for review has subtracted @Scrollbar@ related code that distributed separately. Also it contains suggested... Eugenie Lyzenko
10:07 PM Feature #2546: implement combo-box widget in GUI
Committed in bzr as @10881@. Eugenie Lyzenko
09:52 PM Feature #2546: implement combo-box widget in GUI
Testing completed, no regressions, had to run 3-way CTRL-C tests in separate session. The results are: @10879_bb2f7ec... Eugenie Lyzenko
08:25 PM Feature #2546: implement combo-box widget in GUI
Finally the main part of the testing for 0617b completed without regressions. I'm expecting to finish @CTRL-C@ testin... Eugenie Lyzenko
01:41 PM Feature #2563: implement GUI EDITOR widget
Greg Shah wrote:
> My only question is whether you want to go before or after Igor's #2534 changes?
I'd like to go ...
Constantin Asofiei
12:34 PM Feature #2563: implement GUI EDITOR widget
> I have already checked in and distributed the 0617b Scrollbar related update.
Right, sorry.
> It is required...
Greg Shah
11:08 AM Feature #2563: implement GUI EDITOR widget
Greg Shah wrote:
> ... I know you are waiting on Eugenie's to pass and be checked in and then will merge those...
...
Eugenie Lyzenko
10:51 AM Feature #2563: implement GUI EDITOR widget
Code Review Task Branch 2563b revision 10884
I like the changes, nice improvement.
Hynek's changes will need to...
Greg Shah
05:54 AM Feature #2563: implement GUI EDITOR widget
rebased branch 2563b, new revision is 10884 Constantin Asofiei
01:07 PM Feature #1790: implement menu support
I've fixed it. But now it displays sub-menu twice in 2 different places. Have a look please. Why it can happen? Vadim Gindin
06:46 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Here is my current update. Could you review and help me? I can't understand why nested sub-men...
Constantin Asofiei
03:58 AM Feature #1790: implement menu support
Here is my current update. Could you review and help me? I can't understand why nested sub-menu body isn't drawn when... Vadim Gindin

06/18/2015

04:12 PM Feature #2563: implement GUI EDITOR widget
branch 2563b/rev 10882 passed testing Constantin Asofiei
08:19 AM Feature #2563: implement GUI EDITOR widget
branch 2563b/rev 10882: Fixed javadoc errors. Added mouse-double-click support. Fixed scrolling by mouse and other ... Constantin Asofiei
01:42 PM Feature #2546: implement combo-box widget in GUI
One more point to clarify.
I'm trying to make the drop-down list event processing loop more reliable an responsibl...
Eugenie Lyzenko
02:30 AM Feature #2422: add features to BROWSE
It is not implemented at runtime (@Browse.java@):... Stanislav Lomany

06/17/2015

05:05 PM Feature #2422: add features to BROWSE
I don't understand. As far as I can see, we already support @SET-REPOSITIONED-ROW@ both at runtime and in conversion... Greg Shah
04:55 PM Feature #2422: add features to BROWSE
> Doesn't @GET-REPOSITIONED-ROW@ still need to be done?
@GET-REPOSITIONED-ROW@ always returns _1_ unless the row w...
Stanislav Lomany
11:37 AM Feature #2422: add features to BROWSE
>> What else is open in this task?
>
> My checklist:
> ...
Doesn't @GET-REPOSITIONED-ROW@ still need to be done?
Greg Shah
03:44 PM Feature #2563: implement GUI EDITOR widget
Code Review 2563b branch (rev 10881)
This is a really good update. I don't have any concerns.
Greg Shah
02:28 PM Feature #2563: implement GUI EDITOR widget
I've added the EDITOR changes (and some scroll-related changes from #2546 - rev 10880) to the 2563b branch (rev 10881... Constantin Asofiei
02:39 PM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Here it is.
> @ScrollEvent@ class is needed - please add th...
Eugenie Lyzenko
01:48 PM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150617a.zip
I'm OK with the changes. Please get them regression tested.
Greg Shah
01:42 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, can you extract the changes in the @Scrollbar*@ cla...
Constantin Asofiei
10:34 AM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, s...
Eugenie Lyzenko
09:49 AM Feature #2546: implement combo-box widget in GUI
Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, so they can be released? I thi... Constantin Asofiei
09:12 AM Feature #2546: implement combo-box widget in GUI
> And I'm inclining to leave the current approach for ChUI only mode and implement completely different approach in G... Greg Shah
09:09 AM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150616a.zip
The code changes are fine.
Greg Shah
08:51 PM Feature #2546: implement combo-box widget in GUI
The today update has small changes to event processing. The new class I have introduced in one previous update - @Com... Eugenie Lyzenko

06/16/2015

11:37 AM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute
It looks like button's DEFAULT attribute does not need to be checked in @FrameGuiImpl.processDefaultButton()@. Press... Greg Shah
11:28 AM Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...
Greg Shah
11:29 AM Feature #2563: implement GUI EDITOR widget
> Looks like the Progress bug or documentation miss. So we have to decide what strategy we will take here.
It does...
Greg Shah
10:48 AM Feature #2546: implement combo-box widget in GUI
Greg Shah wrote:
> Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.z...
Eugenie Lyzenko
10:36 AM Feature #2546: implement combo-box widget in GUI
Code Reviews evl_upd20150611a.zip evl_upd20150613a.zip evl_upd20150614a.zip evl_upd20150615a.zip
I am generally...
Greg Shah
10:17 AM Feature #1794: implement font support
There is a very useful discussion and tutorial in #2546 notes 92 and 98. This explains some problems with matching f... Greg Shah
09:09 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> > Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the wi...
Constantin Asofiei
09:00 AM Feature #2252: implement GUI client support
> Btw., WindowGuiImpl.resolveTitleFont() allows to override the title font by the value of the window's BaseConfig.ti... Greg Shah
06:08 AM Feature #2252: implement GUI client support
Greg Shah wrote:
> 1. The @AbstractWidget@ parent/ancestor lookup processing is much improved. It is easier to read...
Hynek Cihlar

06/15/2015

05:08 PM Feature #2252: implement GUI client support
Code Review hc_upd20150612b.zip
This is a really nice improvement. I especially like the way you abstracted the a...
Greg Shah
04:37 PM Feature #2546: implement combo-box widget in GUI
The metrics for the combo-box widget have already been captured into @uast/combo_box/metrics/@ folder (they are all f... Constantin Asofiei
09:38 AM Feature #2546: implement combo-box widget in GUI
Clarification about @VALUE-CHANGED@ event generation:
In all three modes mouse click and keyboard @UP@/@DOWN@ caus...
Eugenie Lyzenko
08:30 AM Feature #2546: implement combo-box widget in GUI
Small change to fix entry field selection draw in @DROP-DOWN@ mode when drop-down list become active. Eugenie Lyzenko
11:28 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150612a.zip
Please go ahead with the merge. Stanislav's changes have been checked in. Here ...
Greg Shah
11:01 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines(...
Greg Shah

06/14/2015

06:04 PM Feature #2546: implement combo-box widget in GUI
More features findings for 4GL combo-box.
1. When combo-box is in @SIMPLE@ or @DROP-DOWN@ modes the entry field keep...
Eugenie Lyzenko
09:10 AM Feature #2546: implement combo-box widget in GUI
Merged with recent @10879@ code base. Eugenie Lyzenko
04:41 AM Feature #2422: add features to BROWSE
INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Committed to bzr rev 10879. Stanislav Lomany

06/13/2015

05:55 PM Feature #2546: implement combo-box widget in GUI
The update for review fixes the drop-down incorrect coordinates setting. The idea is based on the fact the drop-down ... Eugenie Lyzenko

06/12/2015

06:30 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Fixed EDITOR regression, fixed all issues mentioned in the code review except the FRAME realization (only @VIEW@ and ... Igor Skornyakov
05:13 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Regarding the previous question. Is it OK to add a separate method @setInititialInnerLines()@ for use in compilation ... Igor Skornyakov
04:43 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I have a problem. P2J compiles
DEFINE VARIABLE sl AS CHARACTER NO-UNDO
VIEW-AS SELECTION-LIST
INNER-LINES ...
Igor Skornyakov
09:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Please set it to M12.
Done.
Igor Skornyakov
09:23 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please set it to M12. Greg Shah
09:22 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> You can add watchers later, using the "Watchers (x)" section at the right side-bar of the task pa...
Igor Skornyakov
09:19 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> BTW: I've created another task #2582 as per Constantin request but forgot to add watches at the creation and I do n... Greg Shah
09:09 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> No. Please create a new task in the UI project and set its target version to M12. Also add me a...
Igor Skornyakov
08:52 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> Should I fix this bug in the scope of this task?
No. Please create a new task in the UI project and set its ta...
Greg Shah
06:06 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
With P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different... Igor Skornyakov
03:41 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Besides the items requested from the code review, what else still needs to be done for this task?...
Igor Skornyakov
04:45 PM Feature #2563: implement GUI EDITOR widget
>Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefau... Eugenie Lyzenko
04:09 PM Feature #2563: implement GUI EDITOR widget
Eugenie, new question: are you sure the button's DEFAULT attribute needs to be checked in @FrameGuiImpl.processDefaul... Constantin Asofiei
04:32 PM Feature #2252: implement GUI client support
The attached implements ALERT-BOX widget in Swing GUI. As related changes it also adds support for modal windows and ... Hynek Cihlar
09:04 AM Bug #2586: FillInWidget.getScreenValue() incorretly returns blank
Another minor issue with the @FillInWidget.getScreenValue()@
If you run p2j conversion of this test and type a space...
Igor Skornyakov
08:56 AM Bug #2586: FillInWidget.getScreenValue() incorretly returns blank
ith P2L FillInWidget.getScreenValue() returns blank if the first read access was when the focus was in the different ... Igor Skornyakov
08:55 AM Bug #2586 (New): FillInWidget.getScreenValue() incorretly returns blank
Igor Skornyakov
06:05 AM Feature #2546: implement combo-box widget in GUI
Eugenie, first of all, see note 77 and the testcase at this note - the drop-down's coordinates are still incorrect. ... Constantin Asofiei
08:51 PM Feature #2546: implement combo-box widget in GUI
>That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Eugenie Lyzenko
03:25 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I can check this field @WindowGuiImpl.mousePressedSource@ in @MenuItemGuiImpl.mouseMoved()@ to...
Constantin Asofiei

06/11/2015

05:49 PM Feature #2546: implement combo-box widget in GUI
That will be a memory leak. Static widgets shouldn't last for the application lifetime. They should only live while ... Greg Shah
05:37 PM Feature #2546: implement combo-box widget in GUI
>My only question is about @WidgetRegistry.addContainer()@. How do those registered widgets get removed when they are... Eugenie Lyzenko
02:36 PM Feature #2546: implement combo-box widget in GUI
Code Review evl_upd20150610a.zip
I think this is very good. I especially like the new @EntryFieldGuiImpl@.
My ...
Greg Shah
09:19 PM Feature #2546: implement combo-box widget in GUI
Some samples to illustrate @SIMPLE@ mode of the combo-box. Eugenie Lyzenko
08:56 PM Feature #2546: implement combo-box widget in GUI
The next update for review has the good shape combo-box implementation with all three modes available. Key and mouse ... Eugenie Lyzenko
05:33 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Besides the items requested from the code review, what else still needs to be done for this task? Greg Shah
01:13 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> I think it is realized the first time it is made visible. @ENABLE@ is just one way to make the...
Igor Skornyakov
01:11 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
>> 3. Should GenericFrame.validateLayout() be called whenever the frame is realized (not just during ENABLE)?
>
> S...
Greg Shah
11:23 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Code Review ias_upd20150605a.zip
> 3. Should @GenericFrame.validateLayout()@ be called wheneve...
Igor Skornyakov
10:29 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Code Review ias_upd20150605a.zip
1. I think we may want to implement a method in @GenericWidget@ for the core vali...
Greg Shah
03:34 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> OK, the plan:
>
> 1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side...
Igor Skornyakov
09:31 AM Feature #2422: add features to BROWSE
Yes, you should go ahead and implement it. Inserting before the first or after the last seems like something that is... Greg Shah
09:21 AM Feature #2422: add features to BROWSE
> I would like you to please get the current update through regression testing and checked in. This will free up oth... Stanislav Lomany
09:04 AM Feature #2422: add features to BROWSE
I would like you to please get the current update through regression testing and checked in. This will free up other... Greg Shah
07:12 AM Feature #2422: add features to BROWSE
> What else is open in this task?
My checklist:
# Page up/down, home/end doesn't work in editable browse.
# Unin...
Stanislav Lomany
02:35 AM Feature #1790: implement menu support
I'm trying to implement the following behavior. Assume we have menubar. Mouse pointer is located somewhere outside of... Vadim Gindin

06/10/2015

06:13 PM Feature #2422: add features to BROWSE
> AUTO-ZAP and CURSOR-OFFSET are done
OK.
> except separate task #2576. Let me know if I should work on this t...
Greg Shah
12:11 PM Feature #2422: add features to BROWSE
> In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED fill-in, not necessarily this one@... Stanislav Lomany
11:36 AM Feature #2422: add features to BROWSE
> When do you expect to have everything 100% complete? Igor's work in #2534 is dependent upon your changes for @AUTO... Stanislav Lomany
10:49 AM Feature #2422: add features to BROWSE
Code Review svl_upd20150610a.zip
In regard to this comment @// Oddly enough, 4GL returns zap state of the FOCUSED ...
Greg Shah
04:52 AM Feature #2422: add features to BROWSE
Removed excess function @isNewRow@ from the previous update. Stanislav Lomany
06:12 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
OK, the plan:
1. You can keep the @DISABLE-AUTO-ZAP@ support in the config and server-side getters/setters of your...
Greg Shah
12:02 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Actually I suggest to retain a DISABLE-AUTO-ZAP support in the config and at the server-side (getters/setters).
Gr...
Igor Skornyakov
11:48 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Not for FILL-IN. But COMBO-BOX support is not part of Stanislav's work.
>
For the COMBO-BOX t...
Igor Skornyakov
11:32 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> Do you think that it makes sense for me to continue working on the AUTO-ZAP?
Not for FILL-IN. But COMBO-BOX sup...
Greg Shah
11:19 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg,
As I can see my changes for the FillIn significantly intersect with ones of Stanislav. My first impression is ...
Igor Skornyakov
10:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422.
Thank you Greg.
Igor Skornyakov
10:42 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Stanislav has also implemented @CURSOR-OFFSET@ for @FillIn@ in #2422. Greg Shah
10:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please look at Stanislav's most recent changes in #2422. He is making changes related to @AUTO-ZAP@ in @FillIn@. Sp... Greg Shah
02:53 PM Feature #1790: implement menu support
> I've found that such fields are exist not in config classes
They would only be put into config classes if the da...
Greg Shah
12:01 PM Feature #1790: implement menu support
I've found that such fields are exist not in config classes, but in GUI widget classes itself. For example @ButtonGui... Vadim Gindin
11:56 AM Feature #1790: implement menu support
The question about widget (menu-item or sub-menu) state, that could be changed by mouse events: "mouse enter" (mouse ... Vadim Gindin
08:26 PM Feature #2546: implement combo-box widget in GUI
The next update for review has suggested approach for SIMPLE mode implementation. The idea is a bit different that us... Eugenie Lyzenko

06/08/2015

06:23 PM Bug #2582: Some key labels are not supported by p2j
The attached is the updated @key_code_report.p@ program which outputs additional key labels and its output. Igor Skornyakov
07:57 AM Bug #2582: Some key labels are not supported by p2j
P2J doesn't support some valid key labels (such as @CTRL-ALT-A@). The 4GL documentation contains misprints and is not... Igor Skornyakov
07:50 AM Bug #2582 (New): Some key labels are not supported by p2j
Igor Skornyakov
05:11 PM Feature #2422: add features to BROWSE
Update for review. INSERT-ROW, CURSOR-OFFSET, AUTO-ZAP and CURRENT-ROW-MODIFIED. Stanislav Lomany
04:27 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Is this something you need for the current task? If not, please create another task unde...
Igor Skornyakov
04:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor Skornyakov wrote:
> > > @Keyboard.keyCode(event)@ retu...
Constantin Asofiei
03:31 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Constantin Asofiei wrote:
> Igor Skornyakov wrote:
> > @Keyboard.keyCode(event)@ returns -1 for some valid key labe...
Igor Skornyakov
01:59 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> @Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a...
Constantin Asofiei

06/07/2015

11:32 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I think I understand what's up. Some keycodes in 4GL have different labels and @keylabel@ function returns only one o... Igor Skornyakov
11:07 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
>
> We d...
Igor Skornyakov
10:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
We have something like that already, see @testcases/uast/keyboards/key_code_report.p@
We did use that (and some ot...
Greg Shah
10:49 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> Please post the list of which key labels you have found which are wrong. For each one, please al...
Igor Skornyakov
09:49 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please post the list of which key labels you have found which are wrong. For each one, please also post the key code... Greg Shah
05:48 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
@Keyboard.keyCode(event)@ returns -1 for some valid key labels (such as @CTRL-ALT-X@). As a result (?) the trigger @O... Igor Skornyakov

06/05/2015

04:28 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Let fi be a FILL-IN widget. According to my tests the AUTO-ZAP and DISABLE-AUTO-ZAP attributes' behavior is as descri... Igor Skornyakov
12:25 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Greg Shah wrote:
> For now, just put a very clear TODO into the code at that point. The bug is obscure and hopefu...
Igor Skornyakov
12:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
> At this moment the only way to fix it I can see is to make all descendants of the BaseDataType to be childs of the ... Greg Shah
11:54 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Another solution to the above mentioned issue is to use static immutable constant @BaseDataType.unknown@ (of type Bas... Igor Skornyakov
11:49 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
I've just realized the following. If we assign a value to an attribute via widget handle then 'unknown' literal @?@ i... Igor Skornyakov
09:46 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Please review the current version of the code.
NUM-ITEMS runtime support (combo-box and selection-list)
INNER-LIN...
Igor Skornyakov
03:03 PM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget bro...
Constantin Asofiei
12:28 PM Feature #2546: implement combo-box widget in GUI
>Please use the -Dwidgetbrowser=yes when starting the GUI client to bring up the widget browser and see where everyth... Eugenie Lyzenko
12:08 PM Feature #2546: implement combo-box widget in GUI
>Eugenie: actually I do think this is the time to separate this functionality. As Constantin notes, this is likely to... Eugenie Lyzenko
11:51 AM Feature #2546: implement combo-box widget in GUI
>> if (inFocus != null && !isChui() && inFocus instanceof ScrollableList &&
>> evt.getEvent().ge...
Eugenie Lyzenko
10:43 AM Feature #2546: implement combo-box widget in GUI
>> ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box rel... Greg Shah
09:28 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl s...
Constantin Asofiei
09:24 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >the ThinClient change related to focus lost: we already have something done related to thi...
Constantin Asofiei
09:14 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> >...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the ...
Constantin Asofiei
11:41 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > #. Does this scenario work for GUI in the same way? I recall th...
Vadim Gindin
04:51 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> #. Does this scenario work for GUI in the same way? I recall that for GUI 2 classes are used to...
Constantin Asofiei

06/04/2015

03:45 PM Feature #1790: implement menu support
I wanted to ask some common question about repainting in GUI.
For ChUI I need to post new @PaintEvent@ to event q...
Vadim Gindin

06/03/2015

01:54 PM Feature #2546: implement combo-box widget in GUI
>ComboBoxGuiImpl and FillInGuiImpl: can you think of a way to sub-class the FillInGuiImpl so that the combo-box relat... Eugenie Lyzenko
01:17 PM Feature #2546: implement combo-box widget in GUI
>the ThinClient change related to focus lost: we already have something done related to this for the popup, via GuiDr... Eugenie Lyzenko
11:56 AM Feature #2546: implement combo-box widget in GUI
> That's why I need to know this info.
Please put comments in the code to explain this.
Greg Shah
10:26 AM Feature #2546: implement combo-box widget in GUI
>...To me, the drop-down in GUI looks like is dependent on the size and coordinates of the associated combo-box widge... Eugenie Lyzenko
08:27 AM Feature #2546: implement combo-box widget in GUI
>how did you determine the ScrollBar.visibleRange default value?
The same value as @DefaultList.visibleRows@.
Eugenie Lyzenko
07:12 AM Feature #2546: implement combo-box widget in GUI
Eugenie, this are some notes about evl_upd20150602a.zip:
* @DropDownGuiImpl.setHeightAndPos@: you are assuming that ...
Constantin Asofiei
08:31 PM Feature #2546: implement combo-box widget in GUI
Today update for review has basic implementation of the @DROP-DOWN@ mode. The entry field is editable and until anoth... Eugenie Lyzenko

06/02/2015

05:37 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
To provide the correct implementaion of the REPLACE method for list widgets (COMBO-BOX/SELECTION-LIST/RADIO-SET) a ne... Igor Skornyakov
06:50 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
Igor Skornyakov wrote:
> The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly...
Constantin Asofiei
03:30 PM Feature #1790: implement menu support
You are right and now it works. Thank you very much! Vadim Gindin
03:23 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> I've made the following changes:
> #. I've set menu children @physicalLocation@ to relative v...
Constantin Asofiei
03:19 PM Feature #1790: implement menu support
I've made the following changes:
#. I've set menu children @physicalLocation@ to relative value
#. I used relative ...
Vadim Gindin
02:57 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(i...
Constantin Asofiei
02:24 PM Feature #1790: implement menu support
If so, what about methods like @GuiDriver.drawString(String, int, int)@, @GuiDriver.drawLine(int, int, int, int)@ or ... Vadim Gindin
12:48 PM Feature #1790: implement menu support
> adjust the menu's location to be relative to its parent
This one.
It is important that the @physicalLocation(...
Greg Shah
12:35 PM Feature #1790: implement menu support
Vadim Gindin wrote:
> I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar wi...
Constantin Asofiei
08:32 AM Feature #1790: implement menu support
I faced with the problem of defining a widget, mouse is clicked over. I have simple menubar with 3 menu-items and one... Vadim Gindin
01:15 PM Feature #1811: implement the AJAX client driver
> And if the target OS is expected to not provide these fonts, we can define these as "custom fonts" and pass to the... Greg Shah
07:07 AM Feature #1811: implement the AJAX client driver
Anton Breaur wrote:
> The way I envisioned the flow to work is that we send font information to the web client, like...
Constantin Asofiei
08:18 PM Feature #2546: implement combo-box widget in GUI
The next update for review as current state reflection. This is DROP-DOWN mode first step with @FillInGuiImpl@ integr... Eugenie Lyzenko

06/01/2015

06:38 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
The FillIn.appVar initial value is not 'unknown'. As a result it is impossible to correctly calculate screenValue() w... Igor Skornyakov

05/31/2015

06:47 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX
1. SCREEN-VALUE attribute getter returns empty string (at least for the FILL-IN widget).
2. SELECTION-TEXT attribute ...
Igor Skornyakov

05/30/2015

09:12 PM Feature #2546: implement combo-box widget in GUI
The update for review presents the current state of the combo-box. The server side updated to introduce new option - ... Eugenie Lyzenko

05/29/2015

01:40 PM Feature #1811: implement the AJAX client driver
Please provide more details about exactly what you have tried to do and the results of each of those experiments/effo... Greg Shah
10:02 AM Feature #1811: implement the AJAX client driver
The way I envisioned the flow to work is that we send font information to the web client, like font name, size and st... Anton Breaur
06:48 AM Feature #2546: implement combo-box widget in GUI
Constantin Asofiei wrote:
> > What features in @FillInGuiImpl@ are critical and can not be changed in any cases? Ano...
Eugenie Lyzenko
01:40 AM Feature #2546: implement combo-box widget in GUI
Eugenie Lyzenko wrote:
> Are you currently working on fill-in GUI implementation?
No, I'm not working on GUI FILL-...
Constantin Asofiei

05/28/2015

04:50 PM Feature #2546: implement combo-box widget in GUI
Constantin,
To implement different combo-box modes with editable entry field I'm planning to integrate fill-in GUI...
Eugenie Lyzenko
11:02 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > It could print the title on the top ...
Vadim Gindin
10:36 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > It could print the title on the top left corner when it draws r...
Vadim Gindin
07:46 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> It could print the title on the top left corner when it draws rectangle but it doesn't happen....
Constantin Asofiei
07:06 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > MENU widget does not support coordinate attributes and WIDTH/HE...
Vadim Gindin
04:41 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> MENU widget does not support coordinate attributes and WIDTH/HEIGHT attributes too..
OK, I di...
Constantin Asofiei

05/27/2015

06:13 PM Feature #2546: implement combo-box widget in GUI
The update for review has two new changes:
1. Implementation for first char search/select in GUI combo-box when drop...
Eugenie Lyzenko
08:40 PM Feature #2546: implement combo-box widget in GUI
The update for review merged with recent code base. In addition it adds tooltip feature to the combo-box and implemen... Eugenie Lyzenko
11:51 AM Feature #1790: implement menu support
Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > I'm trying to draw simple menubar and I have coordinates proble...
Vadim Gindin
07:21 AM Feature #1790: implement menu support
Vadim Gindin wrote:
> I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point ...
Constantin Asofiei
06:25 AM Feature #1790: implement menu support
I'm trying to draw simple menubar and I have coordinates problem. I expected that [0,0] point will reside under the w... Vadim Gindin

05/26/2015

03:50 PM Feature #1811: implement the AJAX client driver
> 1. Consider the fonts that are defined in @src/font-metrics.xml@ and @FontTable.standardFontTable@.
From what I ...
Anton Breaur
09:55 AM Feature #1811: implement the AJAX client driver
Code Review fonts_js.zip from note 712
Overall, this is moving in the right direction.
Next steps:
1. Consid...
Greg Shah
01:23 PM Feature #2422: add features to BROWSE
@CURRENT-ROW-MODIFIED@ logic differs from @MODIFIED@ logic. The latter is tricky, while @CURRENT-ROW-MODIFIED@ is str... Stanislav Lomany
10:26 AM Feature #2546: implement combo-box widget in GUI
Multiple selection investigation results. In ChUI only DROP-DOWN-LIST mode can be active(even if other specified). In... Eugenie Lyzenko

05/25/2015

03:28 PM Feature #1811: implement the AJAX client driver
Added the @fontMetrics@ module from @p2j.screen.js@ and managed to compute all the metrics described in @com.goldenco... Anton Breaur
03:19 AM Feature #1794: implement font support
Greg Shah wrote:
> Code Review ca_upd20150520d.zip
>
> It looks good. This is a nice improvement over my previou...
Constantin Asofiei

05/23/2015

10:06 AM Feature #1794: implement font support
Code Review ca_upd20150520d.zip
It looks good. This is a nice improvement over my previous approach (yours is muc...
Greg Shah

05/22/2015

03:36 PM Feature #1811: implement the AJAX client driver
Anton Breaur wrote:
> > I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid...
Greg Shah
09:50 AM Feature #1811: implement the AJAX client driver
> I do worry that we won't have access to all the metrics that we need, but I'm happy to avoid custom font rendering ... Anton Breaur
08:37 AM Feature #1811: implement the AJAX client driver
> I think the proper way is to use @save()@ to store off the context before drawing the scaled string and then @resto... Anton Breaur
08:31 AM Feature #1811: implement the AJAX client driver
I'm OK with not using @opentype.js@, so long as we can get everything implemented which we need. I do worry that we ... Greg Shah
07:54 AM Feature #1811: implement the AJAX client driver
I gave up opentype.js and took a different approach. We can apply a scaling transformation to the canvas context, and... Anton Breaur
 

Also available in: Atom