Activity

From 06/17/2015 to 07/16/2015

07/17/2015

09:04 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10907@.
The update has improved implementation for width scali... Eugenie Lyzenko

07/16/2015

01:57 PM Feature #2567: add misc widget support part 2: more options, attributes and methods: Hynek Cihlar wrote:
> Igor, I fixed this as part of 2424b.
Thank you Hynek.
Igor Skornyakov
01:53 PM Feature #2567: add misc widget support part 2: more options, attributes and methods: Hynek Cihlar wrote:
>
> - a bug in @ZeroLayoutColumn@ positioning the selection-list widget at @ROW@ 3 instead of 1. ... Hynek Cihlar
11:28 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: Greg Shah wrote:
> Igor Skornyakov wrote:
> > I've noticed that X and Y attributes' p2j support is not compatible wit... Hynek Cihlar
10:02 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: Igor Skornyakov wrote:
> I've noticed that X and Y attributes' p2j support is not compatible with 4GL. In the attach... Greg Shah
09:54 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: I've noticed that X and Y attributes' p2j support is not compatible with 4GL. In the attached test the values are (1,... Igor Skornyakov
10:08 AM Feature #2546: implement combo-box widget in GUI: > Some consideration for introducing the push screen definition lock to discuss.
> ...
Constantin will handle the... Greg Shah
08:20 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10906@.
In this update:
1. According to my previous suggest t... Eugenie Lyzenko
09:09 AM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> You may say that at the point of widget registration its state should already be synchroni... Hynek Cihlar
08:26 AM Feature #2422: add features to BROWSE: Guys, about "transparent" data sending with AspectJ. P2J code calculates differences between "active (current) config... Stanislav Lomany
03:40 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Sergey Ivanovskiy wrote:
> >
> > Don't consider it as a suggestion but if JWindow is replaced ... Sergey Ivanovskiy

07/15/2015

03:47 PM Feature #2546: implement combo-box widget in GUI: Some consideration for introducing the push screen definition lock to discuss.
I would suggest another way of impl... Eugenie Lyzenko
01:59 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Can we defer all screen definition pushing until first @GenericFrame.enable()@ call? Or oth... Constantin Asofiei
03:06 PM Feature #1811: implement the AJAX client driver: Hynek Cihlar wrote:
> @ContentPane@ already contains a call to @window.dispose()@ so it should be enough to make sur... Greg Shah
12:50 PM Feature #1811: implement the AJAX client driver: @ContentPane@ already contains a call to @window.dispose()@ so it should be enough to make sure @ContentPane.quit()@ ... Hynek Cihlar
12:46 PM Feature #1811: implement the AJAX client driver: Greg Shah wrote:
> Some questions related to window creation/destruction:
>
> 1. What is the purpose of the title pa... Hynek Cihlar
12:29 PM Feature #1811: implement the AJAX client driver: Some questions related to window creation/destruction:
1. What is the purpose of the title passed to the @JWindow@... Greg Shah
01:50 PM Feature #2252: implement GUI client support: Rebased task branch 1796b from P2J trunk revision 10895 (branch revision 10914). Constantin Asofiei
08:42 AM Feature #2252: implement GUI client support: Sergey Ivanovskiy wrote:
>
> Don't consider it as a suggestion but if JWindow is replaced by JDialog, then a deskt... Hynek Cihlar
06:12 AM Feature #2252: implement GUI client support: Greg, Hynek
What is the reason to implement a JFrame for any normal 4GL window and a JWindow for alert-boxes/dialog... Sergey Ivanovskiy
12:16 PM Feature #1790: implement menu support: > So, the easiest way is to emit new Object[] instead of new handle[] for the value of second parameter of addEvent.
... Greg Shah
04:58 AM Feature #1790: implement menu support: I faced with the following conversion problem. I have a testcase with different triggers defined and here are 2 of th... Vadim Gindin
08:17 AM Feature #2422: add features to BROWSE: Please implement both. Greg Shah
07:52 AM Feature #2422: add features to BROWSE: Greg, should I implement @browse:MODIFIED@ attribute or @column:MODIFIED@ too? I ask because they have completely dif... Stanislav Lomany
07:54 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hello Eugenie.
I've introduced the internal ids exactly for the correct restoring of the selected item. I've tested... Igor Skornyakov
07:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Eugenie.
> From the other side I've realized now that if one replaces LIST-ITEMS/LISTS-ITE... Eugenie Lyzenko
05:34 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Eugenie.
The test seems running OK with my version of the code and looking at your version of the @ComboBoxWidget@ I... Igor Skornyakov
02:28 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Eugenie Lyzenko wrote:
> @uast/combo_box/combo_box12_3.p@ from testcases bzr repo. I guess you will need the GUI com... Igor Skornyakov

07/14/2015

07:49 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10905@.
This small update fixes the dynamic combo-box behavior... Eugenie Lyzenko
07:46 PM Feature #2546: implement combo-box widget in GUI: Can we defer all screen definition pushing until first @GenericFrame.enable()@ call? Or other frame related call that... Eugenie Lyzenko
04:41 PM Feature #2546: implement combo-box widget in GUI: > To cover the case of setting the FRAME attr in and outside the CREATE ... ASSIGN clause, we can:
> ...
Yes, g... Greg Shah
04:38 PM Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> We should be able to bypass pushing screen definitions until the frame is set.
Yes, this is alr... Constantin Asofiei
04:22 PM Feature #2546: implement combo-box widget in GUI: I should say this a different way.
I understand that we can't depend on there being a FRAME defined in the ASSIGN.... Greg Shah
04:13 PM Feature #2546 (WIP): implement combo-box widget in GUI: Wouldn't it be better to always bracket @CREATE WINDOW@ assign by setting @batch@ mode on in @GenericFrame@ and then ... Greg Shah
04:03 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10903@.
I'm OK with these changes. Constantin Asofiei
04:00 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10904@.
Consider that the widget's FRA... Constantin Asofiei
09:19 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10904@.
This update adds batch mode lock when widget attribute... Eugenie Lyzenko
06:30 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: @uast/combo_box/combo_box12_3.p@ from testcases bzr repo. I guess you will need the GUI combo-box recent code too(bra... Eugenie Lyzenko
05:35 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Eugenie Lyzenko wrote:
> The bug has been found during testing combo-box widget with setting attribute @LIST-ITEMS@ ... Igor Skornyakov
05:27 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The bug has been found during testing combo-box widget with setting attribute @LIST-ITEMS@ outside the @define ... vi... Eugenie Lyzenko
04:52 PM Feature #2563: implement GUI EDITOR widget: Code Review Task Branch 2563b, Revision 10903
I'm fine with the changes. If it passes testing, please merge/commi... Greg Shah
03:41 PM Feature #2563: implement GUI EDITOR widget: Please review task branch 2563b, revision 10903.
Revision 10901 is currently in runtime testing. Revisions 10902/... Constantin Asofiei
04:43 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> >> On the other hand, it doesn't seem too hard to implement. Are we really saving much time to av... Hynek Cihlar
04:38 PM Feature #2252: implement GUI client support: >> On the other hand, it doesn't seem too hard to implement. Are we really saving much time to avoid this?
>
> To i... Greg Shah
03:42 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> > The window is moved to negative Y so that the bottom of the window is visible on the screen.
>... Hynek Cihlar
03:15 PM Feature #2252: implement GUI client support: > The window is moved to negative Y so that the bottom of the window is visible on the screen.
Is this implicitly ... Greg Shah
02:45 PM Feature #2252: implement GUI client support: It seems that 4GL internally limits coordinates to smaller values than allowed in positional attributes (X, Y).
He... Hynek Cihlar
08:17 AM Feature #2252: implement GUI client support: The value of 39.48 seems to be the height of the display less window decorations. The value indeed copies screen reso... Hynek Cihlar
08:05 AM Feature #2252: implement GUI client support: I am guessing that when converted to a pixel value (based on the default font's metrics), that (at least some of) the... Greg Shah
02:37 PM Feature #1811: implement the AJAX client driver: I am working on the new window and new child window support for the web client. In the current implementation, we us... Greg Shah
09:17 AM Feature #1811: implement the AJAX client driver: Rebased task branch 1811o from P2J trunk revision 10895. Greg Shah
08:29 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: Tha task branch 2567a has been created. First updates are committed to the branch, revno: 10896 Igor Skornyakov

07/13/2015

06:27 PM Feature #2252: implement GUI client support: For #2424, please assess whether any of these should be replicated in P2J.
*Case 1*... Hynek Cihlar
03:17 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Also, it seems to me that now is the time to go ahead and implement a cleaner set of classes for ... Hynek Cihlar
02:47 PM Feature #2252: implement GUI client support: OK, please go ahead and implement a compatible max sizing algorithm.
Also, it seems to me that now is the time to ... Greg Shah
02:09 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> > The question is how far should we go to replicate this?
>
> I'd like to see the algorithm be... Hynek Cihlar
11:13 AM Feature #2252: implement GUI client support: > A way out of this could be an interactive calibration process that would provide these (and possibly other) dynamic... Greg Shah
10:59 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> > A Windows theme may differ with Windows versions.
>
> Yes, but for us it is going to be some... Hynek Cihlar
10:32 AM Feature #2252: implement GUI client support: > The window border size is however hardcoded to a constant value.
I expect that we will allow this to be configur... Greg Shah
10:18 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> The window decoration dimensions are values that we hard code in P2J based on the chosen Windows ... Hynek Cihlar
09:43 AM Feature #2252: implement GUI client support: > It seems that 4GL calculates these maximum values based on window decorations - i.e. window caption size and border... Greg Shah
09:28 AM Feature #2252: implement GUI client support: This relates to #2424.
I identified a problem related to the max allowed window size. In GUI, a window widget trun... Hynek Cihlar
05:38 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10903@.
This update includes the changes required to complete ... Eugenie Lyzenko
01:44 PM Feature #2546: implement combo-box widget in GUI: More finding for @MAX-CHARS@ in 4GL @COMBO-BOX@.
The default value is @0@, not @255@, like as the reaction to sett... Eugenie Lyzenko
01:25 PM Feature #2546: implement combo-box widget in GUI: For @MAX-CHARS@ implementation in @COMBO-BOX@:
In all modes, the attribute is ignoring, @MAX-CHAR@ maximum value i... Eugenie Lyzenko
12:02 PM Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that co... Constantin Asofiei
08:46 AM Feature #2546: implement combo-box widget in GUI: Try using @createJavaAst()@ instead of @createPeerAst()@. Greg Shah
05:20 PM Feature #1811: implement the AJAX client driver: A first pass implementation of clipboard support is checked in to task branch 1811o. The rest of the work will be de... Greg Shah
01:07 PM Feature #1790: implement menu support: As Constantin and I have noted multiple times:
> the MenuContainerWidget needs to inherit from BaseEntity.
Sea... Greg Shah
12:18 PM Feature #1790: implement menu support: When I refactored menu classes I removed unneeded fields from classes and those setters, that appear in config classe... Vadim Gindin
09:33 AM Feature #1790: implement menu support: This is a problem, but do not work on it now. We will leave this as a TODO.
We also have this same problem with t... Greg Shah
12:25 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> I meant what testcase did you use to check the SET-SELECTED method?
I think it was the ... Igor Skornyakov
12:23 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Constantin Asofiei wrote:
> > Igor, can you point me to a testcase which covers your H046 ... Constantin Asofiei
12:16 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> Igor, can you point me to a testcase which covers your H046 change in Editor.java? This ... Igor Skornyakov
12:07 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor, can you point me to a testcase which covers your H046 change in Editor.java? This no longer works with the #256... Constantin Asofiei
12:01 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> No, you are not wrong. I'm just confirming my understanding that the only remaining functionalit... Constantin Asofiei
12:05 PM Feature #2422: add features to BROWSE: > So considering this complexity and that it is not likely to be used, I suggest to add it to the quirks list.
OK. Greg Shah
11:51 AM Feature #2422: add features to BROWSE: Greg, about @REFRESHABLE@. Its typical use case is to turn it off - reposition - turn it on. However there is a poten... Stanislav Lomany
11:59 AM Feature #2563: implement GUI EDITOR widget: Rebased task branch 2563b from P2J trunk revision 10895 (new branch revision 10899).
There is a compile problem, n... Constantin Asofiei

07/10/2015

06:29 PM Feature #1790: implement menu support: I faced with the difficulty. When nested submenus exceed window size (width or height) they do not shrink to window s... Vadim Gindin
05:44 PM Feature #2422: add features to BROWSE: At this point there are the following issues left:
# In 4GL repositioned row is <= DOWN value. DOWN value is calcula... Stanislav Lomany
05:38 PM Feature #2546: implement combo-box widget in GUI: I put the following rule into @convert/ui_statements.rules@(end of @ascent-rules@ section):... Eugenie Lyzenko
01:29 PM Feature #2546: implement combo-box widget in GUI: > We need to generate special marker indicating the last internal assignment in CREATE WIDGET... may be.
Correct. ... Greg Shah
12:10 PM Feature #2546: implement combo-box widget in GUI: Rebased task branch @2546a@ from P2J trunk revision @10895@, new branch revision is @10902@. Eugenie Lyzenko
12:09 PM Feature #2546: implement combo-box widget in GUI: >For static frames, we handle this in GenericFrame.setupFrame(). In other words, in GenericFrame.pushScreenDefinition... Eugenie Lyzenko
11:39 AM Feature #2546: implement combo-box widget in GUI: > In P2J every assignment inside create widget... causes the pushScreenDefinition() call and almost everything after ... Greg Shah
11:19 AM Feature #2546: implement combo-box widget in GUI: >Is this different from how the 4GL works?
Yes in 4GL there is no such condition, INNER-LINES setting can be after... Eugenie Lyzenko
10:34 AM Feature #2546: implement combo-box widget in GUI: > For dynamic widget we have to place INNER-LINES setting before VISIBLE and SENSITIVE to have proper scrollbar. This... Greg Shah
10:33 AM Feature #2546: implement combo-box widget in GUI: The testcase set updated to rev @1290@. The only change is in @combo_box15.p@. For dynamic widget we have to place @I... Eugenie Lyzenko
09:38 AM Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that co... Eugenie Lyzenko
09:29 AM Feature #2546: implement combo-box widget in GUI: Eugenie: the only attribute that needs implementation is @MAX-CHARS@. That was something that could not be done in #... Greg Shah
08:58 AM Feature #2546: implement combo-box widget in GUI: > I think 4GL makes the row reposition at runtime on the layout stage so the screen coordinate for combo_box15.p is ... Greg Shah
08:54 AM Feature #2546: implement combo-box widget in GUI: > This is the list I see.
>
> ...
Yes, I know that we have many attributes and methods that are not yet finishe... Greg Shah
08:04 AM Feature #2546: implement combo-box widget in GUI: >I think you are correct - P2J uses the ROW relative as to the top frame border, while 4GL uses the ROW as relative t... Eugenie Lyzenko
07:54 AM Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Please commit the tests you are using for the screens you posted...
Done. Committed... Eugenie Lyzenko
11:54 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> I think this is not @combo-box@ specific issue, but all dynamic widgets with explicit coord... Constantin Asofiei
11:35 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> The only issue I see for now is the proper location in case we have NOT side labeled widget... Constantin Asofiei
01:49 PM Bug #2607: The java generated code isn't compiled due to there is some implicit scoping that goes...: The following exceptions occur if the conversion 4GL->Java is applied to the attached addressApp.p
compile:
[ja... Sergey Ivanovskiy
01:39 PM Bug #2607 (New): The java generated code isn't compiled due to there is some implicit scoping tha...: Sergey Ivanovskiy
10:19 AM Feature #2606: implement GUI runtime support for SELECTION-LIST: This task is for full implementation of the GUI widget implementation for SELECTION-LIST. Both static and dynamic us... Greg Shah
10:16 AM Feature #2606 (Closed): implement GUI runtime support for SELECTION-LIST: Greg Shah
09:27 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> No, you are not wrong. I'm just confirming my understanding that the only remaining functionalit... Igor Skornyakov
09:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: No, you are not wrong. I'm just confirming my understanding that the only remaining functionality from this task is ... Greg Shah
09:22 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Igor: is the only feature left for this task the MAX-CHARS GUI support?
Greg. In my understand... Igor Skornyakov
09:18 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor: is the only feature left for this task the MAX-CHARS GUI support? Greg Shah
09:01 AM Feature #2534 (Closed): methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah
09:02 AM Feature #2486 (Closed): enhance editor functionality: Greg Shah

07/09/2015

06:54 PM Feature #2546: implement combo-box widget in GUI: >1. Check and implement if required the possibility to handle not character data by combo-box. I mean if the combo-bo... Eugenie Lyzenko
06:49 PM Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> Can you let me know what you are thinking here? #2534 already has quite a few changes for combo-... Eugenie Lyzenko
05:43 PM Feature #2546: implement combo-box widget in GUI: > 2. Verify and implement all attribute and method for both static and dynamic combo-box.
Can you let me know what... Greg Shah
03:13 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Task branch @2546a@ for review updated to revision @10900@.
I'm OK with the changes. Constantin Asofiei
12:51 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10900@.
The updates included change for drop-down button reloc... Eugenie Lyzenko
05:31 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150709b.zip
I'm good with the changes.
Please commit and distribute this update. Well done! Greg Shah
05:23 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: After two runs the intersection of the failed tests' sets is @tc_job_002@ only. Igor Skornyakov
09:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > BTW: the problem was with the extra pushScreenDefinition which overrides dynamic header. It seems a little bit frag... Greg Shah
09:25 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I'm fine with the changes.
>
> The only thing I need you to change is that you should not have... Igor Skornyakov
09:12 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150709a.zip
I'm fine with the changes.
The only thing I need you to change is that you should ... Greg Shah
05:18 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: After a fix the test passed OK in a manual run. Full regression restarted. Igor Skornyakov
09:58 AM Bug #2605: pushScreenDefinition overrides dynamic header of the frame: The problem was revealed in the regression testing of the #2534. In the changes the conditional invocation of the @pu... Igor Skornyakov
09:46 AM Bug #2605 (New): pushScreenDefinition overrides dynamic header of the frame: Igor Skornyakov

07/08/2015

05:46 PM Feature #2546: implement combo-box widget in GUI: Task branch @2546a@ for review updated to revision @10899@.
The enhancements has been made to mouse event handling... Eugenie Lyzenko
09:44 AM Feature #2252: implement GUI client support: CUT/COPY/PASTE have alternative key mappings in Windows. I think we need to add those to @GuiKeyboard.standardKeyFun... Greg Shah

07/07/2015

07:54 PM Feature #2546: implement combo-box widget in GUI: Please review task branch @2546a@, revision @10898@.
This update has new approach that fixes the multiple combo-bo... Eugenie Lyzenko
02:41 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > The only issue I have is with code like this: @if (child != ... Constantin Asofiei
01:56 PM Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> The only issue I have is with code like this: @if (child != null && child instanceof Scr... Eugenie Lyzenko
07:59 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Please review task branch @2546a@, revision @10897@.
The only issue I have is with code li... Constantin Asofiei
10:49 PM Feature #2546: implement combo-box widget in GUI: Please review task branch @2546a@, revision @10897@.
Adding drop-down press opening fix. The main logic of drop-do... Eugenie Lyzenko
09:30 PM Feature #2546: implement combo-box widget in GUI: Rebased task branch @2546a@ from P2J trunk revision @10894@. Eugenie Lyzenko
05:16 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. M... Igor Skornyakov
04:57 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I recommend that you zip up the @p2j/@ directory on devsrv01 and copy it to your local system. Make sure to exclude ... Greg Shah
04:51 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The situation is very strange. On my machine the manual testing is OK (the dynamic header is in place). Igor Skornyakov
04:36 PM Feature #1807: implement clipboard support: Some things to note:
1. ChUI does support use of the CLIPBOARD system handle (including the VALUE attribute for bo... Greg Shah
04:20 PM Feature #1811: implement the AJAX client driver: The current clipboard support for the ChUI web client has many of the building blocks that are needed for GUI clipboa... Greg Shah
11:25 AM Feature #2563: implement GUI EDITOR widget: Rebased task branch 2563b from P2J trunk revision 10894 (new branch revision 10898).
Constantin Asofiei
10:02 AM Feature #2252: implement GUI client support: Rebased task branch 1796b from P2J trunk revision 10894 (branch revision 10906).
Constantin Asofiei

07/06/2015

07:33 PM Feature #2252: implement GUI client support: Rebased task branch 2424 from P2J trunk revision 10894 (branch revision 10896). Hynek Cihlar
03:37 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Greg, a conversion question; in 4GL, the following frames are equivalent:
> [...]
> In... Greg Shah
10:39 AM Feature #2252: implement GUI client support: Task branch 2559e committed to trunk as revision 10894. Hynek Cihlar
09:49 AM Feature #2252: implement GUI client support: > I only didn't expect any ChUI-specific features, hence no ChUI-specific sublass.
I see. Good. Greg Shah
09:43 AM Feature #2252: implement GUI client support: Greg Shah wrote:
> I think the best approach is to create GUI and ChUI subclasses of @WindowManager@ that can have m... Hynek Cihlar
09:34 AM Feature #2252: implement GUI client support: Go ahead and merge 2559e into the trunk.
The next time we have some work in @WindowManager@, we can make some fact... Greg Shah
08:06 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> Greg Shah wrote:
> > Code Review Task Branch 2559e Revision 10896
> >
> > This is good.
>... Hynek Cihlar
05:03 PM Feature #2546: implement combo-box widget in GUI: > Should I try to reboot it(not sure if I have enough permissions)?
No, let the customer handle that.
> The exc... Greg Shah
04:42 PM Feature #2546: implement combo-box widget in GUI: The exception from drop-down dismiss rule is mouse events in combo-box entry field or outside drop-down or combo-box(... Eugenie Lyzenko
04:30 PM Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> Does the 4GL code (actually, it is really the Windows drop-down control) dismiss the drop-down on... Eugenie Lyzenko
09:48 AM Feature #2546: implement combo-box widget in GUI: > The root cause was too early dismiss the drop-down. I have preferred to use mouse press due to mouse press does imm... Greg Shah
07:46 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Could you help me to find why sub-menu body is truncated and where the truncating is happen?
... Constantin Asofiei
04:42 AM Feature #1790: implement menu support: Constantin, could you look at my current changes in 1790d?
Here is my testcase:... Vadim Gindin

07/03/2015

07:29 PM Feature #2546: implement combo-box widget in GUI: Please review task branch @2546a@, revision @10894@.
This is my first usage of the branch upload process. All curr... Eugenie Lyzenko
05:16 PM Feature #2546: implement combo-box widget in GUI: Created task branch @2546a@ from P2J trunk revision @10893@. Eugenie Lyzenko
06:07 AM Feature #2546: implement combo-box widget in GUI: >Another issue with this test is some z-order problem: when the drop-down covers one or more widget, currently the co... Eugenie Lyzenko
04:42 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Well, the problem with the screen was reproduced manually. Igor Skornyakov
04:40 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Eugenie Lyzenko wrote:
> Try @CTRL-X@. This should also produce @GO@ function.
Thanks a lot! It works! Igor Skornyakov
04:37 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Sorry, but I need an advise? I'm trying to execute the test manually, and I have to send V... Hynek Cihlar
04:36 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Try @CTRL-X@. This should also produce @GO@ function. Eugenie Lyzenko
04:28 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Sorry, but I need an advise? I'm trying to execute the test manually, and I have to send VK_F1 at some step, but whe... Igor Skornyakov
02:58 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Constantin Asofiei wrote:
> MAJIC has some built-in "help" triggered by pressing F2 in almost all screens - this wil... Igor Skornyakov
02:35 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Greg Shah wrote:
> > Did you check this scenario by hand (manually trying the same inputs)... Constantin Asofiei
02:31 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Did you check this scenario by hand (manually trying the same inputs)?
Actually I tried to fin... Igor Skornyakov
01:55 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Did you check this scenario by hand (manually trying the same inputs)? Greg Shah
10:36 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The tc_item_stockroom_011 still fails. The mismatching screen is ... Igor Skornyakov
08:19 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: See #2603 for a response on the harness change. Greg Shah
05:22 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: After the second run only the tc_item_stockroom_011 test failed. However the mismatched screen in the report looks id... Igor Skornyakov
01:13 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review Task Branch 2559e Revision 10896
>
> This is good.
>
> 1. It is not a big deal,... Hynek Cihlar
12:34 PM Feature #2252: implement GUI client support: Code Review Task Branch 2559e Revision 10896
This is good.
1. It is not a big deal, but I'd prefer a better way to ... Greg Shah
08:49 AM Feature #2252: implement GUI client support: Greg, a conversion question; in 4GL, the following frames are equivalent:... Constantin Asofiei
08:21 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: Please create a task branch for this task (@2567a@) and commit all your current work. All subsequent work should be ... Greg Shah
08:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: I've finished with the WIDGET-ID. Igor Skornyakov
08:00 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: Greg Shah wrote:
> Basically, yes.
>
> We need to do whatever the 4GL does when the command line parameter @-usew... Igor Skornyakov
07:57 AM Feature #2567 (WIP): add misc widget support part 2: more options, attributes and methods: Igor said:
> To you mean that we only need to support the conversion of the access to the WIDGET-ID attribute with... Greg Shah

07/02/2015

06:55 PM Feature #2252: implement GUI client support: For #2559 I have:
Implemented window modality independently on the actual UI driver.
Improved positioning of top-... Hynek Cihlar
06:41 AM Feature #2252: implement GUI client support: Rebased task branch 1796b from P2J trunk revision 10893 (branch revision 10898).
Constantin Asofiei
05:37 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Well, the situation is much better now. All CTRL-C tests passed. Only one gso_test (gso_269) and two rc_tests (tc_ite... Igor Skornyakov
01:17 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> With the workaround, we are losing type information about the serialized field but in this cas... Igor Skornyakov
12:22 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> I suggest the following workaround in the @NativeTypeSerializer@
>
> public static vo... Hynek Cihlar
12:08 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Fixed serialization for the null string. Regression test restarted
When you have abends li... Constantin Asofiei
12:05 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed serialization for the null string. Regression test restarted Igor Skornyakov
11:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> (the visibility of the @mark@ field becomes 'public').
Please leave it protected instead o... Constantin Asofiei
11:44 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I'm OK with this.
Constantin/Hynek? Greg Shah
11:31 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Thank you Greg. I'm looking at this now. However NPE in @writeUFT()@ is weird. I've used it... Igor Skornyakov
10:55 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I guess this has something to do with your changes to the configuration processing or widget conf... Igor Skornyakov
10:47 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > Here is the stack trace for another common failure.
>
> com.goldencode.p2j.net.SilentUnwindException: Connection ... Greg Shah
10:23 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I don't understand what this bug has to do with our failure. They state that it is specific to J... Igor Skornyakov
10:17 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I don't understand what this bug has to do with our failure. They state that it is specific to JDK 9.
Please post... Greg Shah
10:05 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Sorry. I've previously found a wrong reference (it was about @DataOutputStream@). See however this one: https://netbe... Igor Skornyakov
10:01 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: The situation with NPE in @writeUTF()@ seems to be a known issue with OpenJDK. See https://bugs.openjdk.java.net/brow... Igor Skornyakov
09:14 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> I'm fine with the changes. What is the status of testing for this update?
There are still a... Igor Skornyakov
08:58 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150630a.zip
I'm fine with the changes. What is the status of testing for this update? Greg Shah
04:01 PM Feature #1790: implement menu support: Created task branch 1790d from P2J trunk revision 10893 Vadim Gindin
07:47 AM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> I can do that after you finish your browse modifications if the issue doesn't bother you a... Constantin Asofiei
07:45 AM Feature #2422: add features to BROWSE: I can do that after you finish your browse modifications if the issue doesn't bother you at this point. Stanislav Lomany
03:50 AM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> Yes, @queryId@ actually contained browse ID. Didn't know that it can also contain query I... Constantin Asofiei
02:38 AM Feature #2422: add features to BROWSE: Created task branch 2422b from P2J trunk revision 10893. Stanislav Lomany
07:06 AM Feature #2563: implement GUI EDITOR widget: Rebased task branch 2563b from P2J trunk revision 10893 (new branch revision 10897).
Constantin Asofiei
05:51 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> The next update for review presents the scaling factor implementation to eliminate hardcodi... Constantin Asofiei
09:28 PM Feature #2546: implement combo-box widget in GUI: The next update for review presents the scaling factor implementation to eliminate hardcoding adjustments. The idea i... Eugenie Lyzenko

07/01/2015

06:11 PM Feature #2422: add features to BROWSE: Yes, @queryId@ actually contained browse ID. Didn't know that it can also contain query ID (I know that sounds stran... Stanislav Lomany
04:15 PM Feature #2422: add features to BROWSE: Stanislav, one more issue: is a little confusing that the query ID at some point is the same as the browse ID... this... Constantin Asofiei
09:00 AM Feature #2422: add features to BROWSE: Constantin, I have no objections. Stanislav Lomany
07:43 AM Feature #2422: add features to BROWSE: Stanislav, is there a query-related reason why the browse columns (at the widget level) are linked with the BrowseMod... Constantin Asofiei
03:44 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> This testcase defines 2 nested submenus "Insider" is nested in "Submenu".
You have the @buil... Constantin Asofiei
10:57 AM Feature #1790: implement menu support: Constantin, your approach seems working at first sight. Now I have 2 problems with the testcase:... Vadim Gindin
02:32 PM Feature #1811: implement the AJAX client driver: Greg Shah wrote:
> Hynek:
>
> The @AbstractGuiDriver.newChildWindowEmulator()@ is only ever called from @GuiOutpu... Hynek Cihlar
01:09 PM Feature #1811: implement the AJAX client driver: Hynek:
The @AbstractGuiDriver.newChildWindowEmulator()@ is only ever called from @GuiOutputManager.realizeChildWin... Greg Shah
11:56 AM Feature #1811: implement the AJAX client driver: Created task branch 1811o from P2J trunk revision 10893.
There are 14 previous commits from this task. For this r... Greg Shah
09:48 AM Feature #2252: implement GUI client support: Rebased task branch 2559e from P2J trunk revision 10894 (branch revision 10893). Hynek Cihlar
04:56 AM Feature #2563: implement GUI EDITOR widget: Rebased task branch 2563b from P2J trunk revision 10892 (new branch revision 10896).
Constantin Asofiei

06/30/2015

06:46 PM Feature #2546: implement combo-box widget in GUI: This merged with recent code update for review adds support for current item selection by mouse hovering. The idea is... Eugenie Lyzenko
03:54 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin, could you look at my update?
>
> Is that what you meant?
>
> When I'm movin... Constantin Asofiei
02:59 PM Feature #1790: implement menu support: Constantin, could you look at my update?
Is that what you meant?
When I'm moving mouse pointer to menu-item in... Vadim Gindin
02:18 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Merged with revno 10892 Igor Skornyakov
01:04 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I've restarted majic build. Igor Skornyakov
12:48 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > I'm planning to restart regression with the most recent version right now.
Please post the merged update for re... Greg Shah
12:40 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> What is the status of regression testing for the 0623b update?
>
> Also: I think you need to m... Igor Skornyakov
09:31 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: What is the status of regression testing for the 0623b update?
Also: I think you need to merge to the latest P2J r... Greg Shah
02:11 PM Feature #2422: add features to BROWSE: The latest update was converted to branch 2422a. Committed to bzr as P2J rev. 10892. Stanislav Lomany
09:25 AM Bug #2588 (Closed): test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTT...: Greg Shah
06:28 AM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: Constantin Asofiei wrote:
> I'm OK with the change, go ahead and release it.
Committed in bzr as @10891@. Eugenie Lyzenko
04:33 AM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: > Please review the change. I can release it because as before no testing is required for GUI code.
I'm OK with the ... Constantin Asofiei

06/29/2015

07:01 PM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: There is one more place to modify regarding this bug. The GUI button does not display image for default button. So th... Eugenie Lyzenko
06:24 PM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: The fix has been committed in bzr as @10890@. Will be distributed shortly. Eugenie Lyzenko
06:12 PM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: Eugenie Lyzenko wrote:
> >This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - pleas... Constantin Asofiei
06:04 PM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: >This should be already covered in branch 2563b @FrameGuiImpl.processDefaultButton@ - please double check this branch... Eugenie Lyzenko
05:51 PM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: Eugenie Lyzenko wrote:
> The conclusion is only @DEFAULT-BUTTON@ frame option has meaning when defining the button t... Constantin Asofiei
05:32 PM Bug #2588: test and fix the relationship between BUTTON:DEFAULT and frame's DEFAULT-BUTTON attribute: >Write the following testcases to check behavior:
>
>1. Does @BUTTON:DEFAULT@ without frame's @DEFAULT-BUTTON@ opti... Eugenie Lyzenko
12:54 PM Feature #1790: implement menu support: Vadim Gindin wrote:
> > Lets change the approach to this: take the menubar's clipping rectangle and, if the ScreenBi... Constantin Asofiei
12:32 PM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > Constantin Asofiei wrote:
> > > Vadim Gindin wrote:
> > > > >... Vadim Gindin
11:30 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Constantin Asofiei wrote:
> > Vadim Gindin wrote:
> > > > A solution would be to repaint the... Constantin Asofiei
10:27 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> Vadim Gindin wrote:
> > > A solution would be to repaint the entire menubar or sub-menu... Vadim Gindin
09:48 AM Feature #1790: implement menu support: > But when I did this change, the error didn't disappear. Was I wrong? Could you have a look at it?
Your change do... Greg Shah
06:53 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> > A solution would be to repaint the entire menubar or sub-menu on mouseEnter/Exit. But I th... Constantin Asofiei
06:34 AM Feature #1790: implement menu support: Constantin Asofiei wrote:
> What I think is happening is this:
> * you are calling a @repaint()@ for a certain menu... Vadim Gindin
06:04 AM Feature #1790: implement menu support: Constantin, thank you, I'll try.
Greg, I've faced with parsing error with the following procedure:... Vadim Gindin
04:45 AM Feature #1790: implement menu support: What I think is happening is this:
* you are calling a @repaint()@ for a certain menu-item; this ensures that an inv... Constantin Asofiei
03:31 AM Feature #1790: implement menu support: Constantin, I have a problem with mouse ENTER and EXIT events processing. When I move mouse pointer from one menu-ite... Vadim Gindin
04:22 AM Feature #2252: implement GUI client support: Rebased task branch 1796b from P2J trunk revision 10888 (branch revision 10890). Constantin Asofiei
04:21 AM Feature #2563: implement GUI EDITOR widget: Rebased task branch 2563b from P2J trunk revision 10888 (new branch revision 10892). Constantin Asofiei

06/28/2015

07:58 PM Feature #2546: implement combo-box widget in GUI: Merge with recent code base for review. In addition the event list chaining in drop-down cycle is now filtering to co... Eugenie Lyzenko
05:37 AM Bug #2601: Implement gap closing mechanism for browse: When some of the records contained in a browse are deleted in background (by @DELETE@, not @DELETE-*-ROW(S)@), "gaps"... Stanislav Lomany
04:11 AM Bug #2601 (New): Implement gap closing mechanism for browse: Stanislav Lomany
05:24 AM Feature #2252: implement GUI client support: Task branch 2559d passed regression testing and was committed to trunk as revision 10888. Hynek Cihlar

06/27/2015

08:14 PM Feature #2546: implement combo-box widget in GUI: Finally the update merged with the recent code base is ready with all fixes required:
1. Resolution for previous upd... Eugenie Lyzenko
08:12 PM Bug #2600: Implement proper refresh after deletion if the deleted row is a new row outside of the...: Example of the behavior - @uast/browse/brws-offset5.p@:
down to 10, n, esc-R, up to 1, d - scrolled to 10.
The ... Stanislav Lomany

06/26/2015

07:45 PM Bug #2600 (New): Implement proper refresh after deletion if the deleted row is a new row outside ...: Stanislav Lomany
07:13 PM Bug #2599: 4GL makes selection invalid after row deletion: 4GL makes selection invalid if we have deleted a selected row and there was a new row in the set of selected rows.
... Stanislav Lomany
07:08 PM Bug #2599 (New): 4GL makes selection invalid after row deletion: Stanislav Lomany
04:12 PM Bug #2598: Adding new row in REPLACE mode causes quirk: Scenario:... Stanislav Lomany
03:55 PM Bug #2598 (New): Adding new row in REPLACE mode causes quirk: Stanislav Lomany
11:58 AM Feature #2252: implement GUI client support: Code Review Task Branch 2559d Revision 10888
The changes look good to me. Please get them tested. Greg Shah
11:31 AM Feature #2252: implement GUI client support: For #2559 I have:
Fixed calculation of workspace size in redirection mode.
Fixed some unhandled exceptions when s... Hynek Cihlar
06:19 AM Bug #2597: Rows are quirky committed on insert-row() call.: General description:
1. Update some row 1.
2. Leave it by calling INSERT-ROW in a trigger. Row 1 will contain updat... Stanislav Lomany
05:37 AM Bug #2597 (New): Rows are quirky committed on insert-row() call.: Stanislav Lomany

06/25/2015

07:47 PM Feature #2546: implement combo-box widget in GUI: The condition of the application to finish is the pressing @RETURN@ key. It is very strange because it is happening e... Eugenie Lyzenko
06:38 PM Feature #2422: add features to BROWSE: Code Review svl_upd20150625a.zip
I'm OK with the changes. Please get them regression tested. Greg Shah
04:45 PM Feature #2422: add features to BROWSE: Update for review. Fixes issue from the checklist in item 178. Stanislav Lomany
07:43 AM Feature #2422: add features to BROWSE: OK, add this to the quirks list. Greg Shah
06:12 PM Bug #2596: Implement missing browse quirks.: Parent task for tracking browse quirks. Stanislav Lomany
06:09 PM Bug #2596 (New): Implement missing browse quirks.: Stanislav Lomany
07:10 AM Feature #2412: Implement widget browser: The task branch 2412a was committed to trunk revision 10887. Hynek Cihlar

06/24/2015

07:11 PM Feature #2422: add features to BROWSE: Regarding "Check how addition of new row works in multiple selection mode (last selected row is used?)". Looks like a... Stanislav Lomany
05:34 PM Feature #2422: add features to BROWSE: Addition to "In 4GL (ChUI) last/first rows has invalid row value." behavior: if the value of the current cell was mod... Stanislav Lomany
11:04 AM Feature #2422: add features to BROWSE: > LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific.
OK, I see they are already listed in #2564. ... Greg Shah
10:59 AM Feature #2422: add features to BROWSE: Yes, but LABEL-BGCOLOR, MOVE-COLUMN and MIN-HEIGHT-CHARS are GUI-specific. Stanislav Lomany
10:53 AM Feature #2422: add features to BROWSE: SET-REPOSITIONED-ROW - used
MODIFIED - used
LABEL-BGCOLOR - used
MOVE-COLUMN - used
MIN-HEIGHT-CHARS - not sure; ... Greg Shah
06:01 PM Feature #2412: Implement widget browser: Code Review Task Branch 2412a Revision 10887
The changes are OK. Greg Shah
05:33 PM Feature #2412: Implement widget browser: I have improved Widget Browser GUI highlight. Restoring the highlighted area was causing artifacts. Also the highligh... Hynek Cihlar
05:31 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't suppor... Greg Shah
05:07 PM Feature #2252: implement GUI client support: Greg, do we need SPACE in GUI? I was playing with some ChUI tests and GUI doesn't support yet the SPACE clause. Constantin Asofiei
12:11 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Please see #2594 - Implement a tracing facility for P2J. Hynek Cihlar
10:55 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> Greg Shah wrote:
> > My point: I'd like this approach to be a "dtrace" for P2J. But as yo... Greg Shah
10:23 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> My point: I'd like this approach to be a "dtrace" for P2J. But as you say, the AspectJ approach ... Igor Skornyakov
10:04 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: > The Aspect-way of monitoring method calls is slow, maybe it would make more sense to use the java.lang.instrument ... Greg Shah
09:57 AM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150623b.zip
I'm good with the changes. Greg Shah
09:41 AM Feature #2546: implement combo-box widget in GUI: Greg Shah wrote:
> In addition to making the processing safer for drop-down, isn't the real problem that the trigger... Eugenie Lyzenko
09:22 AM Feature #2546: implement combo-box widget in GUI: In addition to making the processing safer for drop-down, isn't the real problem that the trigger processing should b... Greg Shah
09:04 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Yes, the @DropDown@ doesn't have an ID yet. You can add a v... Constantin Asofiei
08:54 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Review for 0622a.zip:
> > * @ComboBoxConfig@ - the added im... Constantin Asofiei
08:35 AM Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Review for 0622a.zip:
> * @ComboBoxConfig@ - the added imports are unused
Please cla... Eugenie Lyzenko
08:30 AM Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Yes, the @DropDown@ doesn't have an ID yet. You can add a virtual ID to it via @WidgetI... Eugenie Lyzenko
04:10 AM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> The root cause for ignoring trigger call has been found. During obtaining the server method... Constantin Asofiei
03:57 AM Feature #2546: implement combo-box widget in GUI: Review for 0622a.zip:
* @ComboBoxConfig@ - the added imports are unused
* @DropDown@ - the @fixVisibleRows@ abstrac... Constantin Asofiei
08:30 PM Feature #2546: implement combo-box widget in GUI: The root cause for ignoring trigger call has been found. During obtaining the server method from proxy class the all ... Eugenie Lyzenko
09:24 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: Greg Shah wrote:
> I don't know the answer, but usually the option is just the static way (compile-time) to define a... Igor Skornyakov
09:18 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: I don't know the answer, but usually the option is just the static way (compile-time) to define a feature as part of ... Greg Shah
05:07 AM Feature #2567: add misc widget support part 2: more options, attributes and methods: It looks like there is very much in common between "Options" and "Attributes" sections in this task. Is there any dif... Igor Skornyakov
07:59 AM Feature #1790: implement menu support: Here is the current update Vadim Gindin
03:27 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Please, hepl my with my previous question about duplication. I still didn't find the reason.
... Constantin Asofiei
03:15 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Duplication error has gone after the last Hynek's update! Sorry to trouble.
Please post your ... Constantin Asofiei

06/23/2015

05:34 PM Feature #2422: add features to BROWSE: > Please make a list of browse features (methods, attributes, options) which are stubbed out but which have no runtim... Stanislav Lomany
03:42 PM Feature #2422: add features to BROWSE: For both of these quirks, can you easily detect that the problem would occur? If so, then let's detect those cases (... Greg Shah
03:28 PM Feature #2422: add features to BROWSE: > What does the implementation do today when there is an uncommitted update and INSERT-ROW() is called
At that tim... Stanislav Lomany
02:35 PM Feature #2422: add features to BROWSE: It seems that there are a very large number of postponed browse quirks already. We need a much better approach to tra... Greg Shah
02:31 PM Feature #2422: add features to BROWSE: > Unless it is the first column, you cannot change copied value (only navigation and trigger keys work) until you re-... Greg Shah
02:29 PM Feature #2422: add features to BROWSE: > Side note: in multi-selection browse if a new row is selected and DELETE-CURRENT-ROW/DELETE-SELECTED-ROW was called... Greg Shah
02:27 PM Feature #2422: add features to BROWSE: > Actually rows get to the quirky state. The scenario:
> ...
> Should I reproduce this quirk?
What does the impl... Greg Shah
02:23 PM Feature #2422: add features to BROWSE: Stanislav Lomany wrote:
> It is not implemented at runtime (@Browse.java@):
>
> [...]
This is not good. I did... Greg Shah
10:11 AM Feature #2422: add features to BROWSE: Addition to note 180 ("In 4GL (ChUI) last/first rows has invalid row value"). Unless it is the first column, you cann... Stanislav Lomany
07:35 AM Feature #2422: add features to BROWSE: Greg,
> Check if new/existing rows are undone or committed on insert-row() call.
Actually rows get to the quirk... Stanislav Lomany
05:18 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Fixed based on code review Igor Skornyakov
04:41 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Greg Shah wrote:
> Hynek Cihlar wrote:
> > Igor, I will not give you an answer to your question but I will at least... Hynek Cihlar
03:38 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Code Review ias_upd20150623a.zip
1. @FillIn.isZapActive()@ is missing javadoc and needs a blank line after it.
... Greg Shah
02:47 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: All done. Started regesssion testing. Igor Skornyakov
02:44 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt... Greg Shah
02:37 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresp... Greg Shah
12:50 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor Skornyakov wrote:
> >
> Thank you Hynek,
> What you've mentioned can be very useful indeed. However I had an... Hynek Cihlar
12:38 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Hynek Cihlar wrote:
> Igor, I will not give you an answer to your question but I will at least share with you a litt... Igor Skornyakov
12:28 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: Igor, I will not give you an answer to your question but I will at least share with you a little bit from my kitchen.... Hynek Cihlar
01:40 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Constantin Asofiei wrote:
> > Hynek Cihlar wrote:
> > > The task branch 2559b has been... Hynek Cihlar
01:35 PM Feature #2252: implement GUI client support: Constantin Asofiei wrote:
> Hynek Cihlar wrote:
> > The task branch 2559b has been merged with trunk. Eugenie, you ... Constantin Asofiei
11:29 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda... Constantin Asofiei
12:53 PM Feature #2559 (Closed): implement ALERT-BOX support: Greg Shah
11:58 AM Feature #1790: implement menu support: Duplication error has gone after the last Hynek's update! Sorry to trouble. Vadim Gindin
11:22 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Please, help me with my previous question about duplication. I still didn't find the reason.
... Vadim Gindin
11:01 AM Feature #1790: implement menu support: Please, hepl my with my previous question about duplication. I still didn't find the reason.
Additional question. ... Vadim Gindin
08:44 PM Feature #2546: implement combo-box widget in GUI: The update contains combo-box changes merged with recent code base without recently distributed @Scrollbar@ changes.
... Eugenie Lyzenko

06/22/2015

06:46 PM Feature #2534: methods/attrs support for EDITOR, SELECTION-LIST and COMBO-BOX: I found useful to add a method @LogicalTerminal.debug(int widgetId, message)@ and a corresponding (noop) method @Abst... Igor Skornyakov
04:47 PM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by upda... Eugenie Lyzenko
04:14 PM Feature #2252: implement GUI client support: The task branch 2559b has been merged with trunk. Eugenie, you can now merge the fixes by updating the trunk branch. Hynek Cihlar
10:51 AM Feature #2252: implement GUI client support: Greg, there is a change that affects ChUI so I would like to finish regression testing first. Hynek Cihlar
10:13 AM Feature #2252: implement GUI client support: Hynek: I think you should merge task branch 2559b revision 10883 with trunk and commit it. This will allow Eugenie t... Greg Shah
08:54 AM Feature #2252: implement GUI client support: Eugenie Lyzenko wrote:
> >The main window height was not properly calculated and so the scrollbar was shown when it ... Hynek Cihlar

06/21/2015

06:02 PM Feature #2252: implement GUI client support: >The main window height was not properly calculated and so the scrollbar was shown when it should not have. This is a... Eugenie Lyzenko
02:55 PM Feature #2252: implement GUI client support: Eugenie Lyzenko wrote:
> Hynek Cihlar wrote:
> > For #2559, please review regression fixes committed to task branch... Hynek Cihlar

06/20/2015

01:53 PM Feature #2252: implement GUI client support: Greg Shah wrote:
> Code Review Task Branch 2559b Revision 10883
>
> I'm fine with the changes.
>
> Am I correc... Hynek Cihlar
10:46 AM Feature #2252: implement GUI client support: Code Review Task Branch 2559b Revision 10883
I'm fine with the changes.
Am I correct to assume the other items ... Greg Shah
10:29 AM Feature #2252: implement GUI client support: Hynek Cihlar wrote:
> For #2559, please review regression fixes committed to task branch 2559b. The changes do not a... Eugenie Lyzenko
06:41 AM Feature #2252: implement GUI client support: For #2559, please review regression fixes committed to task branch 2559b. The changes do not affect ChUI so no Majic ... Hynek Cihlar

06/19/2015

05:18 PM Feature #2252: implement GUI client support: Task branch 2559 has been committed to bzr trunk, revision 10882. Hynek Cihlar
09:26 AM Feature #2252: implement GUI client support: Code Review Task Branch 2559 rev 10881
I'm good with the changes. Please merge to trunk, commit and notify. Greg Shah
09:21 PM Feature #2252: implement GUI client support: For #2559, I have resolved all the points from the last review, fixed all regressions and other bugs found. The chang... Hynek Cihlar
04:08 PM Feature #2546: implement combo-box widget in GUI: The update for review has implementation for @ThinClient@ change related to the mouse clicks outside drop-down. The n... Eugenie Lyzenko
10:44 PM Feature #2546: implement combo-box widget in GUI: The update for review has subtracted @Scrollbar@ related code that distributed separately. Also it contains suggested... Eugenie Lyzenko
10:07 PM Feature #2546: implement combo-box widget in GUI: Committed in bzr as @10881@. Eugenie Lyzenko
09:52 PM Feature #2546: implement combo-box widget in GUI: Testing completed, no regressions, had to run 3-way CTRL-C tests in separate session. The results are: @10879_bb2f7ec... Eugenie Lyzenko
08:25 PM Feature #2546: implement combo-box widget in GUI: Finally the main part of the testing for 0617b completed without regressions. I'm expecting to finish @CTRL-C@ testin... Eugenie Lyzenko
01:41 PM Feature #2563: implement GUI EDITOR widget: Greg Shah wrote:
> My only question is whether you want to go before or after Igor's #2534 changes?
I'd like to go ... Constantin Asofiei
12:34 PM Feature #2563: implement GUI EDITOR widget: > I have already checked in and distributed the 0617b Scrollbar related update.
Right, sorry.
> It is required... Greg Shah
11:08 AM Feature #2563: implement GUI EDITOR widget: Greg Shah wrote:
> ... I know you are waiting on Eugenie's to pass and be checked in and then will merge those...
... Eugenie Lyzenko
10:51 AM Feature #2563: implement GUI EDITOR widget: Code Review Task Branch 2563b revision 10884
I like the changes, nice improvement.
Hynek's changes will need to... Greg Shah
05:54 AM Feature #2563: implement GUI EDITOR widget: rebased branch 2563b, new revision is 10884 Constantin Asofiei
01:07 PM Feature #1790: implement menu support: I've fixed it. But now it displays sub-menu twice in 2 different places. Have a look please. Why it can happen? Vadim Gindin
06:46 AM Feature #1790: implement menu support: Vadim Gindin wrote:
> Here is my current update. Could you review and help me? I can't understand why nested sub-men... Constantin Asofiei
03:58 AM Feature #1790: implement menu support: Here is my current update. Could you review and help me? I can't understand why nested sub-menu body isn't drawn when... Vadim Gindin

06/18/2015

04:12 PM Feature #2563: implement GUI EDITOR widget: branch 2563b/rev 10882 passed testing Constantin Asofiei
08:19 AM Feature #2563: implement GUI EDITOR widget: branch 2563b/rev 10882: Fixed javadoc errors. Added mouse-double-click support. Fixed scrolling by mouse and other ... Constantin Asofiei
01:42 PM Feature #2546: implement combo-box widget in GUI: One more point to clarify.
I'm trying to make the drop-down list event processing loop more reliable an responsibl... Eugenie Lyzenko
02:30 AM Feature #2422: add features to BROWSE: It is not implemented at runtime (@Browse.java@):... Stanislav Lomany

06/17/2015

05:05 PM Feature #2422: add features to BROWSE: I don't understand. As far as I can see, we already support @SET-REPOSITIONED-ROW@ both at runtime and in conversion... Greg Shah
04:55 PM Feature #2422: add features to BROWSE: > Doesn't @GET-REPOSITIONED-ROW@ still need to be done?
@GET-REPOSITIONED-ROW@ always returns _1_ unless the row w... Stanislav Lomany
11:37 AM Feature #2422: add features to BROWSE: >> What else is open in this task?
>
> My checklist:
> ...
Doesn't @GET-REPOSITIONED-ROW@ still need to be done? Greg Shah
03:44 PM Feature #2563: implement GUI EDITOR widget: Code Review 2563b branch (rev 10881)
This is a really good update. I don't have any concerns. Greg Shah
02:28 PM Feature #2563: implement GUI EDITOR widget: I've added the EDITOR changes (and some scroll-related changes from #2546 - rev 10880) to the 2563b branch (rev 10881... Constantin Asofiei
02:39 PM Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Eugenie Lyzenko wrote:
> > Here it is.
> @ScrollEvent@ class is needed - please add th... Eugenie Lyzenko
01:48 PM Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150617a.zip
I'm OK with the changes. Please get them regression tested. Greg Shah
01:42 PM Feature #2546: implement combo-box widget in GUI: Eugenie Lyzenko wrote:
> Constantin Asofiei wrote:
> > Eugenie, can you extract the changes in the @Scrollbar*@ cla... Constantin Asofiei
10:34 AM Feature #2546: implement combo-box widget in GUI: Constantin Asofiei wrote:
> Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, s... Eugenie Lyzenko
09:49 AM Feature #2546: implement combo-box widget in GUI: Eugenie, can you extract the changes in the @Scrollbar*@ classes in a separate update, so they can be released? I thi... Constantin Asofiei
09:12 AM Feature #2546: implement combo-box widget in GUI: > And I'm inclining to leave the current approach for ChUI only mode and implement completely different approach in G... Greg Shah
09:09 AM Feature #2546: implement combo-box widget in GUI: Code Review evl_upd20150616a.zip
The code changes are fine. Greg Shah

« Previous

Also available in: Atom

Project

General

Profile

FWD » Core Development » User Interface

Activity

Activity

07/17/2015

07/16/2015

07/15/2015

07/14/2015

07/13/2015

07/10/2015

07/09/2015

07/08/2015

07/07/2015

07/06/2015

07/03/2015

07/02/2015

07/01/2015

06/30/2015

06/29/2015

06/28/2015

06/27/2015

06/26/2015

06/25/2015

06/24/2015

06/23/2015

06/22/2015

06/21/2015

06/20/2015

06/19/2015

06/18/2015

06/17/2015